Skip to content
Snippets Groups Projects
  • Richard Mudgett's avatar
    52a7cdb1
    AMI: Make AMI actions that generate event lists consistent. · 52a7cdb1
    Richard Mudgett authored
    * Made the following AMI actions use list API calls for consistency:
    Agents
    BridgeInfo
    BridgeList
    BridgeTechnologyList
    ConfbridgeLIst
    ConfbridgeLIstRooms
    CoreShowChannels
    DAHDIShowChannels
    DBGet
    DeviceStateList
    ExtensionStateList
    FAXSessions
    Hangup
    IAXpeerlist
    IAXpeers
    IAXregistry
    MeetmeList
    MeetmeListRooms
    MWIGet
    ParkedCalls
    Parkinglots
    PJSIPShowEndpoint
    PJSIPShowEndpoints
    PJSIPShowRegistrationsInbound
    PJSIPShowRegistrationsOutbound
    PJSIPShowResourceLists
    PJSIPShowSubscriptionsInbound
    PJSIPShowSubscriptionsOutbound
    PresenceStateList
    PRIShowSpans
    QueueStatus
    QueueSummary
    ShowDialPlan
    SIPpeers
    SIPpeerstatus
    SIPshowregistry
    SKINNYdevices
    SKINNYlines
    Status
    VoicemailUsersList
    
    * Incremented the AMI version to 2.7.0.
    
    * Changed astman_send_listack() to not use the listflag parameter and
    always set the value to "Start" so the start capitalization is consistent.
    i.e., The FAXSessions used "Start" while the rest of the system used
    "start".  The corresponding complete event always used "Complete".
    
    * Fixed ami_show_resource_lists() "PJSIPShowResourceLists" to output the
    AMI ActionID for all of its list events.
    
    * Fixed off-nominal AMI protocol error in manager_bridge_info(),
    manager_parking_status_single_lot(), and
    manager_parking_status_all_lots().  Use of astman_send_error() after
    responding to the original AMI action request violates the action response
    pattern by sending two responses.
    
    * Fixed minor protocol error in action_getconfig() when no requested
    categories are found.  Each line needs to be formatted as "Header: text".
    
    * Fixed off-nominal memory leak in manager_build_parked_call_string().
    
    * Eliminated unnecessary use of RAII_VAR() in ami_subscription_detail().
    
    ASTERISK-24049 #close
    Reported by: Jonathan Rose
    
    Review: https://reviewboard.asterisk.org/r/4315/
    ........
    
    Merged revisions 430434 from http://svn.asterisk.org/svn/asterisk/branches/13
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@430435 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    52a7cdb1
    History
    AMI: Make AMI actions that generate event lists consistent.
    Richard Mudgett authored
    * Made the following AMI actions use list API calls for consistency:
    Agents
    BridgeInfo
    BridgeList
    BridgeTechnologyList
    ConfbridgeLIst
    ConfbridgeLIstRooms
    CoreShowChannels
    DAHDIShowChannels
    DBGet
    DeviceStateList
    ExtensionStateList
    FAXSessions
    Hangup
    IAXpeerlist
    IAXpeers
    IAXregistry
    MeetmeList
    MeetmeListRooms
    MWIGet
    ParkedCalls
    Parkinglots
    PJSIPShowEndpoint
    PJSIPShowEndpoints
    PJSIPShowRegistrationsInbound
    PJSIPShowRegistrationsOutbound
    PJSIPShowResourceLists
    PJSIPShowSubscriptionsInbound
    PJSIPShowSubscriptionsOutbound
    PresenceStateList
    PRIShowSpans
    QueueStatus
    QueueSummary
    ShowDialPlan
    SIPpeers
    SIPpeerstatus
    SIPshowregistry
    SKINNYdevices
    SKINNYlines
    Status
    VoicemailUsersList
    
    * Incremented the AMI version to 2.7.0.
    
    * Changed astman_send_listack() to not use the listflag parameter and
    always set the value to "Start" so the start capitalization is consistent.
    i.e., The FAXSessions used "Start" while the rest of the system used
    "start".  The corresponding complete event always used "Complete".
    
    * Fixed ami_show_resource_lists() "PJSIPShowResourceLists" to output the
    AMI ActionID for all of its list events.
    
    * Fixed off-nominal AMI protocol error in manager_bridge_info(),
    manager_parking_status_single_lot(), and
    manager_parking_status_all_lots().  Use of astman_send_error() after
    responding to the original AMI action request violates the action response
    pattern by sending two responses.
    
    * Fixed minor protocol error in action_getconfig() when no requested
    categories are found.  Each line needs to be formatted as "Header: text".
    
    * Fixed off-nominal memory leak in manager_build_parked_call_string().
    
    * Eliminated unnecessary use of RAII_VAR() in ami_subscription_detail().
    
    ASTERISK-24049 #close
    Reported by: Jonathan Rose
    
    Review: https://reviewboard.asterisk.org/r/4315/
    ........
    
    Merged revisions 430434 from http://svn.asterisk.org/svn/asterisk/branches/13
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@430435 65c4cc65-6c06-0410-ace0-fbb531ad65f3