Skip to content
Snippets Groups Projects
  • Ben Ford's avatar
    0e56643d
    res_rtp: Add unit tests for RTCP stats. · 0e56643d
    Ben Ford authored
    Added unit tests for RTCP video stats. These tests include NACK, REMB,
    FIR/FUR/PLI, SR/RR/SDES, and packet loss statistics. The REMB and FIR
    tests are currently disabled due to a bug. We expect to receive a
    compound packet, but the code sends this out as a single packet, which
    the browser accepts, but makes Asterisk upset.
    
    While writing these tests, I noticed an issue with NACK as well. Where
    it is handling a received NACK request, it was reading in only the first
    8 bits of following packets that were also lost. This has been changed
    to the correct value of 16 bits.
    
    Also made a minor fix to the data buffer unit test.
    
    Change-Id: I56107c7411003a247589bbb6086d25c54719901b
    0e56643d
    History
    res_rtp: Add unit tests for RTCP stats.
    Ben Ford authored
    Added unit tests for RTCP video stats. These tests include NACK, REMB,
    FIR/FUR/PLI, SR/RR/SDES, and packet loss statistics. The REMB and FIR
    tests are currently disabled due to a bug. We expect to receive a
    compound packet, but the code sends this out as a single packet, which
    the browser accepts, but makes Asterisk upset.
    
    While writing these tests, I noticed an issue with NACK as well. Where
    it is handling a received NACK request, it was reading in only the first
    8 bits of following packets that were also lost. This has been changed
    to the correct value of 16 bits.
    
    Also made a minor fix to the data buffer unit test.
    
    Change-Id: I56107c7411003a247589bbb6086d25c54719901b