Skip to content
Snippets Groups Projects
  • David M. Lee's avatar
    7d0d1a1e
    ari: User better nicknames for ARI operations · 7d0d1a1e
    David M. Lee authored
    While working on building client libraries from the Swagger API, I
    noticed a problem with the nicknames.
    
        channel.deleteChannel()
        channel.answerChannel()
        channel.muteChannel()
    
    Etc. We put the object name in the nickname (since we were generating C
    code), but it makes OO generators redundant.
    
    This patch makes the nicknames more OO friendly. This resulted in a lot
    of name changing within the res_ari_*.so modules, but not much else.
    
    There were a couple of other fixed I made in the process.
    
     * When reversible operations (POST /hold, POST /unhold) were made more
       RESTful (POST /hold, DELETE /unhold), the path for the second operation
       was left in the API declaration. This worked, but really the two
       operations should have been on the same API.
     * The POST /unmute operation had still not been REST-ified.
    
    Review: https://reviewboard.asterisk.org/r/2940/
    ........
    
    Merged revisions 402528 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    7d0d1a1e
    History
    ari: User better nicknames for ARI operations
    David M. Lee authored
    While working on building client libraries from the Swagger API, I
    noticed a problem with the nicknames.
    
        channel.deleteChannel()
        channel.answerChannel()
        channel.muteChannel()
    
    Etc. We put the object name in the nickname (since we were generating C
    code), but it makes OO generators redundant.
    
    This patch makes the nicknames more OO friendly. This resulted in a lot
    of name changing within the res_ari_*.so modules, but not much else.
    
    There were a couple of other fixed I made in the process.
    
     * When reversible operations (POST /hold, POST /unhold) were made more
       RESTful (POST /hold, DELETE /unhold), the path for the second operation
       was left in the API declaration. This worked, but really the two
       operations should have been on the same API.
     * The POST /unmute operation had still not been REST-ified.
    
    Review: https://reviewboard.asterisk.org/r/2940/
    ........
    
    Merged revisions 402528 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
res_ari_bridges.c 23.56 KiB