Skip to content
Snippets Groups Projects
  • Joshua Colp's avatar
    7f09fd2c
    bridge/core_unreal: Fix SFU bugs with forwarding frames. · 7f09fd2c
    Joshua Colp authored
    This change fixes a few things uncovered during SFU testing.
    
    1. Unreal channels incorrectly forwarded video frames when
    no video stream was present on them. This caused a crash when
    they were read as the core requires a stream to exist for the
    underlying media type. The Unreal channel will now ensure a
    stream exists for the media type before forwarding the frame
    and if no stream exists then the frame is dropped.
    
    2. Mapping of frames during bridging from the stream number of
    the underlying channel to the stream number of the bridge was
    done in the wrong location. This resulted in the frame getting
    dropped. This mapping now occurs on reading of the frame from
    the channel.
    
    3. Bridging was using the wrong ast_read function resulting in
    it living in a non-multistream world.
    
    4. In bridge_softmix when adding new streams to existing channels
    the wrong stream topology was copied resulting in no streams
    being added.
    
    Change-Id: Ib7445722c3219951d6740802a0feddf2908c18c8
    7f09fd2c
    History
    bridge/core_unreal: Fix SFU bugs with forwarding frames.
    Joshua Colp authored
    This change fixes a few things uncovered during SFU testing.
    
    1. Unreal channels incorrectly forwarded video frames when
    no video stream was present on them. This caused a crash when
    they were read as the core requires a stream to exist for the
    underlying media type. The Unreal channel will now ensure a
    stream exists for the media type before forwarding the frame
    and if no stream exists then the frame is dropped.
    
    2. Mapping of frames during bridging from the stream number of
    the underlying channel to the stream number of the bridge was
    done in the wrong location. This resulted in the frame getting
    dropped. This mapping now occurs on reading of the frame from
    the channel.
    
    3. Bridging was using the wrong ast_read function resulting in
    it living in a non-multistream world.
    
    4. In bridge_softmix when adding new streams to existing channels
    the wrong stream topology was copied resulting in no streams
    being added.
    
    Change-Id: Ib7445722c3219951d6740802a0feddf2908c18c8