Skip to content
Snippets Groups Projects
  • Steve Murphy's avatar
    a2367c07
    Merged revisions 118858 via svnmerge from · a2367c07
    Steve Murphy authored
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
    r118858 | murf | 2008-05-28 18:25:28 -0600 (Wed, 28 May 2008) | 46 lines
    
    (closes issue #10668)
    (closes issue #11721)
    (closes issue #12726)
    Reported by: arkadia
    Tested by: murf
    
    These changes:
    
    1. revert the changes made via bug 10668; 
       I should have known that such changes,
       even tho they made sense at the time,
       seemed like an omission, etc, were actually
       integral to the CDR system via forkCDR.
       It makes sense to me now that forkCDR didn't
       natively end any CDR's, but rather depended
       on natively closing them all at hangup time
       via traversing and closing them all, whether
       locked or not. I still don't completely 
       understand the benefits of setvar and answer
       operating on locked cdrs, but I've seen 
       enough to revert those changes also, and
       stop messing up users who depended on that
       behavior. bug 12726 found reverting the changes
       fixed his changes, and after a long review
       and working on forkCDR, I can see why.
    2. Apply the suggested enhancements proposed
       in 10668, but in a completely compatible
       way. ForkCDR will behave exactly as before,
       but now has new options that will allow some
       actions to be taken that will slightly 
       modify the outcome and side-effects of
       forkCDR. Based on conversations I've had 
       with various people, these small tweaks
       will allow some users to get the behavior
       they need. For instance, users executing
       forkCDR in an AGI script will find the
       answer time set, and DISPOSITION set, 
       a situation not covered when the routines
      were first written.
    3. A small problem in the cdr serializer
       would output answer and end times even
       when they were not set. This is now 
       fixed.
    
    
    
    ........
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    a2367c07
    History
    Merged revisions 118858 via svnmerge from
    Steve Murphy authored
    https://origsvn.digium.com/svn/asterisk/branches/1.4
    
    ........
    r118858 | murf | 2008-05-28 18:25:28 -0600 (Wed, 28 May 2008) | 46 lines
    
    (closes issue #10668)
    (closes issue #11721)
    (closes issue #12726)
    Reported by: arkadia
    Tested by: murf
    
    These changes:
    
    1. revert the changes made via bug 10668; 
       I should have known that such changes,
       even tho they made sense at the time,
       seemed like an omission, etc, were actually
       integral to the CDR system via forkCDR.
       It makes sense to me now that forkCDR didn't
       natively end any CDR's, but rather depended
       on natively closing them all at hangup time
       via traversing and closing them all, whether
       locked or not. I still don't completely 
       understand the benefits of setvar and answer
       operating on locked cdrs, but I've seen 
       enough to revert those changes also, and
       stop messing up users who depended on that
       behavior. bug 12726 found reverting the changes
       fixed his changes, and after a long review
       and working on forkCDR, I can see why.
    2. Apply the suggested enhancements proposed
       in 10668, but in a completely compatible
       way. ForkCDR will behave exactly as before,
       but now has new options that will allow some
       actions to be taken that will slightly 
       modify the outcome and side-effects of
       forkCDR. Based on conversations I've had 
       with various people, these small tweaks
       will allow some users to get the behavior
       they need. For instance, users executing
       forkCDR in an AGI script will find the
       answer time set, and DISPOSITION set, 
       a situation not covered when the routines
      were first written.
    3. A small problem in the cdr serializer
       would output answer and end times even
       when they were not set. This is now 
       fixed.
    
    
    
    ........
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118880 65c4cc65-6c06-0410-ace0-fbb531ad65f3