Skip to content
Snippets Groups Projects
  • Mark Michelson's avatar
    a89964a5
    Make CDR and CEL unit tests less FRACKy. · a89964a5
    Mark Michelson authored
    Prior to this commit, CDR and CEL tests were expected to trigger
    FRACKs (i.e. assertions) due to the fact that the channels they
    create have no formats on them. Some code was independently added
    recently that attempts to prevent FRACKs from occurring by failing
    early when attempting to set up translation paths if one or both
    channels support no formats. Unfortunately, this attempt to be helpful
    made the CDR and CEL tests go from simply FRACKing to outright
    failing and in some cases, failing so badly as to crash Asterisk.
    
    This commit seeks to correct past mistakes by adding the ulaw format
    to channels created by the CDR and CEL unit tests. This makes setting
    up translation paths succeed, eliminates previously-seen FRACKs, and
    ultimately causes the unit tests to succeed again.
    
    Review: https://reviewboard.asterisk.org/r/4014
    ........
    
    Merged revisions 423783 from http://svn.asterisk.org/svn/asterisk/branches/13
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@423784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    a89964a5
    History
    Make CDR and CEL unit tests less FRACKy.
    Mark Michelson authored
    Prior to this commit, CDR and CEL tests were expected to trigger
    FRACKs (i.e. assertions) due to the fact that the channels they
    create have no formats on them. Some code was independently added
    recently that attempts to prevent FRACKs from occurring by failing
    early when attempting to set up translation paths if one or both
    channels support no formats. Unfortunately, this attempt to be helpful
    made the CDR and CEL tests go from simply FRACKing to outright
    failing and in some cases, failing so badly as to crash Asterisk.
    
    This commit seeks to correct past mistakes by adding the ulaw format
    to channels created by the CDR and CEL unit tests. This makes setting
    up translation paths succeed, eliminates previously-seen FRACKs, and
    ultimately causes the unit tests to succeed again.
    
    Review: https://reviewboard.asterisk.org/r/4014
    ........
    
    Merged revisions 423783 from http://svn.asterisk.org/svn/asterisk/branches/13
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@423784 65c4cc65-6c06-0410-ace0-fbb531ad65f3