Skip to content
Snippets Groups Projects
  • Michael L. Young's avatar
    03286cf2
    Fix For Not Overriding The Default Settings In chan_sip · 03286cf2
    Michael L. Young authored
    The initial report was that the "nat" setting in the [general] section was not
    having any effect in overriding the default setting.  Upon confirming that this
    was happening and looking into what was causing this, it was discovered that
    other default settings would not be overriden as well.
    
    This patch works similar to what occurs in build_peer().  We create a temporary
    ast_flags structure and using a mask, we override the default settings with
    whatever is set in the [general] section.
    
    In the bug report, the reporter who helped to test this patch noted that the
    directmedia settings were being overriden properly as well as the nat settings.
    
    This issue is also present in Asterisk 1.8 and a separate patch will be applied
    to it.
    
    (issue ASTERISK-21225)
    Reported by: Alexandre Vezina
    Tested by: Alexandre Vezina, Michael L. Young
    Patches:
      asterisk-21225-handle-options-default-prob_v4.diff
    						Michael L. Young (license 5026)
    
    Review: https://reviewboard.asterisk.org/r/2385/
    ........
    
    Merged revisions 384827 from http://svn.asterisk.org/svn/asterisk/branches/11
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@384828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    03286cf2
    History
    Fix For Not Overriding The Default Settings In chan_sip
    Michael L. Young authored
    The initial report was that the "nat" setting in the [general] section was not
    having any effect in overriding the default setting.  Upon confirming that this
    was happening and looking into what was causing this, it was discovered that
    other default settings would not be overriden as well.
    
    This patch works similar to what occurs in build_peer().  We create a temporary
    ast_flags structure and using a mask, we override the default settings with
    whatever is set in the [general] section.
    
    In the bug report, the reporter who helped to test this patch noted that the
    directmedia settings were being overriden properly as well as the nat settings.
    
    This issue is also present in Asterisk 1.8 and a separate patch will be applied
    to it.
    
    (issue ASTERISK-21225)
    Reported by: Alexandre Vezina
    Tested by: Alexandre Vezina, Michael L. Young
    Patches:
      asterisk-21225-handle-options-default-prob_v4.diff
    						Michael L. Young (license 5026)
    
    Review: https://reviewboard.asterisk.org/r/2385/
    ........
    
    Merged revisions 384827 from http://svn.asterisk.org/svn/asterisk/branches/11
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@384828 65c4cc65-6c06-0410-ace0-fbb531ad65f3