Skip to content
Snippets Groups Projects
  • Richard Mudgett's avatar
    a657ab12
    app_directory: Fix crash when using the alias option 'a'. · a657ab12
    Richard Mudgett authored
    The voicemail.conf mailbox key/value pair is defined as:
    <mailbox>=[<password>[,<full-name>[,<email>[,<pager>[,<options>]]]]]
    Where all fields in the value including the field values are optional.
    
    Since the parsing code for the mailbox key/value pair is sloppy, this
    patch tightens the parsing for the directory information.
    
    * Renamed the 'pos' and 'bufptr' variables to 'name' and 'options'
    respectively in search_directory_sub().  Those names make more sense.
    
    * Made sure that search_directory_sub() is dealing with the voicemail.conf
    mailbox options field if it even exists when looking for the 'hidefromdir'
    and 'alias' options.
    
    * Fix crash if a voicemail.conf mailbox is just
    <mailbox>=<password>,<name> when the 'a' option is used.  If there were no
    fields after the name then the 'options' pointer was not checked for NULL.
    
    * Fix users.conf alias processing if the 'a' option is used.  The wrong
    variable was used.
    
    ASTERISK-25087 #close
    Reported by: Chet Stevens
    
    Change-Id: I86052ea77307beddddba5279824d39dc0d593374
    a657ab12
    History
    app_directory: Fix crash when using the alias option 'a'.
    Richard Mudgett authored
    The voicemail.conf mailbox key/value pair is defined as:
    <mailbox>=[<password>[,<full-name>[,<email>[,<pager>[,<options>]]]]]
    Where all fields in the value including the field values are optional.
    
    Since the parsing code for the mailbox key/value pair is sloppy, this
    patch tightens the parsing for the directory information.
    
    * Renamed the 'pos' and 'bufptr' variables to 'name' and 'options'
    respectively in search_directory_sub().  Those names make more sense.
    
    * Made sure that search_directory_sub() is dealing with the voicemail.conf
    mailbox options field if it even exists when looking for the 'hidefromdir'
    and 'alias' options.
    
    * Fix crash if a voicemail.conf mailbox is just
    <mailbox>=<password>,<name> when the 'a' option is used.  If there were no
    fields after the name then the 'options' pointer was not checked for NULL.
    
    * Fix users.conf alias processing if the 'a' option is used.  The wrong
    variable was used.
    
    ASTERISK-25087 #close
    Reported by: Chet Stevens
    
    Change-Id: I86052ea77307beddddba5279824d39dc0d593374