Skip to content
Snippets Groups Projects
  • Corey Farrell's avatar
    1bf3dfff
    AST-2017-006: Fix app_minivm application MinivmNotify command injection · 1bf3dfff
    Corey Farrell authored
    An admin can configure app_minivm with an externnotify program to be run
    when a voicemail is received.  The app_minivm application MinivmNotify
    uses ast_safe_system() for this purpose which is vulnerable to command
    injection since the Caller-ID name and number values given to externnotify
    can come from an external untrusted source.
    
    * Add ast_safe_execvp() function.  This gives modules the ability to run
    external commands with greater safety compared to ast_safe_system().
    Specifically when some parameters are filled by untrusted sources the new
    function does not allow malicious input to break argument encoding.  This
    may be of particular concern where CALLERID(name) or CALLERID(num) may be
    used as a parameter to a script run by ast_safe_system() which could
    potentially allow arbitrary command execution.
    
    * Changed app_minivm.c:run_externnotify() to use the new ast_safe_execvp()
    instead of ast_safe_system() to avoid command injection.
    
    * Document code injection potential from untrusted data sources for other
    shell commands that are under user control.
    
    ASTERISK-27103
    
    Change-Id: I7552472247a84cde24e1358aaf64af160107aef1
    1bf3dfff
    History
    AST-2017-006: Fix app_minivm application MinivmNotify command injection
    Corey Farrell authored
    An admin can configure app_minivm with an externnotify program to be run
    when a voicemail is received.  The app_minivm application MinivmNotify
    uses ast_safe_system() for this purpose which is vulnerable to command
    injection since the Caller-ID name and number values given to externnotify
    can come from an external untrusted source.
    
    * Add ast_safe_execvp() function.  This gives modules the ability to run
    external commands with greater safety compared to ast_safe_system().
    Specifically when some parameters are filled by untrusted sources the new
    function does not allow malicious input to break argument encoding.  This
    may be of particular concern where CALLERID(name) or CALLERID(num) may be
    used as a parameter to a script run by ast_safe_system() which could
    potentially allow arbitrary command execution.
    
    * Changed app_minivm.c:run_externnotify() to use the new ast_safe_execvp()
    instead of ast_safe_system() to avoid command injection.
    
    * Document code injection potential from untrusted data sources for other
    shell commands that are under user control.
    
    ASTERISK-27103
    
    Change-Id: I7552472247a84cde24e1358aaf64af160107aef1