Skip to content
Snippets Groups Projects
  • David M. Lee's avatar
    451993f4
    ARI: WebSocket event cleanup · 451993f4
    David M. Lee authored
    Stasis events (which get distributed over the ARI WebSocket) are created
    by subscribing to the channel_all_cached and bridge_all_cached topics,
    filtering out events for channels/bridges currently subscribed to.
    
    There are two issues with that. First was a race condition, where
    messages in-flight to the master subscribe-to-all-things topic would get
    sent out, even though the events happened before the channel was put
    into Stasis. Secondly, as the number of channels and bridges grow in the
    system, the work spent filtering messages becomes excessive.
    
    Since r395954, individual channels and bridges have caching topics, and
    can be subscribed to individually. This patch takes advantage, so that
    channels and bridges are subscribed to on demand, instead of filtering
    the global topics.
    
    The one case where filtering is still required is handling BridgeMerge
    messages, which are published directly to the bridge_all topic.
    
    Other than the change to how subscriptions work, this patch mostly just
    moves code around. Most of the work generating JSON objects from
    messages was moved to .to_json handlers on the message types. The
    callback functions handling app subscriptions were moved from res_stasis
    (b/c they were global to the model) to stasis/app.c (b/c they are local
    to the app now).
    
    (closes issue ASTERISK-21969)
    Reported by: Matt Jordan
    Review: https://reviewboard.asterisk.org/r/2754/
    ........
    
    Merged revisions 397816 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@397820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    451993f4
    History
    ARI: WebSocket event cleanup
    David M. Lee authored
    Stasis events (which get distributed over the ARI WebSocket) are created
    by subscribing to the channel_all_cached and bridge_all_cached topics,
    filtering out events for channels/bridges currently subscribed to.
    
    There are two issues with that. First was a race condition, where
    messages in-flight to the master subscribe-to-all-things topic would get
    sent out, even though the events happened before the channel was put
    into Stasis. Secondly, as the number of channels and bridges grow in the
    system, the work spent filtering messages becomes excessive.
    
    Since r395954, individual channels and bridges have caching topics, and
    can be subscribed to individually. This patch takes advantage, so that
    channels and bridges are subscribed to on demand, instead of filtering
    the global topics.
    
    The one case where filtering is still required is handling BridgeMerge
    messages, which are published directly to the bridge_all topic.
    
    Other than the change to how subscriptions work, this patch mostly just
    moves code around. Most of the work generating JSON objects from
    messages was moved to .to_json handlers on the message types. The
    callback functions handling app subscriptions were moved from res_stasis
    (b/c they were global to the model) to stasis/app.c (b/c they are local
    to the app now).
    
    (closes issue ASTERISK-21969)
    Reported by: Matt Jordan
    Review: https://reviewboard.asterisk.org/r/2754/
    ........
    
    Merged revisions 397816 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@397820 65c4cc65-6c06-0410-ace0-fbb531ad65f3