Skip to content
Snippets Groups Projects
  • Bernd Zobl's avatar
    c30f68a5
    res_pjsip_sdp_rtp: Evaluate remotely held for Session Progress · c30f68a5
    Bernd Zobl authored
    With the fix for ASTERISK_28754 channels are no longer put on hold if an
    outbound INVITE is answered with a "Session Progress" containing
    "inactive" audio.
    
    The previous change moved the evaluation of the media attributes to
    `negotiate_incoming_sdp_stream()` to have the `remotely_held` status
    available when building the SDP in `create_outgoing_sdp_stream()`.
    This however means that an answer to an outbound INVITE, which does not
    traverse `negotiate_incoming_sdp_stream()`, cannot set the
    `remotely_held` status anymore.
    
    This change moves the check so that both, `negotiate_incoming_sdp_stream()` and
    `apply_negotiated_sdp_stream()` can do the checks.
    
    ASTERISK-29479
    
    Change-Id: Icde805a819399d5123b688e1ed1d2bcd9d5b0f75
    c30f68a5
    History
    res_pjsip_sdp_rtp: Evaluate remotely held for Session Progress
    Bernd Zobl authored
    With the fix for ASTERISK_28754 channels are no longer put on hold if an
    outbound INVITE is answered with a "Session Progress" containing
    "inactive" audio.
    
    The previous change moved the evaluation of the media attributes to
    `negotiate_incoming_sdp_stream()` to have the `remotely_held` status
    available when building the SDP in `create_outgoing_sdp_stream()`.
    This however means that an answer to an outbound INVITE, which does not
    traverse `negotiate_incoming_sdp_stream()`, cannot set the
    `remotely_held` status anymore.
    
    This change moves the check so that both, `negotiate_incoming_sdp_stream()` and
    `apply_negotiated_sdp_stream()` can do the checks.
    
    ASTERISK-29479
    
    Change-Id: Icde805a819399d5123b688e1ed1d2bcd9d5b0f75