Skip to content
Snippets Groups Projects
  • David M. Lee's avatar
    e1b959cc
    Split caching out from the stasis_caching_topic. · e1b959cc
    David M. Lee authored
    In working with res_stasis, I discovered a significant limitation to
    the current structure of stasis_caching_topics: you cannot subscribe
    to cache updates for a single channel/bridge/endpoint/etc.
    
    To address this, this patch splits the cache away from the
    stasis_caching_topic, making it a first class object. The stasis_cache
    object is shared amongst individual stasis_caching_topics that are
    created per channel/endpoint/etc. These are still forwarded to global
    whatever_all_cached topics, so their use from most of the code does
    not change.
    
    In making these changes, I noticed that we frequently used a similar
    pattern for bridges, endpoints and channels:
    
         single_topic  ---------------->  all_topic
               ^
               |
         single_topic_cached  ----+---->  all_topic_cached
                                  |
                                  +---->  cache
    
    This pattern was extracted as the 'Stasis Caching Pattern', defined in
    stasis_caching_pattern.h. This avoids a lot of duplicate code between
    the different domain objects.
    
    Since the cache is now disassociated from its upstream caching topics,
    this also necessitated a change to how the 'guaranteed' flag worked
    for retrieving from a cache. The code for handling the caching
    guarantee was extracted into a 'stasis_topic_wait' function, which
    works for any stasis_topic.
    
    (closes issue ASTERISK-22002)
    Review: https://reviewboard.asterisk.org/r/2672/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@395954 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    e1b959cc
    History
    Split caching out from the stasis_caching_topic.
    David M. Lee authored
    In working with res_stasis, I discovered a significant limitation to
    the current structure of stasis_caching_topics: you cannot subscribe
    to cache updates for a single channel/bridge/endpoint/etc.
    
    To address this, this patch splits the cache away from the
    stasis_caching_topic, making it a first class object. The stasis_cache
    object is shared amongst individual stasis_caching_topics that are
    created per channel/endpoint/etc. These are still forwarded to global
    whatever_all_cached topics, so their use from most of the code does
    not change.
    
    In making these changes, I noticed that we frequently used a similar
    pattern for bridges, endpoints and channels:
    
         single_topic  ---------------->  all_topic
               ^
               |
         single_topic_cached  ----+---->  all_topic_cached
                                  |
                                  +---->  cache
    
    This pattern was extracted as the 'Stasis Caching Pattern', defined in
    stasis_caching_pattern.h. This avoids a lot of duplicate code between
    the different domain objects.
    
    Since the cache is now disassociated from its upstream caching topics,
    this also necessitated a change to how the 'guaranteed' flag worked
    for retrieving from a cache. The code for handling the caching
    guarantee was extracted into a 'stasis_topic_wait' function, which
    works for any stasis_topic.
    
    (closes issue ASTERISK-22002)
    Review: https://reviewboard.asterisk.org/r/2672/
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@395954 65c4cc65-6c06-0410-ace0-fbb531ad65f3