Skip to content
Snippets Groups Projects
  • Naveen Albert's avatar
    3c4b7cef
    app_read: Fix custom terminator functionality regression · 3c4b7cef
    Naveen Albert authored
    Currently, when the t option is specified with no arguments,
    the # character is still treated as a terminator, even though
    no character should be treated as a terminator.
    
    This is because a previous regression fix was modified to
    remove the use of NULL as a default altogether. However,
    NULL and an empty string actually refer to different
    arrangements and should be treated differently. NULL is the
    default terminator (#), while an empty string removes the
    terminator altogether. This is the behavior being used by
    the rest of the core.
    
    Additionally, since S_OR catches empty strings as well as
    NULL (not intended), this is changed to a ternary operator
    instead, which fixes the behavior.
    
    ASTERISK-29705 #close
    
    Change-Id: I9b6b72196dd04f5b1e0ab5aa1b0adf627725e086
    3c4b7cef
    History
    app_read: Fix custom terminator functionality regression
    Naveen Albert authored
    Currently, when the t option is specified with no arguments,
    the # character is still treated as a terminator, even though
    no character should be treated as a terminator.
    
    This is because a previous regression fix was modified to
    remove the use of NULL as a default altogether. However,
    NULL and an empty string actually refer to different
    arrangements and should be treated differently. NULL is the
    default terminator (#), while an empty string removes the
    terminator altogether. This is the behavior being used by
    the rest of the core.
    
    Additionally, since S_OR catches empty strings as well as
    NULL (not intended), this is changed to a ternary operator
    instead, which fixes the behavior.
    
    ASTERISK-29705 #close
    
    Change-Id: I9b6b72196dd04f5b1e0ab5aa1b0adf627725e086
app_read.c 8.81 KiB