Skip to content
Snippets Groups Projects
  • Matthew Jordan's avatar
    9cc1a8e8
    stasis: Reduce creation of channel snapshots to improve performance · 9cc1a8e8
    Matthew Jordan authored
    During some performance testing of Asterisk with AGI, ARI, and lots of Local
    channels, we noticed that there's quite a hit in performance during channel
    creation and releasing to the dialplan (ARI continue). After investigating
    the performance spike that occurs during channel creation, we discovered
    that we create a lot of channel snapshots that are technically unnecessary.
    This includes creating snapshots during:
     * AGI execution
     * Returning objects for ARI commands
     * During some Local channel operations
     * During some dialling operations
     * During variable setting
     * During some bridging operations
    And more.
    
    This patch does the following:
     - It removes a number of fields from channel snapshots. These fields were
       rarely used, were expensive to have on the snapshot, and hurt performance.
       This included formats, translation paths, Log Call ID, callgroup, pickup
       group, and all channel variables. As a result, AMI Status,
       "core show channel", "core show channelvar", and "pjsip show channel" were
       modified to either hit the live channel or not show certain pieces of data.
       While this is unfortunate, the performance gain from this patch is worth
       the loss in behaviour.
     - It adds a mechanism to publish a cached snapshot + blob. A large number of
       publications were changed to use this, including:
       - During Dial begin
       - During Variable assignment (if no AMI variables are emitted - if AMI
         variables are set, we have to make snapshots when a variable is changed)
       - During channel pickup
       - When a channel is put on hold/unhold
       - When a DTMF digit is begun/ended
       - When creating a bridge snapshot
       - When an AOC event is raised
       - During Local channel optimization/Local bridging
       - When endpoint snapshots are generated
       - All AGI events
       - All ARI responses that return a channel
       - Events in the AgentPool, MeetMe, and some in Queue
     - Additionally, some extraneous channel snapshots were being made that were
       unnecessary. These were removed.
     - The result of ast_hashtab_hash_string is now cached in stasis_cache. This
       reduces a large number of calls to ast_hashtab_hash_string, which reduced
       the amount of time spent in this function in gprof by around 50%.
    
    #ASTERISK-23811 #close
    Reported by: Matt Jordan
    
    Review: https://reviewboard.asterisk.org/r/3568/
    ........
    
    Merged revisions 416211 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@416216 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    9cc1a8e8
    History
    stasis: Reduce creation of channel snapshots to improve performance
    Matthew Jordan authored
    During some performance testing of Asterisk with AGI, ARI, and lots of Local
    channels, we noticed that there's quite a hit in performance during channel
    creation and releasing to the dialplan (ARI continue). After investigating
    the performance spike that occurs during channel creation, we discovered
    that we create a lot of channel snapshots that are technically unnecessary.
    This includes creating snapshots during:
     * AGI execution
     * Returning objects for ARI commands
     * During some Local channel operations
     * During some dialling operations
     * During variable setting
     * During some bridging operations
    And more.
    
    This patch does the following:
     - It removes a number of fields from channel snapshots. These fields were
       rarely used, were expensive to have on the snapshot, and hurt performance.
       This included formats, translation paths, Log Call ID, callgroup, pickup
       group, and all channel variables. As a result, AMI Status,
       "core show channel", "core show channelvar", and "pjsip show channel" were
       modified to either hit the live channel or not show certain pieces of data.
       While this is unfortunate, the performance gain from this patch is worth
       the loss in behaviour.
     - It adds a mechanism to publish a cached snapshot + blob. A large number of
       publications were changed to use this, including:
       - During Dial begin
       - During Variable assignment (if no AMI variables are emitted - if AMI
         variables are set, we have to make snapshots when a variable is changed)
       - During channel pickup
       - When a channel is put on hold/unhold
       - When a DTMF digit is begun/ended
       - When creating a bridge snapshot
       - When an AOC event is raised
       - During Local channel optimization/Local bridging
       - When endpoint snapshots are generated
       - All AGI events
       - All ARI responses that return a channel
       - Events in the AgentPool, MeetMe, and some in Queue
     - Additionally, some extraneous channel snapshots were being made that were
       unnecessary. These were removed.
     - The result of ast_hashtab_hash_string is now cached in stasis_cache. This
       reduces a large number of calls to ast_hashtab_hash_string, which reduced
       the amount of time spent in this function in gprof by around 50%.
    
    #ASTERISK-23811 #close
    Reported by: Matt Jordan
    
    Review: https://reviewboard.asterisk.org/r/3568/
    ........
    
    Merged revisions 416211 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@416216 65c4cc65-6c06-0410-ace0-fbb531ad65f3