Skip to content
Snippets Groups Projects
  • Kevin Harwell's avatar
    286cf80b
    rtp_engine: rtcp_report_to_json can overflow the ssrc integer value · 286cf80b
    Kevin Harwell authored
    When writing an RTCP report to json the code attempts to pack the "ssrc" and
    "source_ssrc" unsigned integer values as a signed int value type. This of course
    means if the ssrc's unsigned value is greater than that which can fit into a
    signed integer value it gets converted to a negative number. Subsequently, the
    negative value goes out in the json report.
    
    This patch now packs the value as a json_int_t, which is the widest integer type
    available on a given system. This should make it so the value no longer
    overflows.
    
    Note, this was caught by two failing tests hep/rtcp-receiver/ and
    hep/rtcp-sender.
    
    Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
    286cf80b
    History
    rtp_engine: rtcp_report_to_json can overflow the ssrc integer value
    Kevin Harwell authored
    When writing an RTCP report to json the code attempts to pack the "ssrc" and
    "source_ssrc" unsigned integer values as a signed int value type. This of course
    means if the ssrc's unsigned value is greater than that which can fit into a
    signed integer value it gets converted to a negative number. Subsequently, the
    negative value goes out in the json report.
    
    This patch now packs the value as a json_int_t, which is the widest integer type
    available on a given system. This should make it so the value no longer
    overflows.
    
    Note, this was caught by two failing tests hep/rtcp-receiver/ and
    hep/rtcp-sender.
    
    Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0