Skip to content
Snippets Groups Projects
  • Ivan Poddubnyi's avatar
    2770cc58
    res_pjsip_diversion: Fix adding more than one histinfo to Supported · 2770cc58
    Ivan Poddubnyi authored
    New responses sent within a PJSIP sessions are based on those that were
    sent before. Therefore, adding/modifying a header once causes it to be
    sent on all responses that follow.
    
    Sending 181 Call Is Being Forwarded many times first adds "histinfo"
    duplicated more and more, and eventually overflows past the array
    boundary.
    
    This commit adds a check preventing adding "histinfo" more than once,
    and skipping it if there is no more space in the header.
    
    Similar overflow situations can also occur in res_pjsip_path and
    res_pjsip_outbound_registration so those were also modified to
    check the bounds and suppress duplicate Supported values.
    
    ASTERISK-29227
    Reported by: Ivan Poddubny
    
    Change-Id: Id43704a1f1a0293e35cc7f844026f0b04f2ac322
    2770cc58
    History
    res_pjsip_diversion: Fix adding more than one histinfo to Supported
    Ivan Poddubnyi authored
    New responses sent within a PJSIP sessions are based on those that were
    sent before. Therefore, adding/modifying a header once causes it to be
    sent on all responses that follow.
    
    Sending 181 Call Is Being Forwarded many times first adds "histinfo"
    duplicated more and more, and eventually overflows past the array
    boundary.
    
    This commit adds a check preventing adding "histinfo" more than once,
    and skipping it if there is no more space in the header.
    
    Similar overflow situations can also occur in res_pjsip_path and
    res_pjsip_outbound_registration so those were also modified to
    check the bounds and suppress duplicate Supported values.
    
    ASTERISK-29227
    Reported by: Ivan Poddubny
    
    Change-Id: Id43704a1f1a0293e35cc7f844026f0b04f2ac322