Skip to content
Snippets Groups Projects
  • Richard Mudgett's avatar
    828f339a
    verbosity: Fix performance of console verbose messages. · 828f339a
    Richard Mudgett authored
    The per console verbose level feature as previously implemented caused a
    large performance penalty.  The fix required some minor incompatibilities
    if the new rasterisk is used to connect to an earlier version.  If the new
    rasterisk connects to an older Asterisk version then the root console
    verbose level is always affected by the "core set verbose" command of the
    remote console even though it may appear to only affect the current
    console.  If an older version of rasterisk connects to the new version
    then the "core set verbose" command will have no effect.
    
    * Fixed the verbose performance by not generating a verbose message if
    nothing is going to use it and then filtered any generated verbose
    messages before actually sending them to the remote consoles.
    
    * Split the "core set debug" and "core set verbose" CLI commands to remove
    the per module verbose support that cannot work with the per console
    verbose level.
    
    * Added a silent option to the "core set verbose" command.
    
    * Fixed "core set debug off" tab completion.
    
    * Made "core show settings" list the current console verbosity in addition
    to the root console verbosity.
    
    * Changed the default verbose level of the 'verbose' setting in the
    logger.conf [logfiles] section.  The default is now to once again follow
    the current root console level.  As a result, using the AMI Command action
    with "core set verbose" could again set the root console verbose level and
    affect the verbose level logged.
    
    (closes issue AST-1252)
    Reported by: Guenther Kelleter
    
    Review: https://reviewboard.asterisk.org/r/3114/
    ........
    
    Merged revisions 405431 from http://svn.asterisk.org/svn/asterisk/branches/11
    ........
    
    Merged revisions 405432 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@405436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
    828f339a
    History
    verbosity: Fix performance of console verbose messages.
    Richard Mudgett authored
    The per console verbose level feature as previously implemented caused a
    large performance penalty.  The fix required some minor incompatibilities
    if the new rasterisk is used to connect to an earlier version.  If the new
    rasterisk connects to an older Asterisk version then the root console
    verbose level is always affected by the "core set verbose" command of the
    remote console even though it may appear to only affect the current
    console.  If an older version of rasterisk connects to the new version
    then the "core set verbose" command will have no effect.
    
    * Fixed the verbose performance by not generating a verbose message if
    nothing is going to use it and then filtered any generated verbose
    messages before actually sending them to the remote consoles.
    
    * Split the "core set debug" and "core set verbose" CLI commands to remove
    the per module verbose support that cannot work with the per console
    verbose level.
    
    * Added a silent option to the "core set verbose" command.
    
    * Fixed "core set debug off" tab completion.
    
    * Made "core show settings" list the current console verbosity in addition
    to the root console verbosity.
    
    * Changed the default verbose level of the 'verbose' setting in the
    logger.conf [logfiles] section.  The default is now to once again follow
    the current root console level.  As a result, using the AMI Command action
    with "core set verbose" could again set the root console verbose level and
    affect the verbose level logged.
    
    (closes issue AST-1252)
    Reported by: Guenther Kelleter
    
    Review: https://reviewboard.asterisk.org/r/3114/
    ........
    
    Merged revisions 405431 from http://svn.asterisk.org/svn/asterisk/branches/11
    ........
    
    Merged revisions 405432 from http://svn.asterisk.org/svn/asterisk/branches/12
    
    
    git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@405436 65c4cc65-6c06-0410-ace0-fbb531ad65f3