CDRs: Synchronize dialplan applications that manipulate CDRs with the engine
In https://reviewboard.asterisk.org/r/3057/, applications and functions that manipulate CDRs were made to interact over Stasis. This was done to synchronize manipulations of CDRs from the dialplan with the updates the engine itself receives over the message bus. This change rested on a faulty premise: that messages published to the CDR topic or to a topic that forwards to the CDR topic are synchronized with the messages handled by the CDR topic subscription in the CDR engine. This is not the case. There is no ordering guaranteed for two messages published to the same topic; ordering is only guaranteed if a message is published to the same subscriber. Stasis was modified in r405311 to allow a publisher to synchronize on the subscriber. This patch uses that API to synchronize the CDR publishers with the CDR engine message router, which maintains the overall topic subscription. (closes issue ASTERISK-22884) Reported by: Matt Jordan Review: https://reviewboard.asterisk.org/r/3099/ ........ Merged revisions 405312 from http://svn.asterisk.org/svn/asterisk/branches/12 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@405314 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Showing
- apps/app_cdr.c 21 additions, 11 deletionsapps/app_cdr.c
- apps/app_forkcdr.c 27 additions, 15 deletionsapps/app_forkcdr.c
- funcs/func_cdr.c 51 additions, 39 deletionsfuncs/func_cdr.c
- include/asterisk/cdr.h 14 additions, 0 deletionsinclude/asterisk/cdr.h
- main/cdr.c 36 additions, 23 deletionsmain/cdr.c
Loading
Please register or sign in to comment