Skip to content
Snippets Groups Projects
Commit 51859252 authored by Sebastien Duthil's avatar Sebastien Duthil Committed by Sébastien Duthil
Browse files

main/stun.c: fix crash upon STUN request timeout

Some ast_stun_request users do not provide a destination address when
sending to a connection-mode socket.

ASTERISK-29691

Change-Id: Idd9114c3380216ba48abfc3c68619e79ad37defc
parent 9fcd50a8
No related branches found
No related tags found
3 merge requests!138Merge branch asterisk-20.3.0 into devel properly,!123Merge asterisk '20.3.0' into devel,!118Draft: manager: AOC-S support for AOCMessage
......@@ -239,17 +239,24 @@ static void append_attr_address(struct stun_attr **attr, int attrval, struct soc
static void handle_stun_timeout(int retry, struct sockaddr_in *dst)
{
char *stun_destination = "";
if (dst) {
ast_asprintf(&stun_destination, "to '%s' ", ast_inet_ntoa(dst->sin_addr));
}
if (retry < STUN_MAX_RETRIES) {
ast_log(LOG_NOTICE,
"Attempt %d to send STUN request to '%s' timed out.",
"Attempt %d to send STUN request %stimed out.\n",
retry,
ast_inet_ntoa(dst->sin_addr));
stun_destination);
} else {
ast_log(LOG_WARNING,
"Attempt %d to send STUN request to '%s' timed out."
"Attempt %d to send STUN request %stimed out. "
"Check that the server address is correct and reachable.\n",
retry,
ast_inet_ntoa(dst->sin_addr));
stun_destination);
}
if (dst) {
ast_free(stun_destination);
}
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment