Skip to content
Snippets Groups Projects
Commit 61c8f9b2 authored by Sean Bright's avatar Sean Bright Committed by Asterisk Development Team
Browse files

contrib: rc.archlinux.asterisk uses invalid redirect.

`rc.archlinux.asterisk`, which explicitly requests bash in its
shebang, uses the following command syntax:

  ${DAEMON} -rx "core stop now" > /dev/null 2&>1

The intent of which is to execute:

  ${DAEMON} -rx "core stop now"

While sending both stdout and stderr to `/dev/null`. Unfortunately,
because the `&` is in the wrong place, bash is interpreting the `2` as
just an additional argument to the `$DAEMON` command and not as a file
descriptor and proceeds to use the bashism `&>` to send stderr and
stdout to a file named `1`.

So we clean it up and just use bash's shortcut syntax.

Issue raised and a fix suggested (but not used) by peutch on GitHub¹.

ASTERISK-30449 #close

1. https://github.com/asterisk/asterisk/pull/31

Change-Id: Ie279bf4efb4d95cbf507313483d316e977303d19
(cherry picked from commit 46bdd5e3be425279052205e0ad2e688fae87db2a)
parent 1d64cb99
No related branches found
No related tags found
3 merge requests!138Merge branch asterisk-20.3.0 into devel properly,!123Merge asterisk '20.3.0' into devel,!118Draft: manager: AOC-S support for AOCMessage
......@@ -45,7 +45,7 @@ case "$1" in
stop)
if [ -r ${ASTVARRUNDIR}/asterisk.pid ]; then
stat_busy "Stopping Asterisk..."
${DAEMON} -rx "core stop now" > /dev/null 2&>1
${DAEMON} -rx "core stop now" &>/dev/null
if [ $? -gt 0 ]; then
stat_fail
else
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment