clang compiler warnings: Fix autological comparisons
This fixes autological comparison warnings in the following: * chan_skinny: letohl may return a signed or unsigned value, depending on the macro chosen * func_curl: Provide a specific cast to CURLoption to prevent mismatch * cel: Fix enum comparisons where the enum can never be negative * enum: Fix comparison of return result of dn_expand, which returns a signed int value * event: Fix enum comparisons where the enum can never be negative * indications: tone_data.freq1 and freq2 are unsigned, and hence can never be negative * presencestate: Use the actual enum value for INVALID state * security_events: Fix enum comparisons where the enum can never be negative * udptl: Don't bother to check if the return value from encode_length is less than 0, as it returns an unsigned int * translate: Since the parameters are unsigned int, don't bother checking to see if they are negative. The cast to unsigned int would already blow past the matrix bounds. * res_pjsip_exten_state: Use a temporary value to cache the return of ast_hint_presence_state * res_stasis_playback: Fix enum comparisons where the enum can never be negative * res_stasis_recording: Add an enum value for the case where the recording operation is in error; fix enum comparisons * resource_bridges: Use enum value as opposed to -1 * resource_channels: Use enum value as opposed to -1 Review: https://reviewboard.asterisk.org/r/4533 ASTERISK-24917 Reported by: dkdegroot patches: rb4533.patch submitted by dkdegroot (License 6600) ........ Merged revisions 434469 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 434470 from http://svn.asterisk.org/svn/asterisk/branches/13 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@434471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
Showing
- channels/chan_skinny.c 5 additions, 1 deletionchannels/chan_skinny.c
- channels/pjsip/dialplan_functions.c 2 additions, 2 deletionschannels/pjsip/dialplan_functions.c
- funcs/func_curl.c 1 addition, 1 deletionfuncs/func_curl.c
- include/asterisk/app.h 2 additions, 0 deletionsinclude/asterisk/app.h
- include/asterisk/cel.h 3 additions, 1 deletioninclude/asterisk/cel.h
- include/asterisk/logger.h 1 addition, 1 deletioninclude/asterisk/logger.h
- include/asterisk/utils.h 1 addition, 1 deletioninclude/asterisk/utils.h
- main/app.c 3 additions, 0 deletionsmain/app.c
- main/cel.c 6 additions, 10 deletionsmain/cel.c
- main/enum.c 1 addition, 1 deletionmain/enum.c
- main/event.c 1 addition, 1 deletionmain/event.c
- main/indications.c 2 additions, 3 deletionsmain/indications.c
- main/presencestate.c 1 addition, 1 deletionmain/presencestate.c
- main/security_events.c 2 additions, 2 deletionsmain/security_events.c
- main/udptl.c 3 additions, 6 deletionsmain/udptl.c
- res/ari/resource_bridges.c 1 addition, 1 deletionres/ari/resource_bridges.c
- res/ari/resource_channels.c 1 addition, 1 deletionres/ari/resource_channels.c
- res/res_pjsip_exten_state.c 4 additions, 2 deletionsres/res_pjsip_exten_state.c
- res/res_stasis_playback.c 2 additions, 2 deletionsres/res_stasis_playback.c
- res/res_stasis_recording.c 3 additions, 3 deletionsres/res_stasis_recording.c
Loading
Please register or sign in to comment