Skip to content
Snippets Groups Projects
  1. May 15, 2020
    • Joshua C. Colp's avatar
      ari: Allow variables to be set on channel create. · 15cbff9d
      Joshua C. Colp authored
      This change adds the same variable functionality that
      is available for originating a channel to the create
      call. Now when creating a channel you can specify
      dialplan variables to set instead of having to do another
      API call.
      
      ASTERISK-28896
      
      Change-Id: If13997ba818136d7c070585504fc4164378aa992
      15cbff9d
  2. May 13, 2020
    • Roger James's avatar
      pjsip_resolver.c: Ensure AAAA dns requests are made. · c8dec423
      Roger James authored
      1. Modify sip_resolve and sip_resolve_callback to request AAAA lookups
         when an IPV6 transport type has been requested.
      
      2. Rename all occurrences of pjsip_transport_get_type_name to
         pjsip_transport_get_type_desc. This ensures that the log/debug info
         shows whether the transport is IPv6 or IPv4.
      
      3. Do not add the constant PJSIP_TRANSPORT_IPV6 to existing transport
         types. This results in invalid values. Use a bitwise or instead.
      
      ASTERISK-26780
      Patches:
          pjsip_resolver.c uploaded by Peter Sokolov (License #7070)
      
      Change-Id: I8b1e298f8efa682d0a7644113258fe76d9889c58
      c8dec423
    • Ben Ford's avatar
      res_stir_shaken: Added dialplan function and API call. · e29df34d
      Ben Ford authored
      Adds the "STIR_SHAKEN" dialplan function and an API call to add a
      STIR_SHAKEN verification result to a channel. This information will be
      held in a datastore on the channel that can later be queried through the
      "STIR_SHAKEN" dialplan funtion to get information on STIR_SHAKEN results
      including identity, attestation, and verify_result. Here are some
      examples:
      
      STIR_SHAKEN(count)
      STIR_SHAKEN(0, identity)
      STIR_SHAKEN(1, attestation)
      STIR_SHAKEN(2, verify_result)
      
      Getting the count can be used to iterate through the results and pull
      information by specifying the index and the field you want to retrieve.
      
      Change-Id: Ice6d52a3a7d6e4607c9c35b28a1f7c25f5284a82
      e29df34d
  3. May 11, 2020
  4. May 08, 2020
    • Pirmin Walthert's avatar
      app.c: make sure that no non-async-signal-safe syscalls are used after · 6b2d9451
      Pirmin Walthert authored
      fork before exec
      
      Posix does only allow async-signal-safe syscalls after fork before exec.
      As asterisk ignores this, functions like TrySystem or System sometimes
      end up in a deadlocked child process. The patch prevents the use of
      non-async-signal-safe syscalls.
      
      ASTERISK-28776
      
      Change-Id: Idc76365c0592ee3f3b3bd72a4f48f7a098978e8e
      6b2d9451
  5. May 06, 2020
    • George Joseph's avatar
      streams: Fix one memory leak and one formats ref issue · 7fbfbe7d
      George Joseph authored
      ast_stream_topology_create_from_format_cap() was setting the
      stream->formats directly but not freeing the default formats.  This
      causes a memory leak.
      
      * ast_stream_topology_create_from_format_cap() now calls
        ast_stream_set_formats() which properly cleans up the existing
        stream formats.
      
      When cloning a stream, the source stream's format caps _pointer_ is
      copied to the new stream and it's reference count bumped.  If
      either stream is set to "removed", this will cause _both_ streams
      to have their format caps cleared.
      
      * ast_stream_clone() now creates a new format caps object and copies
        the formats from the source stream instead of just copying the
        pointer.
      
      ASTERISK-28870
      
      Change-Id: If697d81c3658eb7baeea6dab413b13423938fb53
      7fbfbe7d
    • Nathan Bruning's avatar
      app_queue: track masquerades in app_queue to avoid leaked stasis subscriptions · f217fcdc
      Nathan Bruning authored
      Add a new "masquarade" channel event, and use it in app_queue to track unique id's.
      
      Testcase is submitted as https://gerrit.asterisk.org/c/testsuite/+/14210
      
      ASTERISK-28829 #close
      ASTERISK-25844 #close
      
      Change-Id: Ifc5f9f9fd70903f3c6e49738d3bc632b085d2df6
      f217fcdc
  6. May 05, 2020
  7. May 01, 2020
    • Joshua C. Colp's avatar
      res_stir_shaken: Use ast_asprintf for creating file path. · 1cfd30bd
      Joshua C. Colp authored
      Change-Id: Ice5d92ecea2f1101c80487484f48ef98be2f1824
      1cfd30bd
    • Ben Ford's avatar
      res_stir_shaken: Implemented signature verification. · 9acf840f
      Ben Ford authored
      There are a lot of moving parts in this patch, but the focus of it is on
      the verification of the signature using a public key located at the
      public key URL provided in the JSON payload. First, we check the
      database to see if we have already downloaded the key. If so, check to
      see if it has expired. If it has, redownload from the URL. If we don't
      have an entry in the database, just go ahead and download the public
      key. The expiration is tested each time we download the file. After
      that, read the public key from the file and use it to verify the
      signature. All sanity checking is done when the payload is first
      received, so the verification is complete once this point is reached.
      
      The XML has also been added since a new config option was added to
      general (curl_timeout). The maximum amount of time to wait for a
      download can be configured through this option, with a low value by
      default.
      
      Change-Id: I3ba4c63880493bf8c7d17a9cfca1af0e934d1a1c
      9acf840f
  8. Apr 30, 2020
  9. Apr 29, 2020
    • Joshua C. Colp's avatar
      pjsip: Increase maximum ICE candidate count. · 3078a00a
      Joshua C. Colp authored
      In practice it has been seen that some users come
      close to our maximum ICE candidate count of 32.
      In case people have gone over this increases the
      count to 64, giving ample room.
      
      ASTERISK-28859
      
      Change-Id: I35cd68948ec0ada86c14eb53092cdaf8b62996cf
      3078a00a
    • Alexander Traud's avatar
      core_local: Local calls are always secure. · 29070b61
      Alexander Traud authored
      In a Dialplan, the channel drivers 'chan_sip' and 'chan_iax2' support
      the channel items 'secure_bridge_media' and 'secure_bridge_signaling'.
      That way, a channel can be forced to use encryption even if not
      specified in its configuration.
      
      However, when the Local Proxy kicks in, for example, in case of a
      forwarding (SIP status 302), Local Proxy stated it does not know those
      items. Consequently, such a call could not be proxied how clever your
      Dialplan was. Because local calls within Asterisk are always secure,
      Local Proxy accepts such a request now.
      
      ASTERISK-22920
      
      Change-Id: I4c143bb70f686790953cc04c5a4b810bbb03636c
      29070b61
  10. Apr 28, 2020
    • Guido Falsi's avatar
      res_rtp_asterisk: Protect access to nochecksums with #ifdef · e4366308
      Guido Falsi authored
      Recently code accessing nochecksums variable has been added without including #ifdef SO_NO_CHECK protection, while the variable is created only when such constant is defined.
      
      ASTERISK-28852 #close
      
      Change-Id: I381718893b80599ab8635f2b594a10c1000d595e
      e4366308
    • Guido Falsi's avatar
      core/dns: Add system include required on FreeBSD · 97494d89
      Guido Falsi authored
      While testing the latest RC on FreeBSD I noticed this new file fails to build. On FreeBSD inlcuding resolv.h requires sockaddr_in to be defined, and it's defined in netinet/in.h. So I added this include.
      
      ASTERISK-28853 #close
      
      Change-Id: I6997daf3956e6eb70ab6cb358628d162fad80079
      97494d89
  11. Apr 27, 2020
    • Peter Turczak's avatar
      chan_mobile: Add smoother to make SIP/RTP endpoints happy. · 3303defd
      Peter Turczak authored
      In contrast to RFC 3551, section 4.2, several SIP/RTP clients misbehave
      severly (up to crashing). This patch adds another smoother for the audio
      received via bt. Therefore the audio frames sent to the core will be
      CHANNEL_FRAME_SIZE.
      
      ASTERISK-28832 #close
      
      Change-Id: Ic5f9e2f35868ae59cc9356afbd1388b779a1267f
      3303defd
  12. Apr 24, 2020
    • Alexander Traud's avatar
      app_fax: SpanDSP headers do not use ast_malloc; ignore that. · 26b8c999
      Alexander Traud authored
      Since Asterisk 14, app_fax did not compile at all because Asterisk
      requires that not malloc but ast_malloc is used everywhere. However,
      the system headers of SpanDSP use malloc. Because we cannot (and do
      not need to) change system headers, let us ignore this.
      
      ASTERISK-28848
      
      Change-Id: I31f7a6b92a07032c5cef1c16b8901b107fe35546
      26b8c999
  13. Apr 23, 2020
    • Joshua C. Colp's avatar
      stream: Enforce formats immutability and ensure formats exist. · 1c5e6858
      Joshua C. Colp authored
      Some places in Asterisk did not treat the formats on a stream
      as immutable when they are.
      
      The ast_stream_get_formats function is now const to enforce this
      and parts of Asterisk have been updated to take this into account.
      Some violations of this were also fixed along the way.
      
      An additional minor tweak is that streams are now allocated with
      an empty format capabilities structure removing the need in various
      places to check that one is present on the stream.
      
      ASTERISK-28846
      
      Change-Id: I32f29715330db4ff48edd6f1f359090458a9bfbe
      1c5e6858
  14. Apr 22, 2020
    • sungtae kim's avatar
      res_ari_channels: Fixed endpoint 80 characters limit · 9ad3d282
      sungtae kim authored
      Fixed it to copy the entire string from the requested endpoint body except tech-prefix.
      
      ASTERISK-28847
      
      Change-Id: I91b5f6708a1200363f3267b847dd6a0915222c25
      9ad3d282
    • Joshua C. Colp's avatar
      fax: Fix crashes in PJSIP re-negotiation scenarios. · e56f4de7
      Joshua C. Colp authored
      This change fixes a few re-negotiation issues
      uncovered with fax.
      
      1. The fax support uses its own mechanism for
      re-negotiation by conveying T.38 information in
      its own frames. The new support for re-negotiating
      when adding/removing/changing streams was also
      being triggered for this causing multiple re-INVITEs.
      The new support will no longer trigger when
      transitioning between fax.
      
      2. In off-nominal re-negotiation cases it was
      possible for some state information to be left
      over and used by the next re-negotiation. This
      is now cleared.
      
      ASTERISK-28811
      ASTERISK-28839
      
      Change-Id: I8ed5924b53be9fe06a385c58817e5584b0f25cc2
      e56f4de7
  15. Apr 21, 2020
  16. Apr 20, 2020
  17. Apr 17, 2020
  18. Apr 16, 2020
  19. Apr 15, 2020
Loading