Skip to content
Snippets Groups Projects
  1. Oct 26, 2022
    • Naveen Albert's avatar
      chan_dahdi: Fix unavailable channels returning busy. · 180ca325
      Naveen Albert authored
      This fixes dahdi_request to properly set the cause
      code to CONGESTION instead of BUSY if no channels
      were actually available.
      
      Currently, the cause is erroneously set to busy
      if the channel itself is found, regardless of its
      current state. However, if the channel is not available
      (e.g. T1 down, card not operable, etc.), then the
      channel itself may not be in a functional state,
      in which case CHANUNAVAIL is the correct cause to use.
      
      This adds a simple check to ensure that busy tone
      is only returned if a channel is encountered that
      has an owner, since that is the only possible way
      that a channel could actually be busy.
      
      ASTERISK-30274 #close
      
      Change-Id: Iad5870223c081240c925b19df8d6af136953b994
      180ca325
    • Naveen Albert's avatar
      res_pjsip_pubsub: Prevent removing subscriptions. · 9258d821
      Naveen Albert authored
      pjproject does not provide any mechanism of removing
      event packages, which means that once a subscription
      handler is registered, it is effectively permanent.
      
      pjproject will assert if the same event package is
      ever registered again, so currently unloading and
      loading any Asterisk modules that use subscriptions
      will cause a crash that is beyond our control.
      
      For that reason, we now prevent users from being
      able to unload these modules, to prevent them
      from ever being loaded twice.
      
      ASTERISK-30264 #close
      
      Change-Id: I7fdcb1a5e44d38b7ba10c44259fe98f0ae9bc12c
      9258d821
    • Naveen Albert's avatar
      say: Don't prepend ampersand erroneously. · 407216a0
      Naveen Albert authored
      Some logic in say.c for determining if we need
      to also add an ampersand for file seperation was faulty,
      as non-successful files would increment the count, causing
      a leading ampersand to be added improperly.
      
      This is fixed, and a unit test that captures this regression
      is also added.
      
      ASTERISK-30248 #close
      
      Change-Id: I02c1d3a11d82fe4ea8b462070cbd1effb5834d2b
      407216a0
  2. Oct 14, 2022
  3. Oct 11, 2022
    • Mike Bradeen's avatar
      audiohook: add directional awareness · 907d7e7d
      Mike Bradeen authored
      Add enum to allow setting optional direction. If set to only one
      direction, only feed matching-direction frames to the associated
      slin factory.
      
      This prevents mangling the transcoder on non-mixed frames when the
      READ and WRITE frames would have otherwise required it.  Also
      removes the need to mute or discard the un-wanted frames as they
      are no longer added in the first place.
      
      res_stasis_snoop is changed to use this addition to set direction
      on audiohook based on spy direction.
      
      If no direction is set, the ast_audiohook_init will init this enum
      to BOTH which maintains existing functionality.
      
      ASTERISK-30252
      
      Change-Id: If8716bad334562a5d812be4eeb2a92e4f3be28eb
      907d7e7d
  4. Oct 10, 2022
    • Naveen Albert's avatar
      cdr: Allow bridging and dial state changes to be ignored. · b331caca
      Naveen Albert authored
      Allows bridging, parking, and dial messages to be globally
      ignored for all CDRs such that only a single CDR record
      is generated per channel.
      
      This is useful when CDRs should endure for the lifetime of
      an entire channel and bridging and dial updates in the
      dialplan should not result in multiple CDR records being
      created for the call. With the ignore bridging option,
      bridging changes have no impact on the channel's CDRs.
      With the ignore dial state option, multiple Dials and their
      outcomes have no impact on the channel's CDRs. The
      last disposition on the channel is preserved in the CDR,
      so the actual disposition of the call remains available.
      
      These two options can reduce the amount of "CDR hacks" that
      have hitherto been necessary to ensure that CDR was not
      "spoiled" by these messages if that was undesired, such as
      putting a dummy optimization-disabled local channel between
      the caller and the actual call and putting the CDR on the channel
      in the middle to ensure that CDR would persist for the entire
      call and properly record start, answer, and end times.
      Enabling these options is desirable when calls correspond
      to the entire lifetime of channels and the CDR should
      reflect that.
      
      Current default behavior remains unchanged.
      
      ASTERISK-30091 #close
      
      Change-Id: I393981af42732ec5ac3ff9266444abb453b7c832
      b331caca
    • Naveen Albert's avatar
      res_tonedetect: Add ringback support to TONE_DETECT. · e0e7f357
      Naveen Albert authored
      Adds support for detecting audible ringback tone
      to the TONE_DETECT function using the p option.
      
      ASTERISK-30254 #close
      
      Change-Id: Ie2329ff245248768367d26749c285fbe823f6414
      e0e7f357
    • Naveen Albert's avatar
      chan_dahdi: Resolve format truncation warning. · 98fc05f1
      Naveen Albert authored
      Fixes a format truncation warning in notify_message.
      
      ASTERISK-30256 #close
      
      Change-Id: I983a423c0214641ca4f8c9dfe0b19c47448fdee1
      98fc05f1
    • Philip Prindeville's avatar
      res_crypto: don't modify fname in try_load_key() · ef74ecac
      Philip Prindeville authored
      "fname" is passed in as a const char *, but strstr() mangles that
      into a char *, and we were attempting to modify the string in place.
      This is an unwanted (and undocumented) side-effect.
      
      ASTERISK-30213
      
      Change-Id: Ifa36d352aafeb7f9beec3f746332865c7d21e629
      ef74ecac
    • Philip Prindeville's avatar
      res_crypto: use ast_file_read_dirs() to iterate · 5e2485b5
      Philip Prindeville authored
      ASTERISK-30213
      
      Change-Id: I115f5f8942ffcfb23cd2559a55bac8a2eba081e0
      5e2485b5
    • George Joseph's avatar
      res_geolocation: Update wiki documentation · 2a500b32
      George Joseph authored
      Also added a note to the geolocation.conf.sample file
      and added a README to the res/res_geolocation/wiki
      directory.
      
      Change-Id: I89c3c5db8c0701b33127993622d5e4f904bddfbc
      2a500b32
  5. Sep 29, 2022
    • Maximilian Fridrich's avatar
      res_pjsip: Add mediasec capabilities. · 0d2e1401
      Maximilian Fridrich authored
      This patch adds support for mediasec SIP headers and SDP attributes.
      These are defined in RFC 3329, 3GPP TS 24.229 and
      draft-dawes-sipcore-mediasec-parameter. The new features are
      implemented so that a backbone for RFC 3329 is present to streamline
      future work on RFC 3329.
      
      With this patch, Asterisk can communicate with Deutsche Telekom trunks
      which require these fields.
      
      ASTERISK-30032
      
      Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2
      0d2e1401
  6. Sep 28, 2022
  7. Sep 27, 2022
    • Holger Hans Peter Freyther's avatar
      res_prometheus: Do not crash on invisible bridges · 62881c66
      Holger Hans Peter Freyther authored
      Avoid crashing by skipping invisible bridges and checking the
      snapshot for a null pointer. In effect this is how the bridges
      are enumerated in res/ari/resource_bridges.c already.
      
      ASTERISK-30239
      ASTERISK-30237
      
      Change-Id: I58ef9f44036feded5966b5fc70ae754f8182883d
      62881c66
  8. Sep 26, 2022
    • Naveen Albert's avatar
      res_pjsip_geolocation: Change some notices to debugs. · 8afb313a
      Naveen Albert authored
      If geolocation is not in use for an endpoint, the NOTICE
      log level is currently spammed with messages about this,
      even though nothing is wrong and these messages provide
      no real value. These log messages are therefore changed
      to debugs.
      
      ASTERISK-30241 #close
      
      Change-Id: I656b355d812f67cc0f0fdf09b00b0e1458598bb4
      8afb313a
    • Naveen Albert's avatar
      db: Fix incorrect DB tree count for AMI. · 7335b0cf
      Naveen Albert authored
      The DBGetTree AMI action's ListItem previously
      always reported 1, regardless of the count. This
      is corrected to report the actual count.
      
      ASTERISK-30245 #close
      patches:
        gettreecount.diff submitted by Birger Harzenetter (license 5870)
      
      Change-Id: I46d8992710f1b8524426b1255f57d1ef4a4934d4
      7335b0cf
    • Naveen Albert's avatar
      func_logic: Don't emit warning if both IF branches are empty. · 407167cc
      Naveen Albert authored
      The IF function currently emits warnings if both IF branches
      are empty. However, there is no actual necessity that either
      branch be non-empty as, unlike other conditional applications/
      functions, nothing is inherently done with IF, and both
      sides could legitimately be empty. The warning is thus turned
      into a debug message.
      
      ASTERISK-30243 #close
      
      Change-Id: I5250625dd720f95e1859b5dfb933905d7e7a730e
      407167cc
    • Naveen Albert's avatar
      features: Add no answer option to Bridge. · a5ec60e6
      Naveen Albert authored
      Adds the n "no answer" option to the Bridge application
      so that answer supervision can not automatically
      be provided when Bridge is executed.
      
      Additionally, a mechanism (dialplan variable)
      is added to prevent bridge targets (typically the
      target of a masquerade) from answering the channel
      when they enter the bridge.
      
      ASTERISK-30223 #close
      
      Change-Id: I76f73fcd8e403bcd18f2abb40c658f537ac1ba6d
      a5ec60e6
    • Naveen Albert's avatar
      app_bridgewait: Add option to not answer channel. · 1e29607b
      Naveen Albert authored
      Adds the n option to not answer the channel when calling
      BridgeWait, so the application can be used without
      forcing answer supervision.
      
      ASTERISK-30216 #close
      
      Change-Id: I6b85ef300b1f7b5170f8537e2b10889cc2e6605a
      1e29607b
    • Naveen Albert's avatar
      app_amd: Add option to play audio during AMD. · 8c791f9a
      Naveen Albert authored
      Adds an option that will play an audio file
      to the party while AMD is running on the
      channel, so the called party does not just
      hear silence.
      
      ASTERISK-30179 #close
      
      Change-Id: I4af306274552b61b3d9f0883c33f698abd4699b6
      8c791f9a
    • Philip Prindeville's avatar
      test: initialize capture structure before freeing · 3e7ce90f
      Philip Prindeville authored
      ASTERISK-30232 #close
      
      Change-Id: I2603e2cef8f93f6b0a6ef39f7eac744251bb3902
      3e7ce90f
    • Naveen Albert's avatar
      func_export: Add EXPORT function · 1ed45183
      Naveen Albert authored
      Adds the EXPORT function, which allows write
      access to variables and functions on other
      channels.
      
      ASTERISK-29432 #close
      
      Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
      1ed45183
  9. Sep 22, 2022
    • Maximilian Fridrich's avatar
      res_pjsip: Add 100rel option "peer_supported". · 5bbad0d2
      Maximilian Fridrich authored
      This patch adds a new option to the 100rel parameter for pjsip
      endpoints called "peer_supported". When an endpoint with this option
      receives an incoming request and the request indicated support for the
      100rel extension, then Asterisk will send 1xx responses reliably. If
      the request did not indicate 100rel support, Asterisk sends 1xx
      responses normally.
      
      ASTERISK-30158
      
      Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
      5bbad0d2
    • Naveen Albert's avatar
      func_scramble: Fix null pointer dereference. · 8aae0b9f
      Naveen Albert authored
      Fix segfault due to null pointer dereference
      inside the audiohook callback.
      
      ASTERISK-30220 #close
      
      Change-Id: Ideb80f606974366e89d619d908744230b5a5a259
      8aae0b9f
    • Jaco Kroon's avatar
      manager: be more aggressive about purging http sessions. · 278c5726
      Jaco Kroon authored
      
      If we find that n_max (currently hard wired to 1) sessions were purged,
      schedule the next purge for 1ms into the future rather than 5000ms (as
      per current).  This way we will purge up to 1000 sessions per second
      rather than 1 every 5 seconds.
      
      This mitigates a build-up of sessions should http sessions gets
      established faster than 1 per 5 seconds.
      
      Change-Id: I9820d39aa080109df44fe98c1325cafae48d54f5
      Signed-off-by: default avatarJaco Kroon <jaco@uls.co.za>
      278c5726
    • Naveen Albert's avatar
      func_strings: Add trim functions. · ab1dbfef
      Naveen Albert authored
      Adds TRIM, LTRIM, and RTRIM, which can be used
      for trimming leading and trailing whitespace
      from strings.
      
      ASTERISK-30222 #close
      
      Change-Id: I50fb0c40726d044a7a41939fa9026f3da4872554
      ab1dbfef
  10. Sep 19, 2022
  11. Sep 16, 2022
  12. Sep 15, 2022
  13. Sep 14, 2022
  14. Sep 13, 2022
    • George Joseph's avatar
      res_geolocation: Fix segfault when there's an empty element · 8cbea1c7
      George Joseph authored
      Fixed a segfault caused by var_list_from_loc_info() encountering
      an empty location info element.
      
      Fixed an issue in ast_strsep() where a value with only whitespace
      wasn't being preserved.
      
      Fixed an issue in ast_variable_list_from_quoted_string() where
      an empty value was considered a failure.
      
      ASTERISK-30215
      Reported by: Dan Cropp
      
      Change-Id: Ieca64e061a6d9298f0196c694b60d986ef82613a
      8cbea1c7
    • sungtae kim's avatar
      res_musiconhold: Add option to not play music on hold on unanswered channels · 80bc844f
      sungtae kim authored
      This change adds an option, answeredonly, that will prevent music on
      hold on channels that are not answered.
      
      ASTERISK-30135
      
      Change-Id: I1ab0defa43a29a26ae39f94c623596cf90fddc08
      80bc844f
    • Ben Ford's avatar
      res_pjsip: Add TEL URI support for basic calls. · 881a3f23
      Ben Ford authored
      This change allows TEL URI requests to come through for basic calls. The
      allowed requests are INVITE, ACK, BYE, and CANCEL. The From and To
      headers will now allow TEL URIs, as well as the request URI.
      
      Support is only for TEL URIs present in traffic from a remote party.
      Asterisk does not generate any TEL URIs on its own.
      
      ASTERISK-26894
      
      Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
      881a3f23
  15. Sep 12, 2022
Loading