Skip to content
Snippets Groups Projects
  1. Nov 22, 2017
  2. Nov 21, 2017
  3. Nov 20, 2017
  4. Nov 19, 2017
    • Corey Farrell's avatar
      Build: Fix OSX build issues. · b4f7f825
      Corey Farrell authored
      OSX does not support 'readlink -f' or 'sed -r'.  Replace readlink with
      the GNU make macro 'realpath'.  Replace sed with grep in one place, cut
      in the other.
      
      ASTERISK-27332
      
      Change-Id: I5d34ecca905384decb22ead45c913ae5e8aff748
      b4f7f825
    • Corey Farrell's avatar
      Build: Fix issues building without SSL. · 999e0c17
      Corey Farrell authored
      * Fix conditional in libasteriskssl.
      * Use variables produced by configure to link the SSL and uuid libraries
        into libasteriskpj.so instead of hard-coding them.
      
      ASTERISK-27431
      
      Change-Id: I3977931fd3ef8c4e4376349ccddb354eb839b58d
      999e0c17
    • Corey Farrell's avatar
      res_pjsip: Fix warning by deferring implicit type cast. · 53f42cc0
      Corey Farrell authored
      Mac doesn't like the comparison of -1 to an enum, so store the result of
      ast_sip_str_to_dtmf to an int so we can check for the negative return
      value.  ast_sip_str_to_dtmf returns an int so this is only delaying the
      implicit type cast.
      
      Change-Id: I0c262c1719ee951aae1f437d733a301cf5f8ad29
      53f42cc0
    • Corey Farrell's avatar
      tests: Fix warnings found on Mac. · 75cb4037
      Corey Farrell authored
      test_pbx used raise without explicitly including signal.h.  On Mac for
      some reason nothing else includes it.
      
      test_logger checked if an unsigned int was negative.  Switch the
      variable to 'int' so that error check can be effective.
      
      Change-Id: Ie1db5dd1818ac25cc2ae41b644f848b5865b1362
      75cb4037
    • Corey Farrell's avatar
      res_snmp: Declare RONLY if net-snmp headers do not. · 83a2c4d2
      Corey Farrell authored
      Some net-snmp builds do not provide the RONLY declare, only
      NETSNMP_OLDAPI_RONLY.  Map RONLY to NETSNMP_OLDAPI_RONLY to get around
      this error.
      
      Change-Id: Ida5c7ad9406515825485c4d3b4a34fd6ad0da577
      83a2c4d2
    • Corey Farrell's avatar
      res_fax: Remove checks for unsigned values being >= 0. · 5a899fc5
      Corey Farrell authored
      It's impossible for gwtimeout or fdtimeout to be less than 0 because
      they are unsigned int's.  Remove checks and unreachable branches.
      
      Change-Id: Ib2286960621e6ee245e40013c84986143302bc78
      5a899fc5
    • Corey Farrell's avatar
      iostream: Fix ast_iostream_printf declaration. · b4862e46
      Corey Farrell authored
      This adds the printf attribute and changes 'fmt' from 'const void *' to
      'const char *'.  This resolves a warning from some compiler for
      vsnprintf needing a literal string for format.
      
      Change-Id: I71c33a8262590042ee451e1146760c10bb22fb78
      b4862e46
    • Corey Farrell's avatar
      app_minivm: Fix possible uninitialized return value. · 2fab3aac
      Corey Farrell authored
      Declare 'res' initialized to -1 to deal with earlier error paths that
      could cause 'res' to be returned uninitialized.
      
      Change-Id: I8ac2a5755bf4174d89ef893e924c940f702b104e
      2fab3aac
  5. Nov 18, 2017
  6. Nov 17, 2017
    • Sean Bright's avatar
      res_pjsip: Use reasonable buffer lengths for endpoint identification · 1b6e4c11
      Sean Bright authored
      Domains themselves can be up to 255 characters long (per RFC 1035), so
      our current buffer sizes are wholly inadequate for many use cases.
      
      Change-Id: If3f30a68307f1365a1fe06bc4b854c62842c9292
      1b6e4c11
    • Joshua Colp's avatar
      4181b6f3
    • Joshua Colp's avatar
    • Corey Farrell's avatar
      acl: Fix allocation related issues. · c4f11911
      Corey Farrell authored
      Add checks for allocation errors, cleanup and report failure when they
      occur.
      
      * ast_duplicate_acl_list: Replace log warnings with errors, add missing
        line-feed.
      * ast_append_acl: Add missing line-feed to logger message.
      * ast_append_ha: Avoid ast_strdupa in loop by moving debug message to
        separate function.
      * ast_ha_join: Use two separate calls to ast_str_append to avoid using
        ast_strdupa in a loop.
      
      Change-Id: Ia19eaaeb0b139ff7ce7b971c7550e85c8b78ab76
      c4f11911
    • Jenkins2's avatar
      Merge "aoc: Fix memory management issues." · b2c49d6c
      Jenkins2 authored
      b2c49d6c
    • Joshua Colp's avatar
      bridge_basic: Ignore answer from transfer target when they've timed out. · 781a520b
      Joshua Colp authored
      This is a fun one.
      
      Given the following attended transfer scenario:
      
      1. Transfer target is called
      2. Transferer hangs up
      3. Transfer target call attempt reaches timeout
      4. Transfer target is told to hang up
      5. Transfer target answers before channel is hung up
      6. Transferer recall target is called
      
      A crash would occur. This is because the transfer target call
      attempt, despite being told to hang up, would raise a recall
      target answer before the recall target had been answered. As it
      had not answered there would be no recall target channel and it
      would implode.
      
      This change makes it so that if the transfer target has been
      hung up we don't tell the attended transfer code that it has
      answered. We also clear out the stimulus that the recall target
      has been answered after telling the transfer target to hang up,
      in case it was able to raise the information before we told it
      to hangup.
      
      ASTERISK-27361
      
      Change-Id: Ifb8b255a9c4d2c5c1b8ad77bf54f659ed286df99
      781a520b
    • Corey Farrell's avatar
      aoc: Fix memory management issues. · a95f2994
      Corey Farrell authored
      aoc_publish_blob failed to check for msg allocation error and never
      released msg.
      
      Change-Id: Ib31a9ffb81056a0d496a49d7eec795005a44bcd5
      a95f2994
  7. Nov 16, 2017
Loading