Skip to content
Snippets Groups Projects
  1. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  2. Jul 22, 2014
  3. Aug 17, 2013
  4. Jul 30, 2012
    • Russell Bryant's avatar
      Fix ast_event_new unit test. · ee04ec77
      Russell Bryant authored
      One of my recent commits broke this test.  The error was:
      
      [test_event.c:event_new_test:214]: Events expected to be identical
      have different size: 69 != 59
      
      The difference in size occurred because the first event had
      the EID IE added to the event twice.  ast_event_new() now always
      adds it automatically.  Previously it only added it if there
      were no IEs specified, which was kind of weird.
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@370541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      ee04ec77
  5. Mar 02, 2012
  6. Aug 16, 2011
  7. Jul 14, 2011
  8. Jun 16, 2011
  9. Jun 15, 2011
    • Richard Mudgett's avatar
      Merged revisions 323669-323670 via svnmerge from · b2d0ea5f
      Richard Mudgett authored
      https://origsvn.digium.com/svn/asterisk/branches/1.8
      
      ........
        r323669 | rmudgett | 2011-06-15 11:43:18 -0500 (Wed, 15 Jun 2011) | 21 lines
        
        [regression] Voicemail MWI is no longer sent.
        
        When leaving a voicemail, the MWI message is never sent.  The same thing
        happens when checking a voicemail and marking it as read.
        
        If you restart Asterisk, everything comes up at that state correctly, but
        changes to the messages in voicemail causes the light to not be set
        appropriately.  Very easy to reproduce.
        
        * Made ast_event_check_subscriber() return TRUE if there are ANY
        subscribers to an event type when there are no restricting ie values
        passed.  This allows an event being queued to be queued.
        
        (closes issue ASTERISK-18002)
        Reported by: lmadsen
        Tested by: lmadsen, irroot
        Patches:
             jira_asterisk_18002_v1.8.patch uploaded by rmudgett (License #5621)
        
        (closes issue ASTERISK-18019)
      ........
        r323670 | rmudgett | 2011-06-15 11:43:31 -0500 (Wed, 15 Jun 2011) | 7 lines
        
        Add a test to the event unit tests to catch ASTERISK-18002.
        
        The new tests check to see if there are ANY subscribers to the event type
        when ast_event_check_subscriber() is not passed any specific ie values.
        
        (issue ASTERISK-18002)
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323671 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      b2d0ea5f
  10. Jun 03, 2011
    • Richard Mudgett's avatar
      Merged revisions 321871 via svnmerge from · 85aa126b
      Richard Mudgett authored
      https://origsvn.digium.com/svn/asterisk/branches/1.8
      
      ........
        r321871 | rmudgett | 2011-06-03 15:58:13 -0500 (Fri, 03 Jun 2011) | 27 lines
        
        Event subscription fixes.
        
        Must commit the subscription fixes together with the integration
        subscription tests.  The subscription fixes cause an erroneously passing
        test to fail.  The new subscription tests detect errors without the
        subscription fixes.
        
        * Added missing event_names[] table entry.
        
        * Reworked ast_event_check_subscriber()/match_sub_ie_val_to_event() to
        correctly detect if a subscriber exists for the proposed event.
        
        * Made match_ie_val() and match_sub_ie_val_to_event() check the buffer
        length for RAW payload types.
        
        * Fixed error handling memory leak in ast_event_sub_activate(),
        ast_event_unsubscribe(), and ast_event_queue().
        
        * Made ast_event_new() and ast_event_check_subscriber() better protect
        themselves from an invalid payload type.
        
        * Added container lock protection between removing old cache events and
        adding the new cached event in
        ast_event_queue_and_cache()/event_update_cache().
        
        * Added new event subscription tests.
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      85aa126b
  11. Oct 22, 2010
    • Mark Michelson's avatar
      Merged revisions 292741 via svnmerge from · 3964b078
      Mark Michelson authored
      https://origsvn.digium.com/svn/asterisk/branches/1.8
      
      ........
        r292741 | mmichelson | 2010-10-22 12:09:52 -0500 (Fri, 22 Oct 2010) | 12 lines
        
        Prevent multiple runs of event_sub_test from producing false failure results.
        
        The array of test subscriptions was declared "static," meaning that the
        data.count field would retain its value between runs of the test. After the
        first test run, this would result in false reports of test failures.
        
        I chose to just remove the "static" keyword from the structure since it's not
        a huge deal to construct this structure during each run of the test. Another
        alternative would have been to zero out the data.count fields of each test
        subscription instead.
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292742 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      3964b078
  12. Jul 09, 2010
  13. Apr 22, 2010
    • Russell Bryant's avatar
      Add ast_event subscription unit test and fix some ast_event API bugs. · 52a8ddba
      Russell Bryant authored
      This patch introduces another test in test_event.c that exercises most of the
      subscription related ast_event API calls.  I made some minor additions to the
      existing event allocation test to increase API coverage by the test code.
      Finally, I made a list in a comment of API calls not yet touched by the test
      module as a to-do list for future test development.
      
      During the development of this test code, I discovered a number of bugs in
      the event API.
      
      1) subscriptions to AST_EVENT_ALL were not handled appropriately in a couple
         of different places.  The API allows a subscription to all event types,
         but with IE parameters, just as if it was a subscription to a specific
         event type.  However, the parameters were being ignored.  This affected
         ast_event_check_subscriber() and event distribution to subscribers.
      
      2) Some of the logic in ast_event_check_subscriber() for checking subscriptions
         against query parameters was wrong.
      
      Review: https://reviewboard.asterisk.org/r/617/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@258632 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      52a8ddba
  14. Feb 11, 2010
  15. Feb 10, 2010
Loading