Skip to content
Snippets Groups Projects
  1. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  2. Jun 15, 2012
    • Kevin P. Fleming's avatar
      Multiple revisions 369001-369002 · 166b4e2b
      Kevin P. Fleming authored
      ........
        r369001 | kpfleming | 2012-06-15 10:56:08 -0500 (Fri, 15 Jun 2012) | 11 lines
        
        Add support-level indications to many more source files.
        
        Since we now have tools that scan through the source tree looking for files
        with specific support levels, we need to ensure that every file that is
        a component of a 'core' or 'extended' module (or the main Asterisk binary)
        is explicitly marked with its support level. This patch adds support-level
        indications to many more source files in tree, but avoids adding them to
        third-party libraries that are included in the tree and to source files
        that don't end up involved in Asterisk itself.
      ........
        r369002 | kpfleming | 2012-06-15 10:57:14 -0500 (Fri, 15 Jun 2012) | 3 lines
        
        Add a script to enable finding source files without support-levels defined.
      ........
      
      Merged revisions 369001-369002 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 369005 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@369013 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      166b4e2b
  3. Apr 06, 2012
  4. Mar 01, 2012
  5. Feb 29, 2012
  6. Jan 09, 2012
    • Terry Wilson's avatar
      Replace direct access to channel name with accessor functions · 04da92c3
      Terry Wilson authored
      There are many benefits to making the ast_channel an opaque handle, from
      increasing maintainability to presenting ways to kill masquerades. This patch
      kicks things off by taking things a field at a time, renaming the field to
      '__do_not_use_${fieldname}' and then writing setters/getters and converting the
      existing code to using them. When all fields are done, we can move ast_channel
      to a C file from channel.h and lop off the '__do_not_use_'.
      
      This patch sets up main/channel_interal_api.c to be the only file that actually
      accesses the ast_channel's fields directly. The intent would be for any API
      functions in channel.c to use the accessor functions. No more monkeying around
      with channel internals. We should use our own APIs.
      
      The interesting changes in this patch are the addition of
      channel_internal_api.c, the moving of the AST_DATA stuff from channel.c to
      channel_internal_api.c (note: the AST_DATA stuff will have to be reworked to
      use accessor functions when ast_channel is really opaque), and some re-working
      of the way channel iterators/callbacks are handled so as to avoid creating fake
      ast_channels on the stack to pass in matching data by directly accessing fields
      (since "name" is a stringfield and the fake channel doesn't init the
      stringfields, you can't use the ast_channel_name_set() function). I went with
      ast_channel_name(chan) for a getter, and ast_channel_name_set(chan, name) for a
      setter.
      
      The majority of the grunt-work for this change was done by writing a semantic
      patch using Coccinelle ( http://coccinelle.lip6.fr/ ).
      
      Review: https://reviewboard.asterisk.org/r/1655/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@350223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      04da92c3
  7. Sep 02, 2010
  8. Oct 09, 2008
    • Steve Murphy's avatar
      (closes issue #13557) · e235a073
      Steve Murphy authored
      Reported by: nickpeirson
      Patches:
            pbx.c.patch uploaded by nickpeirson (license 579)
            replace_bzero+bcopy.patch uploaded by nickpeirson (license 579)
      Tested by: nickpeirson, murf
      
      1. replaced all refs to bzero and bcopy to memset and memmove instead.
      2. added a note to the CODING-GUIDELINES
      3. add two macros to asterisk.h to prevent bzero, bcopy from creeping
         back into the source
      4. removed bzero from configure, configure.ac, autoconfig.h.in
      
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      e235a073
  9. Jul 14, 2008
  10. Jul 02, 2008
  11. Jun 30, 2008
  12. Jun 29, 2008
    • Luigi Rizzo's avatar
      import the recent additions for video console into trunk, · 1f7a4fb6
      Luigi Rizzo authored
      giving you support for up to 9 video sources (e.g. webcams,
      or X11 grabbers, etc.) active at once, displaying thumbnails for
      each of them in the main GUI window, and with the ability to switch
      between them on the fly during a conversation.
      
      The code also implements a 'Picture in Picture' feature,
      allowing you to select any source as primary or secondary,
      and move the PiP window by just dragging it with the mouse.
      
      The window looks like this:
       ________________________________________________________________
      |  ______   ______   ______   ______   ______   ______   ______  |
      | | tn.1 | | tn.2 | | tn.3 | | tn.4 | | tn.5 | | tn.6 | | tn.7 | |
      | |______| |______| |______| |______| |______| |______| |______| |
      |  ______   ______   ______   ______   ______   ______   ______  |
      | |______| |______| |______| |______| |______| |______| |______| |
      |  _________________    __________________    _________________  |
      | |                 |  |                  |  |                 | |
      | |                 |  |                  |  |                 | |
      | |                 |  |                  |  |                 | |
      | |   remote video  |  |                  |  |   local video   | |
      | |                 |  |                  |  |          ______ | |
      | |                 |  |      keypad      |  |         |  PIP || |
      | |                 |  |                  |  |         |______|| |
      | |_________________|  |                  |  |_________________| |
      |                      |                  |                      |
      |                      |                  |                      |
      |                      |__________________|                      |
      |________________________________________________________________|
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126480 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      1f7a4fb6
    • Luigi Rizzo's avatar
      make this compile after ast_frame's data field changed to a union · e6f17e50
      Luigi Rizzo authored
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126308 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      e6f17e50
  13. May 19, 2008
  14. Jan 10, 2008
  15. Jan 09, 2008
  16. Jan 08, 2008
  17. Jan 01, 2008
  18. Dec 29, 2007
  19. Dec 28, 2007
  20. Dec 27, 2007
  21. Dec 26, 2007
  22. Dec 23, 2007
  23. Dec 22, 2007
  24. Dec 20, 2007
    • Luigi Rizzo's avatar
      add some macros to simplify parsing the config file, · b7adaa02
      Luigi Rizzo authored
      see description in config.h .
      
      They are a variant of the set of macros i used in chan_oss.c,
      structured in a way to be more robust to the presence of
      spurious ';' - basically, they define wrappers for 'do {'
      and '} while (0)', plus some helper functions to deal with simple
      cases such as ast_copy_string, ast_malloc, strtoul, ast_true ...
      
      The prefix (CV_ as 'Config Variable') tries to be easy to remember
      and has been chosen to not conflict with other existing macros in the tree.
      
      For the time being, I have only updated the three source files in the
      tree that used the old M_* macros. Hopefully, more files will be
      converted.
      
      NOTE:
      
          I understand that inventing my own dialect of C is generally wrong;
          however, the lack of adequate support in the language encourages
          lazy programming practices (such as ignoring errors, bounds, etc.)
          and this increases the chance of vulnerability in the code, especially
          because we are parsing user input here.
          Hopefully, these macros and the use of ast_parse_arg (in config.h)
          should encourage the programmer to write more robust code.
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@94191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      b7adaa02
Loading