Skip to content
Snippets Groups Projects
  1. Nov 20, 2017
  2. Nov 19, 2017
    • Corey Farrell's avatar
      res_pjsip: Fix warning by deferring implicit type cast. · 53f42cc0
      Corey Farrell authored
      Mac doesn't like the comparison of -1 to an enum, so store the result of
      ast_sip_str_to_dtmf to an int so we can check for the negative return
      value.  ast_sip_str_to_dtmf returns an int so this is only delaying the
      implicit type cast.
      
      Change-Id: I0c262c1719ee951aae1f437d733a301cf5f8ad29
      53f42cc0
    • Corey Farrell's avatar
      tests: Fix warnings found on Mac. · 75cb4037
      Corey Farrell authored
      test_pbx used raise without explicitly including signal.h.  On Mac for
      some reason nothing else includes it.
      
      test_logger checked if an unsigned int was negative.  Switch the
      variable to 'int' so that error check can be effective.
      
      Change-Id: Ie1db5dd1818ac25cc2ae41b644f848b5865b1362
      75cb4037
    • Corey Farrell's avatar
      res_snmp: Declare RONLY if net-snmp headers do not. · 83a2c4d2
      Corey Farrell authored
      Some net-snmp builds do not provide the RONLY declare, only
      NETSNMP_OLDAPI_RONLY.  Map RONLY to NETSNMP_OLDAPI_RONLY to get around
      this error.
      
      Change-Id: Ida5c7ad9406515825485c4d3b4a34fd6ad0da577
      83a2c4d2
    • Corey Farrell's avatar
      res_fax: Remove checks for unsigned values being >= 0. · 5a899fc5
      Corey Farrell authored
      It's impossible for gwtimeout or fdtimeout to be less than 0 because
      they are unsigned int's.  Remove checks and unreachable branches.
      
      Change-Id: Ib2286960621e6ee245e40013c84986143302bc78
      5a899fc5
    • Corey Farrell's avatar
      iostream: Fix ast_iostream_printf declaration. · b4862e46
      Corey Farrell authored
      This adds the printf attribute and changes 'fmt' from 'const void *' to
      'const char *'.  This resolves a warning from some compiler for
      vsnprintf needing a literal string for format.
      
      Change-Id: I71c33a8262590042ee451e1146760c10bb22fb78
      b4862e46
    • Corey Farrell's avatar
      app_minivm: Fix possible uninitialized return value. · 2fab3aac
      Corey Farrell authored
      Declare 'res' initialized to -1 to deal with earlier error paths that
      could cause 'res' to be returned uninitialized.
      
      Change-Id: I8ac2a5755bf4174d89ef893e924c940f702b104e
      2fab3aac
  3. Nov 17, 2017
  4. Nov 16, 2017
  5. Nov 15, 2017
    • Richard Mudgett's avatar
      chan_pjsip.c: Improve answer failure log messages. · e7935010
      Richard Mudgett authored
      * Balanced the session->inv_session refs on answer failure.
      
      Change-Id: I33542d639d37e692cb46550b972a5fcfc3b804b8
      e7935010
    • Richard Mudgett's avatar
      audiohook.c: Fix freeing a frame and still using it. · b7b800b6
      Richard Mudgett authored
      Memory corruption happened to the media frame caches when an audio hook
      freed a frame when it shouldn't.  I think the freed frame was because a
      jitter buffer interpolated a missing frame and the audio hook
      unconditionally freed it.
      
      * Made audiohook.c:audio_audiohook_write_list() not free an interpolated
      frame if it is the same frame as what was passed into the routine.
      
      * Made plc.c:normalise_history() use memmove() instead of memcpy() on a
      memory block that could overlap.  Found by valgrind investigating this
      issue.
      
      ASTERISK-27238
      ASTERISK-27412
      
      Change-Id: I548d86894281fc4529aefeb9f161f2131ecc6fde
      b7b800b6
    • George Joseph's avatar
      app_record: Don't set RECORD_STATUS chan var until file is closed · f5127073
      George Joseph authored
      We've been calling pbx_builtin_setvar_helper to set the
      RECORD_STATUS variable before actually closing the recorded file.
      If a client is watching VarSet events and tries to do something with
      the file when a RECORD_STATUS event is seen, they might attempt to
      do so while the file it's still open.
      
      We now delay calling pbx_builtin_setvar_helper until after we close
      the file.
      
      ASTERISK-27423
      
      Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254
      f5127073
    • George Joseph's avatar
      ast_coredumper: Add ability to use directory other than /tmp · cf1cb334
      George Joseph authored
      The OUTPUTDIR environment variable can now be set either in the
      environment itself or in ast_debug_tools.conf.  If set, it's used
      for all work products instead of /tmp.
      
      Also added the --tarball-config option that includes the contents
      of /etc/asterisk when either --tarball-coredumps or --tarball-results
      are used.
      
      Change-Id: I66b2553319df61caea5b313d084f51978f730b4c
      cf1cb334
  6. Nov 14, 2017
  7. Nov 13, 2017
Loading