Skip to content
Snippets Groups Projects
  1. May 01, 2015
  2. Apr 13, 2015
    • David M. Lee's avatar
      Fixing extconf compile · e540034f
      David M. Lee authored
      During the mass code deletion for clang support, a stray backslash was
      left behind that was causing utils to fail to compile.
      
      Change-Id: I60e5fa58c9a5b248bde23aaada79ff663f87a2a1
      e540034f
  3. Apr 12, 2015
    • George Joseph's avatar
      Add .gitignore and .gitreview files · 7079f53a
      George Joseph authored
      Add the .gitignore and .gitreview files to the asterisk repo.
      
      NB:  You can add local ignores to the .git/info/exclude file
      without having to do a commit.
      
      Common ignore patterns are in the top-level .gitignore file.
      Subdirectory-specific ignore patterns are in their own .gitignore
      files.
      
      Change-Id: I2b7513fc9acf5d432cf9587c25faa9786af14abf
      Tested-by: George Joseph
      7079f53a
  4. Apr 06, 2015
  5. Mar 28, 2015
  6. Mar 27, 2015
    • Corey Farrell's avatar
      Improved and portable ast_log recursion avoidance · 327e29df
      Corey Farrell authored
      This introduces a new logger routine ast_log_safe.  This routine should be
      used for all error messages in code that can be run as a result of ast_log.
      ast_log_safe does nothing if run recursively.  All error logging in
      astobj2.c, strings.c and utils.h have been switched to ast_log_safe.
      
      This required adding support for raw threadstorage.  This provides direct
      access to the void* pointer in threadstorage.  In ast_log_safe, NULL is used
      to signify that this thread is not already running ast_log_safe, (void*)1 when
      it is already running.  This was done since it's critical that ast_log_safe
      do nothing that could log during recursion checking.
      
      ASTERISK-24155 #close
      Reported by: Timo Teräs
      Review: https://reviewboard.asterisk.org/r/4502/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@433522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      327e29df
  7. Mar 26, 2015
  8. Dec 17, 2014
    • Walter Doekes's avatar
      Fix printf problems with high ascii characters after r413586 (1.8). · 822abf9e
      Walter Doekes authored
      In r413586 (1.8) various casts were added to silence gcc 4.10 warnings.
      Those fixes included things like:
      
          -out += sprintf(out, "%%%02X", (unsigned char) *ptr);
          +out += sprintf(out, "%%%02X", (unsigned) *ptr);
      
      That works for low ascii characters, but for the high range that yields
      e.g. FFFFFFC3 when C3 is expected.
      
      This changeset:
      - fixes those casts to use the 'hh' unsigned char modifier instead
      - consistently uses %02x instead of %2.2x (or other non-standard usage)
      - adds a few 'h' modifiers in various places
      - fixes a 'replcaes' typo
      - dev/urandon typo (in 13+ patch)
      
      Review: https://reviewboard.asterisk.org/r/4263/
      
      ASTERISK-24619 #close
      Reported by: Stefan27 (on IRC)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@429673 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      822abf9e
  9. Apr 01, 2014
  10. Feb 27, 2014
  11. Feb 22, 2014
  12. Jan 22, 2014
  13. Oct 25, 2013
  14. Oct 24, 2013
  15. Sep 10, 2013
  16. Aug 06, 2013
  17. May 02, 2013
  18. Nov 16, 2012
  19. Nov 15, 2012
    • David M. Lee's avatar
      Migrate hashtest/hashtest2 to be unit tests. · bbf35263
      David M. Lee authored
      Both hashtest and hashtest2 are manual testing apps that thrash hash
      tables (hashtab and ao2 containers, respectively), by spinning up
      several threads that randomly insert, delete, lookup and iterate over
      the hash table. If the app doesn't crash, the hash table probably passes
      the test. Those utils are not a part of the typical Asterisk build, so
      they do not usually get compiled. This all makes them less that useful.
      
      This patch removes those manual test programs and replaces them with
      Asterisk unit test modules (test_{hashtab,astobj2}_thrash.so). It also
      attempts to make the tests more deterministic.
      
      * Rather than spinning up some number of threads that operate on the
        hash table randomly, spin up four threads that concurrenly add,
        remove, lookup and iterate over the hash table.
      * Each thread checks the state of the hash table both during and after
        execution, and indicates a test failure if things are not as expected.
      * Each thread times out after 60 seconds to prevent deadlocking the unit
        test run.
      
      (closes issue ASTERISK-20505)
      Reported by: Matt Jordan
      Review: https://reviewboard.asterisk.org/r/2189/
      ........
      
      Merged revisions 376306 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 376315 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@376339 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      bbf35263
  20. Aug 18, 2012
    • Matthew Jordan's avatar
      Update module support level on a variety of modules and compiler options · 999d44a1
      Matthew Jordan authored
      Some core support modules and compiler options were no longer tagged with a
      module support level.  This patch adds 'core' back to those options.
      
      Note that this patch modifies a few of the patches provided by Andrew Latham
      slightly.  res_curl and res_fax are both 'core' supported modules.
      
      (closes issue ASTERISK-20215)
      Reported by: Andrew Latham
      Tested by: mjordan
      Patches:
        astcanary.diff (license #5985) uploaded by Andrew Latham
        cflagsxml.diff (license #5985) uploaded by Andrew Latham
        curl_fax.diff (license #5985) uploaded by Andrew Latham
        soundsxml.diff (license #5985) uploaded by Andrew Latham
      
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@371507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      999d44a1
  21. Aug 01, 2012
  22. Jul 31, 2012
  23. Jun 15, 2012
    • Kevin P. Fleming's avatar
      Multiple revisions 369001-369002 · 166b4e2b
      Kevin P. Fleming authored
      ........
        r369001 | kpfleming | 2012-06-15 10:56:08 -0500 (Fri, 15 Jun 2012) | 11 lines
        
        Add support-level indications to many more source files.
        
        Since we now have tools that scan through the source tree looking for files
        with specific support levels, we need to ensure that every file that is
        a component of a 'core' or 'extended' module (or the main Asterisk binary)
        is explicitly marked with its support level. This patch adds support-level
        indications to many more source files in tree, but avoids adding them to
        third-party libraries that are included in the tree and to source files
        that don't end up involved in Asterisk itself.
      ........
        r369002 | kpfleming | 2012-06-15 10:57:14 -0500 (Fri, 15 Jun 2012) | 3 lines
        
        Add a script to enable finding source files without support-levels defined.
      ........
      
      Merged revisions 369001-369002 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 369005 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@369013 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      166b4e2b
  24. Apr 19, 2012
    • Matthew Jordan's avatar
      Fix a variety of potential buffer overflows · f7829006
      Matthew Jordan authored
      * chan_mobile: Fixed an overrun where the cind_state buffer (an integer array
        of size 16) would be overrun due to improper bounds checking. At worst, the
        buffer can be overrun by a total of 48 bytes (assuming 4-byte integers),
        which would still leave it within the allocated memory of struct hfp.  This
        would corrupt other elements in that struct but not necessarily cause any
        further issues.
      
      * app_sms: The array imsg is of size 250, while the array (ud) that the data
        is copied into is of size 160.  If the size of the inbound message is 
        greater then 160, up to 90 bytes could be overrun in ud.  This would corrupt
        the user data header (array udh) adjacent to ud.
      
      * chan_unistim: A number of invalid memmoves are corrected.  These would move
        data (which may or may not be valid) into the ends of these buffers.
      
      * asterisk: ast_console_toggle_loglevel does not check that the console log
        level being set is less then or equal to the allowed log levels of 32.
      
      * format_pref: In ast_codec_pref_prepend, if any occurrence of the specified
        codec is not found, the value used to index into the array pref->order
        would be one greater then the maximum size of the array.
      
      * jitterbuf: If the element being placed into the jitter buffer lands in the
        last available slot in the jitter history buffer, the insertion sort attempts
        to move the last entry in the buffer into one slot past the maximum length
        of the buffer.  Note that this occurred for both the min and max jitter
        history buffers.
      
      * tdd: If a read from fsk_serial returns a character that is greater then 32,
        an attempt to read past one of the statically defined arrays containing the
        values that character maps to would occur.
      
      * localtime: struct ast_time and tm are not the same size - ast_time is larger,
        although it contains the elements of tm within it in the same layout.  Hence,
        when using memcpy to copy the contents of tm into ast_time, the size of tm
        should be used, as opposed to the size of ast_time.
      
      * extconf: this treats ast_timing's minmask array as if it had a length of 48,
        when it has defined the size of the array as 24.  pbx.h defines minmask as
        having a size of 48.
      
      (issue ASTERISK-19668)
      Reported by: Matt Jordan
      ........
      
      Merged revisions 362485 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 362496 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@362497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f7829006
  25. Mar 14, 2012
  26. Mar 13, 2012
    • Tilghman Lesher's avatar
      Enable macros in 1.8 to find the next highest "h" extension in a context, like in 1.4. · 9af5c769
      Tilghman Lesher authored
      This change restores functionality that was present in 1.4, when AEL macros
      were implemented with the Macro dialplan application.  Macros are fraught with
      functionality issues, because they consume a large portion of the underlying
      application stack.  This limits the ability of AEL users to call many layers
      of subroutines, an issue which Gosub does not have (originally tested to
      100,000 levels deep).  Therefore, starting in 1.6.0, AEL macros were
      implemented with Gosub.
      
      However, there were some implicit behaviors of Macro, which were not replicated
      at the same time as with the transition to Gosub, one of which is documented in
      the related issue.  In particular, the "h" extension is designed to execute not
      in the Macro context, but in the topmost calling context.  Due to legacy issues
      with a misapplied bugfix many years ago, when a macro exited in 1.4, it looks
      in all calling contexts, bubbling up from the deepest level until it finds an
      "h" extension.
      
      Since AEL hides the complexity of the underlying dialplan logic from the AEL
      programmer, it's reasonable to assume that this behavior should not change in
      the transition from Asterisk 1.4 LTS to Asterisk 1.8 LTS, lest we break
      working AEL configurations in the transition to Asterisk 1.8 LTS.  This fix
      is the result, which implements a search for the "h" extension in all calling
      Gosub contexts.
      
      Fixes ASTERISK-19336
      
      Patch: 20120308__ael_bugfix_for_trunk__2.diff (License #5003) by Tilghman Lesher
      	(with slight modifications for 1.8)
      
      Tested by: Johan Wilfer
      
      Review: https://reviewboard.asterisk.org/r/1776/
      ........
      
      Merged revisions 358810 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 358811 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@358812 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      9af5c769
  27. Feb 14, 2012
  28. Feb 08, 2012
  29. Jan 15, 2012
  30. Dec 12, 2011
    • Matthew Jordan's avatar
      Backed out core changes from r346391 · 9057aa20
      Matthew Jordan authored
      During testing, it was discovered that there were a number of side effects
      introduced by r346391 and subsequent check-ins related to it (r346429,
      r346617, and r346655).  This included the /main/stdtime/ test 'hanging',
      as well as the remote console option failing to receive the appropriate output
      after a period of time.
      
      I only backed out the changes to main/ and utils/, as this was adequate
      to reverse the behavior experienced.
      
      (issue ASTERISK-18974)
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@347997 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      9057aa20
  31. Nov 29, 2011
  32. Oct 14, 2011
  33. Oct 10, 2011
  34. Sep 28, 2011
  35. Aug 17, 2011
  36. Jul 14, 2011
  37. Jul 07, 2011
Loading