Skip to content
Snippets Groups Projects
  1. Sep 06, 2012
  2. Sep 05, 2012
  3. Sep 04, 2012
  4. Aug 31, 2012
  5. Aug 30, 2012
    • Mark Michelson's avatar
      Prevent crash on shutdown due to refcount error on queues container. · 1ab2639c
      Mark Michelson authored
      When app_queue is unloaded, the queues container has its refcount
      decremented, potentially to 0. Then the taskprocessor responsible
      for handling device state changes is unreferenced. If the
      taskprocessor happens to be just about to run its task, then it
      will create and destroy an iterator on the queues container.
      This can cause the refcount on the queues container to increase to
      1 and then back to 0. Going back to 0 a second time results in
      double frees.
      
      This failure was seen periodically in the testsuite when Asterisk
      would shut down.
      ........
      
      Merged revisions 372089 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 372090 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 372091 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@372092 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      1ab2639c
    • Mark Michelson's avatar
      Help prevent ringing queue members from being rung when ringinuse set to no. · c3b5ec70
      Mark Michelson authored
      Queue member status would not always get updated properly when the member
      was called, thus resulting in the member getting multiple calls. With this
      change, we update the member's status at the time of calling, and we also
      check to make sure the member is still available to take the call before
      placing an outbound call.
      
      (closes issue ASTERISK-16115)
      reported by nik600
      Patches:
      	app_queue.c-svn-r370418.patch uploaded by Italo Rossi (license #6409)
      ........
      
      Merged revisions 372048 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 372049 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 372050 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@372051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      c3b5ec70
    • Matthew Jordan's avatar
      AST-2012-013: Resolve ACL rules being ignored during calls by some IAX2 peers · acbe1f90
      Matthew Jordan authored
      When an IAX2 call is made using the credentials of a peer defined in a dynamic
      Asterisk Realtime Architecture (ARA) backend, the ACL rules for that peer are
      not applied to the call attempt. This allows for a remote attacker who is aware
      of a peer's credentials to bypass the ACL rules set for that peer.
      
      This patch ensures that the ACLs are applied for all peers, regardless of their
      storage mechanism.
      
      (closes issue ASTERISK-20186)
      Reported by: Alan Frisch
      Tested by: mjordan, Alan Frisch
      ........
      
      Merged revisions 372028 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@372029 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      acbe1f90
    • Matthew Jordan's avatar
      AST-2012-012: Resolve AMI User Unauthorized Shell Access through ExternalIVR · d624f2c5
      Matthew Jordan authored
      The AMI Originate action can allow a remote user to specify information that can
      be used to execute shell commands on the system hosting Asterisk. This can
      result in an unwanted escalation of permissions, as the Originate action, which    
      requires the "originate" class authorization, can be used to perform actions
      that would typically require the "system" class authorization. Previous attempts
      to prevent this permission escalation (AST-2011-006, AST-2012-004) have sought
      to do so by inspecting the names of applications and functions passed in with
      the Originate action and, if those applications/functions matched a predefined
      set of values, rejecting the command if the user lacked the "system" class
      authorization. As noted by IBM X-Force Research, the "ExternalIVR"
      application is not listed in the predefined set of values. The solution for     
      this particular vulnerability is to include the "ExternalIVR" application in the
      set of defined applications/functions that require "system" class authorization.             
                
      Unfortunately, the approach of inspecting fields in the Originate action against
      known applications/functions has a significant flaw. The predefined set of
      values can be bypassed by creative use of the Originate action or by certain
      dialplan configurations, which is beyond the ability of Asterisk to analyze at
      run-time. Attempting to work around these scenarios would result in severely         
      restricting the applications or functions and prevent their usage for legitimate
      means. As such, any additional security vulnerabilities, where an
      application/function that would normally require the "system" class
      authorization can be executed by users with the "originate" class authorization,
      will not be addressed. Instead, the README-SERIOUSLY.bestpractices.txt file has
      been updated to reflect that the AMI Originate action can result in commands
      requiring the "system" class authorization to be executed. Proper system
      configuration can limit the impact of such scenarios.         
                
      (closes issue ASTERISK-20132)
      Reported by: Zubair Ashraf of IBM X-Force Research
      ........
      
      Merged revisions 371998 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 371999 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 372000 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@372001 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      d624f2c5
    • Matthew Jordan's avatar
      Clean up doxygen warnings · 8018b879
      Matthew Jordan authored
      This patch fixes numerous doxygen warnings across Asterisk.  It also updates
      the makefile to regenerate the doxygen configuration on the local system
      before running doxygen to help prevent warnings/errors on the local system.
      
      Much thanks to Andrew for tackling one of the Asterisk janitor projects!
      
      (issue ASTERISK-20259)
      Reported by: Andrew Latham
      Patches:
        doxygen_partial.diff uploaded by Andrew Latham (license 5985)
        make_progdocs.diff uploaded by Andrew Latham (license 5985)
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@371989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      8018b879
    • Matthew Jordan's avatar
      Restore CODING-GUIDELINES to doc folder · 4781be6e
      Matthew Jordan authored
      In r294740, the CODING-GUIDELINES was removed from the doc folder in favor
      of the content on the Asterisk wiki.  Some folks still look in the doc folder
      initially for coding guideline suggestions; as such, this patch adds a
      CODING-GUIDELINES file back into the doc folder.  The content of the file
      merely points to the correct page on the Asterisk wiki where the coding
      guidelines currently live.
      
      (closes issue ASTERISK-20279)
      Reported by: Andrew Latham
      Patches:
        CODING-GUIDELINES.diff uploaded by Andrew Latham (license 5985)
      ........
      
      Merged revisions 371961 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 371962 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 371963 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@371964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      4781be6e
  6. Aug 29, 2012
  7. Aug 27, 2012
Loading