Skip to content
Snippets Groups Projects
  1. Jan 02, 2013
    • Automerge script's avatar
      Merged revisions 378288 via svnmerge from · 59663645
      Automerge script authored
      file:///srv/subversion/repos/asterisk/trunk
      
      ................
        r378288 | mjordan | 2013-01-02 09:39:42 -0600 (Wed, 02 Jan 2013) | 36 lines
        
        Resolve crashes due to large stack allocations when using TCP
        
        Asterisk had several places where messages received over various network
        transports may be copied in a single stack allocation. In the case of TCP,
        since multiple packets in a stream may be concatenated together, this can
        lead to large allocations that overflow the stack.
        
        This patch modifies those portions of Asterisk using TCP to either
        favor heap allocations or use an upper bound to ensure that the stack will not
        overflow:
         * For SIP, the allocation now has an upper limit
         * For HTTP, the allocation is now a heap allocation instead of a stack
           allocation
         * For XMPP (in res_jabber), the allocation has been eliminated since it was
           unnecesary.
        
        Note that the HTTP portion of this issue was independently found by Brandon
        Edwards of Exodus Intelligence.
        
        (issue ASTERISK-20658)
        Reported by: wdoekes, Brandon Edwards
        Tested by: mmichelson, wdoekes
        patches:
          ASTERISK-20658_res_jabber.c.patch uploaded by mmichelson (license 5049)
          issueA20658_http_postvars_use_malloc2.patch uploaded by wdoekes (license 5674)
          issueA20658_limit_sip_packet_size3.patch uploaded by wdoekes (license 5674)
        ........
        
        Merged revisions 378269 from http://svn.asterisk.org/svn/asterisk/branches/1.8
        ........
        
        Merged revisions 378286 from http://svn.asterisk.org/svn/asterisk/branches/10
        ........
        
        Merged revisions 378287 from http://svn.asterisk.org/svn/asterisk/branches/11
      ................
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/team/mmichelson/threadpool@378296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      59663645
  2. Jan 01, 2013
  3. Dec 31, 2012
  4. Dec 20, 2012
  5. Dec 18, 2012
  6. Dec 17, 2012
  7. Dec 14, 2012
  8. Dec 13, 2012
  9. Dec 12, 2012
  10. Dec 11, 2012
  11. Dec 10, 2012
Loading