Skip to content
Snippets Groups Projects
  1. Nov 14, 2016
  2. Nov 11, 2016
  3. Nov 10, 2016
  4. Nov 09, 2016
    • Sebastian Gutierrez's avatar
      app_queue: new variable set when abandoned · 4e8ab6cd
      Sebastian Gutierrez authored
      sets the variable ABANDONED to TRUE if the call was not answered.
      
      ASTERISK-26558
      
      Change-Id: I4729af9bff4eba436d8a776afd3374065d0036d3
      4e8ab6cd
    • Mark Michelson's avatar
      res_pjsip_session: Do not call session supplements when it's too late. · e5860ce0
      Mark Michelson authored
      res_pjsip_sesssion was hooking into transaction and invite state
      changes. One of the reasons for doing so was due to the
      PJSIP_EVENT_TX_MSG event. The idea was that we were hooking into the
      message sending process, and so we should call session supplements to
      alter the outgoing message.
      
      In reality, this event was meant to indicate that the message either
      a) had already been sent, or
      b) required a DNS lookup and would be sent when the DNS query
      completed.
      
      In case (a), this meant we were altering an already-sent
      request/response for no reason. In case (b), this potentially meant we
      could be trying to alter a request/response at the same time that the
      DNS resolution completed. In this case, it meant we might be stomping on
      memory being used by the thread actually sending the message. This
      caused potential crashes and memory corruption.
      
      This patch removes the calls to session supplements from the case where
      the PJSIP_EVENT_TX_MSG event occurs. In all of these cases, trying to
      alter the message at this point is too late, and it can cause nothing
      but harm to try to do it. Because there were no longer any calls to the
      handle_outgoing() function, it has been removed.
      
      Change-Id: Ibcc223fb1c3a237927f38754e0429e80ee301e92
      e5860ce0
  5. Nov 08, 2016
  6. Nov 07, 2016
Loading