Skip to content
Snippets Groups Projects
  1. Feb 14, 2011
    • Tilghman Lesher's avatar
      Merged revisions 307750 via svnmerge from · 7800a1c3
      Tilghman Lesher authored
      https://origsvn.digium.com/svn/asterisk/branches/1.8
      
      ........
        r307750 | tilghman | 2011-02-14 00:50:23 -0600 (Mon, 14 Feb 2011) | 23 lines
        
        Calling a gosub routine defined in AEL from Dial/Queue ceased to work.
        
        A bug in AEL did not distinguish between the "s" extension generated by
        AEL and an "s" extension that was required to exist by the chan_dahdi
        (or another channel) that was not supplied with a starting extension.
        Therefore, AEL made incorrect assumptions about what commands were
        permissable in the context.  This was fixed by making AEL generate a
        different extension name.  However, Dial and Queue make additional
        assumptions about the name of the default gosub extension.  Therefore,
        they needed to be brought into line with a "macro" rendered by AEL (as
        a gosub), without breaking traditional dialplans written without the
        aid of AEL.
        
        Related to (issue #18480)
         Reported by: nivek
        
        (closes issue #18729)
         Reported by: kkm
         Patches: 
               20110209__issue18729.diff.txt uploaded by tilghman (license 14)
               018729-dial-queue-gosub-try3.patch uploaded by kkm (license 888)
         Tested by: kkm
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@307751 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      7800a1c3
  2. Feb 13, 2011
  3. Feb 12, 2011
  4. Feb 10, 2011
  5. Feb 09, 2011
  6. Feb 08, 2011
  7. Feb 07, 2011
  8. Feb 05, 2011
  9. Feb 04, 2011
  10. Feb 03, 2011
    • Jeff Peeler's avatar
      Merged revisions 306215 via svnmerge from · 285d953f
      Jeff Peeler authored
      https://origsvn.digium.com/svn/asterisk/branches/1.8
      
      ........
        r306215 | jpeeler | 2011-02-03 17:49:28 -0600 (Thu, 03 Feb 2011) | 20 lines
        
        Fix SIP deadlock involving state changes.
        
        Once again a call to pbx_builtin_getvar_helper (and pbx_builtin_setvar_helper)
        has caused locking problems. Both of these functions lock the channel when
        the channel argument is passed in!
        
        In this case, the suspected problem (the backtrace makes it impossible to tell)
        was the private being locked in sip_set_rtp_peer and then:
        transmit_reinvite_with_sdp
         try_suggested_sip_codec
           pbx_builtin_getvar_helper
        (Traced to verify that the fix was only required in 1.8 and later.)
        
        (closes issue #18491)
        Reported by: cmaj
        Patches: 
              chan_sip_fix_deadlocks_bug_18491.txt uploaded by cmaj (license 830)
        Tested by: cmaj
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@306216 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      285d953f
Loading