Skip to content
Snippets Groups Projects
  1. Nov 18, 2016
  2. Nov 17, 2016
  3. Nov 16, 2016
  4. Nov 15, 2016
    • Joshua Colp's avatar
    • Timo Teräs's avatar
      Implement internal abstraction for iostreams · 070a51bf
      Timo Teräs authored
      fopencookie/funclose is a non-standard API and should not be used
      in portable software. Additionally, the way FILE's fd is used in
      non-blocking mode is undefined behaviour and cannot be relied on.
      
      This introduces internal abstraction for io streams, that allows
      implementing the desired virtualization of read/write operations
      with necessary timeout handling.
      
      ASTERISK-24515 #close
      ASTERISK-24517 #close
      
      Change-Id: Id916aef418b665ced6a7489aef74908b6e376e85
      070a51bf
    • Joshua Colp's avatar
      manager: Bump AMI version number. · d3b61a98
      Joshua Colp authored
      During the development of Asterisk 14 the behavior of
      the Command AMI action was altered such that the result
      was returned on lines with a prefix of "Output: ". While
      this was documented in the UPGRADE.txt file it is also
      reasonable that this should bump the AMI version number.
      
      ASTERISK-26556
      
      Change-Id: Idf1bf01608e53f7bfdf43ddb4d0683e53f74ee42
      d3b61a98
  5. Nov 14, 2016
    • Matt Jordan's avatar
      pjproject: Use a much higher limit for PJ_ICE_MAX_CHECKS · edd7ae85
      Matt Jordan authored
      The PJ_ICE_MAX_CHECKS constant is used by pjproject to determine how
      many pairs of local/remote candidates will be made. If for some reason
      we reach this upper bound, ICE will generally fail and no media will
      flow between the browser and Asterisk.
      
      This patch makes PJ_ICE_MAX_CHECKS set to the total possible number of
      pairs of candidates we'd theoretically allow, which is
      PJ_ICE_MAX_CAND^2. Prior to this patch, we simply multiplied
      PJ_ICE_MAX_CAND by two; on systems with multiple interfaces (I blame
      Docker), this is far too low to allow WebRTC calls to succeed.
      
      Setting this to be PJ_ICE_MAX_CAND^2 allowed WebRTC calls to succeed
      even when the system Asterisk was running on had quite a few virtual
      interfaces.
      
      Change-Id: Icd4f17de0ac9d3a83dddfc8bf1cb7616bc107d55
      edd7ae85
    • Matt Jordan's avatar
      apps/app_echo: Only relay a single video source change frame · cc863292
      Matt Jordan authored
      In 9785e8d0, app_echo was updated to relay video source updates to the
      channel for the purposes of displaying video in WebRTC tests.
      Unfortunately, this can cause a Kafkaesque nightmare if two or more
      Local channels are in a bridge together where their ends are in
      app_echo. When this situation occurs, a video update sent into app_echo
      will cause the video update to be relayed to the other Local channels,
      causing another round of video updates, etc. In not much time at all,
      the channel length queues will be overwhelmed, channel alert pipes will
      fail, and all hell will break loose as Asterisk merrily continues to
      throw more video update requests onto the channels.
      
      This patch updates app_echo to *only* relay a single video update. Once
      a video update has been made, all further video updates are dropped.
      This meets the intended purpose of the original patch: if we get a video
      update and we're in app_echo, go ahead and ask the sender to update
      themselves. However, once we've got that video stream sync'd up, don't
      keep spamming the world.
      
      Change-Id: I9210780b08d4c17ddb38599d1c64453adfc34f74
      cc863292
    • Matt Jordan's avatar
      res/ari/resource_bridges: Add the ability to manipulate the video source · a72ef381
      Matt Jordan authored
      In multi-party bridges, Asterisk currently supports two video modes:
       * Follow the talker, in which the speaker with the most energy is shown
         to all participants but the speaker, and the speaker sees the
         previous video source
       * Explicitly set video sources, in which all participants see a locked
         video source
      
      Prior to this patch, ARI had no ability to manipulate the video source.
      This isn't important for two-party bridges, in which Asterisk merely
      relays the video between the participants. However, in a multi-party
      bridge, it can be advantageous to allow an external application to
      manipulate the video source.
      
      This patch provides two new routes to accomplish this:
      (1) setVideoSource: POST /bridges/{bridgeId}/videoSource/{channelId}
          Sets a video source to an explicit channel
      (2) clearVideoSource: DELETE /bridges/{bridgeId}/videoSource
          Removes any explicit video source, and sets the video mode to talk
          detection
      
      ASTERISK-26595 #close
      
      Change-Id: I98e455d5bffc08ea5e8d6b84ccaf063c714e6621
      a72ef381
    • George Joseph's avatar
      channel: Fix issues in hangup scenarios caused by frame deferral · 7263a17c
      George Joseph authored
      ASTERISK-26343
      
      Change-Id: I06dbf7366e26028251964143454a77d017bb61c8
      (cherry picked from commit 0be46aaf6b8b9eb5b0160ec591cdc2c6e1802a6d)
      7263a17c
    • George Joseph's avatar
      Revert "Revert "channel: Use frame deferral API for safe sleep."" · 0dc45671
      George Joseph authored
      This reverts commit e5365dad.
      
      Change-Id: Icc40cf0c7687454760762912dd29e4ae79e8e9ee
      0dc45671
    • George Joseph's avatar
      Revert "Revert "autoservice: Use frame deferral API"" · 6d61f7bf
      George Joseph authored
      This reverts commit edca6911.
      
      Change-Id: I76030b87333a2c390cd05392b74b75678d78ddfa
      6d61f7bf
    • George Joseph's avatar
      Revert "Revert "AGI: Only defer frames when in an interception routine."" · f62c9c42
      George Joseph authored
      This reverts commit 6bce938c.
      
      Change-Id: Iadbf462bf2a52e8b2fa9ebc75b37b1f688ba51d9
      f62c9c42
    • George Joseph's avatar
      Revert "Revert "Add API for channel frame deferral."" · 2966fa5a
      George Joseph authored
      This reverts commit fa749866.
      
      Change-Id: Idcd1b88fa0766b1326dcc87d8905dbc314c71bd7
      2966fa5a
    • Joshua Colp's avatar
    • Sebastien Duthil's avatar
      res_ari: Add support for channel variables in ARI events. · c6d755de
      Sebastien Duthil authored
      This works the same as for AMI manager variables. Set
      "channelvars=foo,bar" in your ari.conf general section, and then the
      channel variables "foo" and "bar" (along with their values), will
      appear in every Stasis websocket channel event.
      
      ASTERISK-26492 #close
      patches:
        ari_vars.diff submitted by Mark Michelson
      
      Change-Id: I5609ba239259577c0948645df776d7f3bc864229
      c6d755de
    • George Joseph's avatar
      cli: Fix ast_el_read_char to work with libedit >= 3.1 · 72da2ef9
      George Joseph authored
      Libedit 3.1 is not build with unicode on as a default and so the
      prototype for the el_gets callback changed from expecting a char buffer
      to accepting a wchar buffer.  If ast_el_read_char isn't changed,
      the cli reads garbage from teh terminal.
      
      Added a configure test for (*el_rfunc_t)(EditLine *, wchar_t *) and
      updated ast_el_read_char to use the HAVE_ define to detemrine whether
      to use char or wchar.
      
      ASTERISK-26592 #close
      
      Change-Id: I9099b46f68e06d0202ff80e53022a2b68b08871a
      72da2ef9
    • Joshua Colp's avatar
    • Joshua Colp's avatar
  6. Nov 11, 2016
    • Joshua Colp's avatar
      res_pjsip_sdp_rtp: Reject offer of required SRTP without res_srtp. · 1bd49040
      Joshua Colp authored
      When optimistic SRTP was on it was possible for us to still
      set up a call without an audio stream if an offer was received
      with required SRTP.
      
      This change makes it so this scenario will now fail with a 488
      response.
      
      ASTERISK-26575
      
      Change-Id: I7d14187037681f48879bd20319ac79d0877318f3
      1bd49040
Loading