Skip to content
Snippets Groups Projects
  1. Nov 16, 2017
  2. Nov 15, 2017
    • Richard Mudgett's avatar
      chan_pjsip.c: Improve answer failure log messages. · e7935010
      Richard Mudgett authored
      * Balanced the session->inv_session refs on answer failure.
      
      Change-Id: I33542d639d37e692cb46550b972a5fcfc3b804b8
      e7935010
    • Richard Mudgett's avatar
      audiohook.c: Fix freeing a frame and still using it. · b7b800b6
      Richard Mudgett authored
      Memory corruption happened to the media frame caches when an audio hook
      freed a frame when it shouldn't.  I think the freed frame was because a
      jitter buffer interpolated a missing frame and the audio hook
      unconditionally freed it.
      
      * Made audiohook.c:audio_audiohook_write_list() not free an interpolated
      frame if it is the same frame as what was passed into the routine.
      
      * Made plc.c:normalise_history() use memmove() instead of memcpy() on a
      memory block that could overlap.  Found by valgrind investigating this
      issue.
      
      ASTERISK-27238
      ASTERISK-27412
      
      Change-Id: I548d86894281fc4529aefeb9f161f2131ecc6fde
      b7b800b6
    • George Joseph's avatar
      app_record: Don't set RECORD_STATUS chan var until file is closed · f5127073
      George Joseph authored
      We've been calling pbx_builtin_setvar_helper to set the
      RECORD_STATUS variable before actually closing the recorded file.
      If a client is watching VarSet events and tries to do something with
      the file when a RECORD_STATUS event is seen, they might attempt to
      do so while the file it's still open.
      
      We now delay calling pbx_builtin_setvar_helper until after we close
      the file.
      
      ASTERISK-27423
      
      Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254
      f5127073
    • George Joseph's avatar
      ast_coredumper: Add ability to use directory other than /tmp · cf1cb334
      George Joseph authored
      The OUTPUTDIR environment variable can now be set either in the
      environment itself or in ast_debug_tools.conf.  If set, it's used
      for all work products instead of /tmp.
      
      Also added the --tarball-config option that includes the contents
      of /etc/asterisk when either --tarball-coredumps or --tarball-results
      are used.
      
      Change-Id: I66b2553319df61caea5b313d084f51978f730b4c
      cf1cb334
  3. Nov 14, 2017
  4. Nov 13, 2017
  5. Nov 11, 2017
    • Richard Mudgett's avatar
      core: Add cache_media_frames debugging option. · 90bb0a3e
      Richard Mudgett authored
      The media frame cache gets in the way of finding use after free errors of
      media frames.  Tools like valgrind and MALLOC_DEBUG don't know when a
      frame is released because it gets put into the cache instead of being
      freed.
      
      * Added the "cache_media_frames" option to asterisk.conf.  Disabling the
      option helps track down media frame mismanagement when using valgrind or
      MALLOC_DEBUG.  The cache gets in the way of determining if the frame is
      used after free and who freed it.  NOTE: This option has no effect when
      Asterisk is compiled with the LOW_MEMORY compile time option enabled
      because the cache code does not exist.
      
      To disable the media frame cache simply disable the cache_media_frames
      option in asterisk.conf and restart Asterisk.
      
      Sample asterisk.conf setting:
      [options]
      cache_media_frames=no
      
      ASTERISK-27413
      
      Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00
      90bb0a3e
    • Richard Mudgett's avatar
      frame.c: Make ast_frame_free()/ast_frfree() NULL tolerant · b865d29f
      Richard Mudgett authored
      Change-Id: Ic49d821ef88ada38a31bdd835b9531443c55d793
      b865d29f
    • Corey Farrell's avatar
      menuselect: Delete and ignore aclocal.m4. · 96987737
      Corey Farrell authored
      This file is temporary output from the bootstrap.sh command, it does not
      need to be committed.
      
      Change-Id: Ie0fd113aff6eac44924c0bd0c900833c6c86a6d9
      96987737
  6. Nov 10, 2017
  7. Nov 09, 2017
    • Corey Farrell's avatar
      Build System: Disable parallel make in the root Makefile. · 23b0ef3e
      Corey Farrell authored
      This ensures that the root Makefile runs only a single target at a time.
      SUBMAKE will still honor requested parallelism, so 'make -j8' will build
      one directory at a time but allow 8 jobs at once when building a sub
      directory.
      
      This will fix some display glitches related to rebuild of XML
      documentation.  It will also prevent some edge case errors where
      bundled pjproject needs to be rebuild before other parts of Asterisk.
      
      Change-Id: I4f2ec6fbbec1ada0ccb1109a28ea303524239b1e
      23b0ef3e
Loading