Skip to content
Snippets Groups Projects
  1. Sep 13, 2022
    • sungtae kim's avatar
      res_musiconhold: Add option to not play music on hold on unanswered channels · 80bc844f
      sungtae kim authored
      This change adds an option, answeredonly, that will prevent music on
      hold on channels that are not answered.
      
      ASTERISK-30135
      
      Change-Id: I1ab0defa43a29a26ae39f94c623596cf90fddc08
      80bc844f
    • Ben Ford's avatar
      res_pjsip: Add TEL URI support for basic calls. · 881a3f23
      Ben Ford authored
      This change allows TEL URI requests to come through for basic calls. The
      allowed requests are INVITE, ACK, BYE, and CANCEL. The From and To
      headers will now allow TEL URIs, as well as the request URI.
      
      Support is only for TEL URIs present in traffic from a remote party.
      Asterisk does not generate any TEL URIs on its own.
      
      ASTERISK-26894
      
      Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
      881a3f23
  2. Sep 12, 2022
  3. Sep 11, 2022
    • Naveen Albert's avatar
      func_frame_trace: Remove bogus assertion. · 2dac2bf8
      Naveen Albert authored
      The FRAME_TRACE function currently asserts if it sees
      a MASQUERADE_NOTIFY. However, this is a legitimate thing
      that can happen so asserting is inappropriate, as there
      are no clear negative ramifications of such a thing. This
      is adjusted to be like the other frames to print out
      the subclass.
      
      ASTERISK-30210 #close
      
      Change-Id: I8ecbdcf17e35f64bdeab42868471f581ad1d1a56
      2dac2bf8
    • Naveen Albert's avatar
      lock.c: Add AMI event for deadlocks. · c4874256
      Naveen Albert authored
      Adds an AMI event to indicate that a deadlock
      has likely started, when Asterisk is compiled
      with DETECT_DEADLOCKS enabled. This can make
      it easier to perform automated deadlock detection
      and take appropriate action (such as doing a core
      dump). Unlike the deadlock warnings, the AMI event
      is emitted only once per deadlock.
      
      ASTERISK-30161 #close
      
      Change-Id: Ifc6ed3e390f8b4cff7f8077a50e4d7a5b54e42fb
      c4874256
    • Naveen Albert's avatar
      app_confbridge: Add end_marked_any option. · 205c7c8d
      Naveen Albert authored
      Adds the end_marked_any option, which can be used
      to kick a user from a conference if any marked user
      leaves.
      
      ASTERISK-30211 #close
      
      Change-Id: I9e8da7ccb892e522546c0f2b5476d172e022c2f5
      205c7c8d
    • Naveen Albert's avatar
      pbx_variables: Use const char if possible. · 2de016b1
      Naveen Albert authored
      Use const char for char arguments to
      pbx_substitute_variables_helper_full_location
      that can do so (context and exten).
      
      ASTERISK-30209 #close
      
      Change-Id: I001357177e9c3dca2b2b4eebc5650c1095b3da6f
      2de016b1
  4. Sep 10, 2022
    • George Joseph's avatar
      res_geolocation: Add two new options to GEOLOC_PROFILE · 05f42806
      George Joseph authored
      Added an 'a' option to the GEOLOC_PROFILE function to allow
      variable lists like location_info_refinement to be appended
      to instead of replacing the entire list.
      
      Added an 'r' option to the GEOLOC_PROFILE function to resolve all
      variables before a read operation and after a Set operation.
      
      Added a few missing parameters to the ones allowed for writing
      with GEOLOC_PROFILE.
      
      Fixed a bug where calling GEOLOC_PROFILE to read a parameter
      might actually update the profile object.
      
      Cleaned up XML documentation a bit.
      
      ASTERISK-30190
      
      Change-Id: I75f541db43345509a2e86225bfa4cf8e242e5b6c
      05f42806
    • George Joseph's avatar
      res_geolocation: Allow location parameters on the profile object · c799db6a
      George Joseph authored
      You can now specify the location object's format, location_info,
      method, location_source and confidence parameters directly on
      a profile object for simple scenarios where the location
      information isn't common with any other profiles.  This is
      mutually exclusive with setting location_reference on the
      profile.
      
      Updated appdocsxml.dtd to allow xi:include in a configObject
      element.  This makes it easier to link to complete configOptions
      in another object.  This is used to add the above fields to the
      profile object without having to maintain the option descriptions
      in two places.
      
      ASTERISK-30185
      
      Change-Id: Ifd5f05be0a76f0a6ad49fa28d17c394027677569
      c799db6a
    • George Joseph's avatar
      res_geolocation: Add profile parameter suppress_empty_ca_elements · 4ffc5561
      George Joseph authored
      Added profile parameter "suppress_empty_ca_elements" that
      will cause Civic Address elements that are empty to be
      suppressed from the outgoing PIDF-LO document.
      
      Fixed a possible SEGV if a sub-parameter value didn't have a
      value.
      
      ASTERISK-30177
      
      Change-Id: I924ccc5aa2f45110a3155b22e53dfaf3ef2092dd
      4ffc5561
    • George Joseph's avatar
      res_geolocation: Add built-in profiles · 2d5a6498
      George Joseph authored
      The trigger to perform outgoing geolocation processing is the
      presence of a geoloc_outgoing_call_profile on an endpoint. This
      is intentional so as to not leak location information to
      destinations that shouldn't receive it.   In a totally dynamic
      configuration scenario however, there may not be any profiles
      defined in geolocation.conf.  This makes it impossible to do
      outgoing processing without defining a "dummy" profile in the
      config file.
      
      This commit adds 4 built-in profiles:
        "<prefer_config>"
        "<discard_config>"
        "<prefer_incoming>"
        "<discard_incoming>"
      The profiles are empty except for having their precedence
      set and can be set on an endpoint to allow processing without
      entries in geolocation.conf.  "<discard_config>" is actually the
      best one to use in this situation.
      
      ASTERISK-30182
      
      Change-Id: I1819ccfa404ce59802a3a07ad1cabed60fb9480a
      2d5a6498
    • Joshua C. Colp's avatar
      res_pjsip_sdp_rtp: Skip formats without SDP details. · f3de933b
      Joshua C. Colp authored
      When producing an outgoing SDP we iterate through the configured
      formats and produce SDP information. It is possible for some
      configured formats to not have SDP information available. If this
      is the case we skip over them to allow the SDP to still be
      produced.
      
      ASTERISK-29185
      
      Change-Id: I3e37569aa4ca341260e6ca5904dc2f75e46a1749
      f3de933b
    • Naveen Albert's avatar
      cli: Prevent assertions on startup from bad ao2 refs. · c7612521
      Naveen Albert authored
      If "core show channels" is run before startup has completed, it
      is possible for bad ao2 refs to occur because the system is not
      yet fully initialized. This will lead to an assertion failing.
      
      To prevent this, initialization of CLI builtins is moved to be
      later along in the main load sequence. Core CLI commands are
      loaded at the same time, but channel-related commands are loaded
      later on.
      
      ASTERISK-29846 #close
      
      Change-Id: If6b3cde802876bd738c1b4cf2683bea6ddc615b6
      c7612521
  5. Sep 09, 2022
    • Joshua C. Colp's avatar
      pjsip: Add TLS transport reload support for certificate and key. · a0713a9f
      Joshua C. Colp authored
      This change adds support using the pjsip_tls_transport_restart
      function for reloading the TLS certificate and key, if the filenames
      remain unchanged. This is useful for Let's Encrypt and other
      situations. Note that no restart of the transport will occur if
      the certificate and key remain unchanged.
      
      ASTERISK-30186
      
      Change-Id: I9bc95a6bf791830a9491ad9fa43c17d4010028d0
      a0713a9f
    • Naveen Albert's avatar
      res_tonedetect: Fix typos referring to wrong variables. · 754346a4
      Naveen Albert authored
      Fixes two typos that cause fax detection to not work.
      One refers to the wrong frame variable, and the other
      refers to the subclass.integer instead of the frametype
      as it should.
      
      ASTERISK-30192 #close
      
      Change-Id: I7b35fdb7bcf25a29a212eee37c20812c64ab3ef1
      754346a4
    • Mike Bradeen's avatar
      alembic: add missing ps_endpoints columns · 46776c77
      Mike Bradeen authored
      The following required columns were missing,
      now added to the ps_endpoints table:
      
      incoming_call_offer_pref
      outgoing_call_offer_pref
      stir_shaken_profile
      
      ASTERISK-29453
      
      Change-Id: I5cf565edf30195844d6acbc1e1de8c5f0d837568
      46776c77
    • Sean Bright's avatar
      chan_dahdi.c: Resolve a format-truncation build warning. · 583e017f
      Sean Bright authored
      With gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0:
      
      > chan_dahdi.c:4129:18: error: ‘%s’ directive output may be truncated
      >   writing up to 255 bytes into a region of size between 242 and 252
      >   [-Werror=format-truncation=]
      
      This removes the error-prone sizeof(...) calculations in favor of just
      doubling the size of the base buffer.
      
      Change-Id: I2d276785286730d3d5d0a921bcea2e065dbf27c5
      583e017f
    • Alexei Gradinari's avatar
      res_pjsip_pubsub: Postpone destruction of old subscriptions on RLS update · 12c4c1bf
      Alexei Gradinari authored
      Set termination state to old subscriptions to prevent queueing and sending
      NOTIFY messages on exten/device state changes.
      
      Postpone destruction of old subscriptions until all already queued tasks
      that may be using old subscriptions have completed.
      
      ASTERISK-29906
      
      Change-Id: I96582aad3a26515ca73a8460ee6756f56f6ba23b
      12c4c1bf
    • Sean Bright's avatar
      channel.h: Remove redundant declaration. · 155c7962
      Sean Bright authored
      The DECLARE_STRINGFIELD_SETTERS_FOR() declares ast_channel_name_set()
      for us, so no need to declare it separately.
      
      Change-Id: I4813a884ada475ddc62bca480bceb4a53b3ec59a
      155c7962
  6. Sep 08, 2022
    • Naveen Albert's avatar
      features: Add transfer initiation options. · 3fa66c92
      Naveen Albert authored
      Adds additional control options over the transfer
      feature functionality to give users more control
      in how the transfer feature sounds and works.
      
      First, the "transfer" sound that plays when a transfer is
      initiated can now be customized by the user in
      features.conf, just as with the other transfer sounds.
      
      Secondly, the user can now specify the transfer extension
      in advance by using the TRANSFER_EXTEN variable. If
      a valid extension is contained in this variable, the call
      will automatically be transferred to this destination.
      Otherwise, it will fall back to collecting the extension
      from the user as is always done now.
      
      ASTERISK-29899 #close
      
      Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
      3fa66c92
  7. Aug 31, 2022
  8. Aug 30, 2022
  9. Aug 17, 2022
    • Naveen Albert's avatar
      general: Very minor coding guideline fixes. · e2e049e4
      Naveen Albert authored
      Fixes a few coding guideline violations:
      * Use of C99 comments
      * Opening brace on same line as function prototype
      
      ASTERISK-30163 #close
      
      Change-Id: I07771c4c89facd41ce8d323859f022ddbddf6ca7
      e2e049e4
  10. Aug 10, 2022
    • George Joseph's avatar
      res_geolocation: Address user issues, remove complexity, plug leaks · 8a8416e3
      George Joseph authored
      * Added processing for the 'confidence' element.
      * Added documentation to some APIs.
      * removed a lot of complex code related to the very-off-nominal
        case of needing to process multiple location info sources.
      * Create a new 'ast_geoloc_eprofile_to_pidf' API that just takes
        one eprofile instead of a datastore of multiples.
      * Plugged a huge leak in XML processing that arose from
        insufficient documentation by the libxml/libxslt authors.
      * Refactored stylesheets to be more efficient.
      * Renamed 'profile_action' to 'profile_precedence' to better
        reflect it's purpose.
      * Added the config option for 'allow_routing_use' which
        sets the value of the 'Geolocation-Routing' header.
      * Removed the GeolocProfileCreate and GeolocProfileDelete
        dialplan apps.
      * Changed the GEOLOC_PROFILE dialplan function as follows:
        * Removed the 'profile' argument.
        * Automatically create a profile if it doesn't exist.
        * Delete a profile if 'inheritable' is set to no.
      * Fixed various bugs and leaks
      * Updated Asterisk WiKi documentation.
      
      ASTERISK-30167
      
      Change-Id: If38c23f26228e96165be161c2f5e849cb8e16fa0
      8a8416e3
    • Naveen Albert's avatar
      chan_iax2: Add missing options documentation. · ff044c22
      Naveen Albert authored
      Adds missing dial resource option documentation.
      
      ASTERISK-30164 #close
      
      Change-Id: I674e1fc9b1e5d67a20599bd4b418ce294d48fc83
      ff044c22
  11. Aug 08, 2022
    • Naveen Albert's avatar
      app_confbridge: Fix memory leak on updated menu options. · dc7ec11c
      Naveen Albert authored
      If the CONFBRIDGE function is used to dynamically set
      menu options, a memory leak occurs when a menu option
      that has been set is overridden, since the menu entry
      is not destroyed before being freed. This ensures that
      it is.
      
      Additionally, logic that duplicates the destroy function
      is removed in lieu of the destroy function itself.
      
      ASTERISK-28422 #close
      
      Change-Id: I71cfb5c24e636984d41086d1333a416dc12ff995
      dc7ec11c
  12. Aug 05, 2022
  13. Aug 02, 2022
    • Naveen Albert's avatar
      manager: Remove documentation for nonexistent action. · f4a020a4
      Naveen Albert authored
      The manager XML documentation documents a "FilterList"
      action, but there is no such action. Therefore, this can
      lead to confusion when people try to use a documented
      action that does not, in fact, exist. This is removed
      as the action never did exist in the past, nor would it
      be trivial to add since we only store the regex_t
      objects, so the filter list can't actually be provided
      without storing that separately. Most likely, the
      documentation was originally added (around version 10)
      in anticipation of something that never happened.
      
      ASTERISK-29917 #close
      
      Change-Id: I846b16fd6f80a91d4ddc5d8a861b522d7c6f8f97
      f4a020a4
  14. Aug 01, 2022
    • Naveen Albert's avatar
      general: Improve logging levels of some log messages. · c6544865
      Naveen Albert authored
      Adjusts some logging levels to be more or less important,
      that is more prominent when actual problems occur and less
      prominent for less noteworthy things.
      
      ASTERISK-30153 #close
      
      Change-Id: Ifc8f7df427aa018627db462125ae744986d3261b
      c6544865
    • Naveen Albert's avatar
      cdr.conf: Remove obsolete app_mysql reference. · 5feebc08
      Naveen Albert authored
      The CDR sample config still mentions that app_mysql
      is available in the addons directory, but this is
      incorrect as it was removed as of 19. This removes
      that to avoid confusion.
      
      ASTERISK-30160 #close
      
      Change-Id: Ie5293ccb4f2b365896981811b480544e67bb9cd7
      5feebc08
    • Naveen Albert's avatar
      general: Remove obsolete SVN references. · 165368bf
      Naveen Albert authored
      There are a handful of files in the tree that
      reference an SVN link for the coding guidelines.
      
      This removes these because the links are dead
      and the vast majority of source files do not
      contain these links, so this is more consistent.
      
      app_skel still maintains an (up to date) link
      to the coding guidelines.
      
      ASTERISK-30159 #close
      
      Change-Id: I35bbb20f66982e98099cff3029ede20091ffdac7
      165368bf
    • Naveen Albert's avatar
      app_confbridge: Add missing AMI documentation. · 2d8f2696
      Naveen Albert authored
      Documents the ConfbridgeListRooms AMI response,
      which is currently not documented.
      
      ASTERISK-30020 #close
      
      Change-Id: Id6fff7a936244bae7b52686301eb740c1169cdea
      2d8f2696
    • Naveen Albert's avatar
      app_meetme: Add missing AMI documentation. · 4af88150
      Naveen Albert authored
      The MeetmeList and MeetmeListRooms AMI
      responses are currently completely undocumented.
      This adds documentation for these responses.
      
      ASTERISK-30018 #close
      
      Change-Id: Id93135b7edf01de6f8fba266e2122989dc8996b8
      4af88150
  15. Jul 27, 2022
    • Naveen Albert's avatar
      func_srv: Document field parameter. · 83912496
      Naveen Albert authored
      Adds missing documentation for the field parameter
      for the SRVRESULT function.
      
      ASTERISK-30151
      Reported by: Chris Young
      
      Change-Id: I4385a2e0892a07e30dea1a8a0588e2c1bea2b1f1
      83912496
Loading