Skip to content
Snippets Groups Projects
  1. Oct 04, 2013
  2. Oct 03, 2013
  3. Oct 02, 2013
  4. Oct 01, 2013
  5. Sep 30, 2013
    • Jonathan Rose's avatar
      configuration samples: Pull all parking related stuff out of features.conf · 8fbe62f5
      Jonathan Rose authored
      This patch also adds documentation for parking from features.conf to
      res_parking.conf
      ........
      
      Merged revisions 400205 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400206 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      8fbe62f5
    • Matthew Jordan's avatar
      Parse arguments passed to the CDR_PROP function correctly · de07050d
      Matthew Jordan authored
      I can only blame this on a bad merge, because this in no way worked properly
      the way it was written. Mea culpa. The function should now parse its arguments
      correctly and function properly. (Note that the API used by the CDR_PROP
      function has working unit tests... this was merely bad coding of the actual
      registered function)
      
      (closes issue ASTERISK-22613)
      Reported by: Private Name
      ........
      
      Merged revisions 400196 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400197 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      de07050d
    • Matthew Jordan's avatar
      Remove spurious event raised when CDRs are reloaded · 9ede3970
      Matthew Jordan authored
      The Reload event is now raised by the module loading core. As such, the Reload
      event in the CDR engine was a duplicate and not needed.
      ........
      
      Merged revisions 400194 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      9ede3970
    • David M. Lee's avatar
      Multiple revisions 399887,400138,400178,400180-400181 · 2de42c2a
      David M. Lee authored
      ........
        r399887 | dlee | 2013-09-26 10:41:47 -0500 (Thu, 26 Sep 2013) | 1 line
        
        Minor performance bump by not allocate manager variable struct if we don't need it
      ........
        r400138 | dlee | 2013-09-30 10:24:00 -0500 (Mon, 30 Sep 2013) | 23 lines
        
        Stasis performance improvements
        
        This patch addresses several performance problems that were found in
        the initial performance testing of Asterisk 12.
        
        The Stasis dispatch object was allocated as an AO2 object, even though
        it has a very confined lifecycle. This was replaced with a straight
        ast_malloc().
        
        The Stasis message router was spending an inordinate amount of time
        searching hash tables. In this case, most of our routers had 6 or
        fewer routes in them to begin with. This was replaced with an array
        that's searched linearly for the route.
        
        We more heavily rely on AO2 objects in Asterisk 12, and the memset()
        in ao2_ref() actually became noticeable on the profile. This was
        #ifdef'ed to only run when AO2_DEBUG was enabled.
        
        After being misled by an erroneous comment in taskprocessor.c during
        profiling, the wrong comment was removed.
        
        Review: https://reviewboard.asterisk.org/r/2873/
      ........
        r400178 | dlee | 2013-09-30 13:26:27 -0500 (Mon, 30 Sep 2013) | 24 lines
        
        Taskprocessor optimization; switch Stasis to use taskprocessors
        
        This patch optimizes taskprocessor to use a semaphore for signaling,
        which the OS can do a better job at managing contention and waiting
        that we can with a mutex and condition.
        
        The taskprocessor execution was also slightly optimized to reduce the
        number of locks taken.
        
        The only observable difference in the taskprocessor implementation is
        that when the final reference to the taskprocessor goes away, it will
        execute all tasks to completion instead of discarding the unexecuted
        tasks.
        
        For systems where unnamed semaphores are not supported, a really
        simple semaphore implementation is provided. (Which gives identical
        performance as the original taskprocessor implementation).
        
        The way we ended up implementing Stasis caused the threadpool to be a
        burden instead of a boost to performance. This was switched to just
        use taskprocessors directly for subscriptions.
        
        Review: https://reviewboard.asterisk.org/r/2881/
      ........
        r400180 | dlee | 2013-09-30 13:39:34 -0500 (Mon, 30 Sep 2013) | 28 lines
        
        Optimize how Stasis forwards are dispatched
        
        This patch optimizes how forwards are dispatched in Stasis.
        
        Originally, forwards were dispatched as subscriptions that are invoked
        on the publishing thread. This did not account for the vast number of
        forwards we would end up having in the system, and the amount of work it
        would take to walk though the forward subscriptions.
        
        This patch modifies Stasis so that rather than walking the tree of
        forwards on every dispatch, when forwards and subscriptions are changed,
        the subscriber list for every topic in the tree is changed.
        
        This has a couple of benefits. First, this reduces the workload of
        dispatching messages. It also reduces contention when dispatching to
        different topics that happen to forward to the same aggregation topic
        (as happens with all of the channel, bridge and endpoint topics).
        
        Since forwards are no longer subscriptions, the bulk of this patch is
        simply changing stasis_subscription objects to stasis_forward objects
        (which, admittedly, I should have done in the first place.)
        
        Since this required me to yet again put in a growing array, I finally
        abstracted that out into a set of ast_vector macros in
        asterisk/vector.h.
        
        Review: https://reviewboard.asterisk.org/r/2883/
      ........
        r400181 | dlee | 2013-09-30 13:48:57 -0500 (Mon, 30 Sep 2013) | 28 lines
        
        Remove dispatch object allocation from Stasis publishing
        
        While looking for areas for performance improvement, I realized that an
        unused feature in Stasis was negatively impacting performance.
        
        When a message is sent to a subscriber, a dispatch object is allocated
        for the dispatch, containing the topic the message was published to, the
        subscriber the message is being sent to, and the message itself.
        
        The topic is actually unused by any subscriber in Asterisk today. And
        the subscriber is associated with the taskprocessor the message is being
        dispatched to.
        
        First, this patch removes the unused topic parameter from Stasis
        subscription callbacks.
        
        Second, this patch introduces the concept of taskprocessor local data,
        data that may be set on a taskprocessor and provided along with the data
        pointer when a task is pushed using the ast_taskprocessor_push_local()
        call. This allows the task to have both data specific to that
        taskprocessor, in addition to data specific to that invocation.
        
        With those two changes, the dispatch object can be removed completely,
        and the message is simply refcounted and sent directly to the
        taskprocessor.
        
        Review: https://reviewboard.asterisk.org/r/2884/
      ........
      
      Merged revisions 399887,400138,400178,400180-400181 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2de42c2a
    • David M. Lee's avatar
      Blocked revisions 399306 · db7c8691
      David M. Lee authored
      ........
      Blocked revisions 399305
      
      ........
      Fix Segfault When Syntax Of A Line Under [applicationmap] Is Invalid
      
      When processing the lines under the [applicationmap] context in features.conf, a
      segfault occurs from attempting to process a line with an invalid syntax
      (basically missing most of the arguments).
      
      Example:
      [applicationmap]
      automon=*6
      
      * This patch moves the checking for empty arguments to before they are accessed.
      
      * Also, checked the "todo" comment and removed it.  Some applications do not
        require arguments.
      
      (closes issue ASTERISK-22416)
      Reported by: CGI.NET
      Tested by: CGI.NET
      Patches:
          asterisk-22416-check-syntax-first_v2.diff by Michael L. Young (license 5026)
      
      Review: https://reviewboard.asterisk.org/r/2803
      ........
      
      Merged revisions 399304 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      db7c8691
    • Kinsey Moore's avatar
      chan_sip: Allow Asterisk to retry after 403 on register · b44ce141
      Kinsey Moore authored
      This adds a global option in chan_sip to allow it to continue
      attempting registration if a 403 is received, clearing the cached nonce
      and treating it as a non-fatal response. Normally, this would cause
      registration attempts to that endpoint to stop.
      
      This also adds a similar per-outbound-registration option to chan_pjsip
      which allows the retry interval to be altered for 403 responses to
      REGISTER requests.
      
      (closes issue ASTERISK-17138)
      Review: https://reviewboard.asterisk.org/r/2874/
      Reported by: Rudi
      ........
      
      Merged revisions 400137 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 400140 from http://svn.asterisk.org/svn/asterisk/branches/11
      ........
      
      Merged revisions 400141 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400142 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      b44ce141
  6. Sep 28, 2013
Loading