Skip to content
Snippets Groups Projects
  1. Nov 16, 2012
  2. Nov 15, 2012
  3. Nov 14, 2012
  4. Nov 13, 2012
  5. Nov 12, 2012
  6. Nov 11, 2012
  7. Nov 08, 2012
  8. Nov 07, 2012
    • Mark Michelson's avatar
      Multiple revisions 375993-375994 · f2bb9afe
      Mark Michelson authored
      ........
        r375993 | mmichelson | 2012-11-07 11:01:13 -0600 (Wed, 07 Nov 2012) | 30 lines
        
        Fix misuses of timeouts throughout the code.
        
        Prior to this change, a common method for determining if a timeout
        was reached was to call a function such as ast_waitfor_n() and inspect
        the out parameter that told how many milliseconds were left, then use
        that as the input to ast_waitfor_n() on the next go-around.
        
        The problem with this is that in some cases, submillisecond timeouts
        can occur, resulting in the out parameter not decreasing any. When this
        happens thousands of times, the result is that the timeout takes much
        longer than intended to be reached. As an example, I had a situation where
        a 3 second timeout took multiple days to finally end since most wakeups
        from ast_waitfor_n() were under a millisecond.
        
        This patch seeks to fix this pattern throughout the code. Now we log the
        time when an operation began and find the difference in wall clock time
        between now and when the event started. This means that sub-millisecond timeouts
        now cannot play havoc when trying to determine if something has timed out.
        
        Part of this fix also includes changing the function ast_waitfor() so that it
        is possible for it to return less than zero when a negative timeout is given
        to it. This makes it actually possible to detect errors in ast_waitfor() when
        there is no timeout.
        
        (closes issue ASTERISK-20414)
        reported by David M. Lee
        
        Review: https://reviewboard.asterisk.org/r/2135/
      ........
        r375994 | mmichelson | 2012-11-07 11:08:44 -0600 (Wed, 07 Nov 2012) | 3 lines
        
        Remove some debugging that accidentally made it in the last commit.
      ........
      
      Merged revisions 375993-375994 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 375995 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 376014 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@376015 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f2bb9afe
  9. Nov 06, 2012
  10. Nov 05, 2012
  11. Nov 04, 2012
  12. Nov 03, 2012
  13. Nov 02, 2012
    • Damien Wedhorn's avatar
      Fix for chan_skinny leaving RTP ports open · 732767f2
      Damien Wedhorn authored
      Skinny wasn't closing RTP sockets. This patch includes ast_rtp_instance_stop before 
      ast_rtp_instance_destroy which fixes the problem. Also add destroy for VRTP (which 
      I believe is unused, but exists).
      
      Review: https://reviewboard.asterisk.org/r/2176/
      ........
      
      Merged revisions 375660 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@375663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      732767f2
    • Richard Mudgett's avatar
      Things don't need to be that const. · f85db0e3
      Richard Mudgett authored
      ........
      
      Merged revisions 375658 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 375659 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 375661 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@375662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f85db0e3
    • Richard Mudgett's avatar
      Multiple revisions 375519-375524 · e950086d
      Richard Mudgett authored
      ........
        r375519 | rmudgett | 2012-10-30 16:06:15 -0500 (Tue, 30 Oct 2012) | 11 lines
      
        chan_misdn: Timer primitives must be handled first.
      
        The frm->addr is a different "address space" than the stack/instance
        address of other Lx primitives.  The test for B channel instance address
        could fail.
      
        Patches:
      	patch01_timers.diff (license #6372) patch uploaded by Guenther Kelleter
      
        JIRA ABE-2888
      
        ........
        r375520 | rmudgett | 2012-10-30 16:14:58 -0500 (Tue, 30 Oct 2012) | 10 lines
      
        chan_misdn: Free memory in error paths and other memory leaks.
      
        The one line commented with BUG is not easily fixable because there is no
        de-init function one can call.
      
        Patches:
      	patch02_memory.diff (license #6372) patch uploaded by Guenther Kelleter
      
        JIRA ABE-2888
      
        ........
        r375521 | rmudgett | 2012-10-30 16:38:41 -0500 (Tue, 30 Oct 2012) | 14 lines
      
        chan_misdn: ISDN NT L2 de-establish/establish
      
        * An NT-PTMP cannot de/establish L2 since it doesn't know the TEIs.
        * On NT-PTP L2 is started when L1 is finally active in handle_l1.
        * L2 deactivation logging cleanup.
        * L2 aggregate link status is unknown for NT-PTMP, show as "UNKN".
        * Removed unused functions and code for L2 handling.
      
        Patches:
      	patch03_L2estab.diff (license #6372) patch uploaded by Guenther Kelleter
      	Modified
      
        JIRA ABE-2888
      
        ........
        r375522 | rmudgett | 2012-10-30 16:56:14 -0500 (Tue, 30 Oct 2012) | 22 lines
      
        chan_misdn: Fix broken upper_id/lower_id usage.
      
        Sending PH prim via lower_id layer (3 or 1) simply does not work.  For TE
        (3) it returns an error (len=-6) which is not evaluated by handle_l1(), so
        the L1 layer status ends up wrong.  Instead PH must be sent via L4, only
        then does it reach L1 without an error message.
      
        And NT PH prims only reach L1 when they are sent to layer 2 id.
        --> use upper_id to send PH primitives.
      
        * Check for errors in PH_(DE)ACTIVATE | CONFIRM.
        * Debug messages are improved.
      
        * The lower_id is now not used for anything, except: Why is lower_id layer
        deleted when it wasn't created?  I removed this code since it looks very
        wrong.
      
        Patches:
      	patch04_l1activation.diff (license #6372) patch uploaded by Guenther Kelleter
      
        JIRA ABE-2888
      
        ........
        r375523 | rmudgett | 2012-10-30 17:29:15 -0500 (Tue, 30 Oct 2012) | 31 lines
      
        chan_misdn: Fix loss of B channels if L1 is down.
      
        If you make 2 calls out an NT PTMP port which is not connected to any
        phone, the B channel associated with that call becomes unusable until
        Asterisk is restarted.
      
        The problem is the EVENT_SETUP is queued when L1 is not up in
        misdn_lib_send_event().  If L1 cannot be activated the event won't be
        dequeued.  It gets even worse when the call is hung up.  The queued
        EVENT_SETUP will be overwritten by an EVENT_DISCONNECT.  The reserved B
        channel then will never be freed.  If later someone connects a phone to
        the port, L1 will eventually activate and the queued EVENT_DISCONNECT is
        sent down the stack.  However, it is ignored because it is the wrong call
        state.
      
        The real fix would be that activation and queueing for a new SETUP is done
        by the NT stack.  But since it doesn't, the workaround must be removed
        because it doesn't always work.
      
        Fix: The event is no longer queued but immediately sent to the stack.  If
        L1 cannot be activated, the L3 state machine that was started by the
        EVENT_SETUP will do its work, i.e.  a timeout will release the B channel
        properly.  The SETUP possibly cannot be sent the first time but is resent
        by T303 in case L1 could be activated.
      
        Patches:
      	patch05_bchan-loss.diff (license #6372) patch uploaded by Guenther Kelleter
      	Modified
      
        JIRA ABE-2888
      
      ........
        r375524 | rmudgett | 2012-10-30 18:26:05 -0500 (Tue, 30 Oct 2012) | 13 lines
      
        chan_misdn: Remove some calls to exit().
      
        Try proper cleanup when something goes wrong in misdn_lib_init().
        Especially do not call exit()!
      
        * Fix memory leak because stack_destroy() does not free the stack struct.
      
        Patches:
      	patch06_cleanup-init.diff (license #6372) patch uploaded by Guenther Kelleter
      	Modified
      
        JIRA ABE-2888
      ........
      
      Merged revisions 375519-375524 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
      ........
      
      Merged revisions 375625 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 375626 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 375627 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@375628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      e950086d
    • Michael L. Young's avatar
      Fix Wrong Result In Debug Message For SDP Origin Processing · 01526b2c
      Michael L. Young authored
      While looking at some debug logs, I noticed that it was being reported that the
      SDP origin line was unsupported or failed.  Upon looking into this on my local
      machine, I found that I too was getting this debug message yet everything seemed
      to be getting processed properly.  What was discovered is, that, the variable to
      determine what is displayed in the debug message for the SDP line that was
      processed, was not being set for the origin line when the result was successful.
      
      This patch fixes this and was tested on local machine.
      ........
      
      Merged revisions 375594 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 375601 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 375613 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@375614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      01526b2c
  14. Nov 01, 2012
  15. Oct 31, 2012
  16. Oct 30, 2012
  17. Oct 29, 2012
Loading