Skip to content
Snippets Groups Projects
  1. Jul 09, 2010
  2. Feb 09, 2010
    • Russell Bryant's avatar
      Various updates to the unit test API. · bbed34f7
      Russell Bryant authored
      1) It occurred to me that the difference in usage between the error ast_str and
      the ast_test_update_status() usage has turned out to be a bit ambiguous in
      practice.  In a lot of cases, the same message was being sent to both.
      In other cases, it was only sent to one or the other.  My opinion now is that
      in every case, I think it makes sense to do both; we should output it to the
      CLI as well as save it off for logging purposes.
      
      This change results in most of the changes in this diff, since it required
      changes to all existing unit tests.  It also allowed for some simplifications
      of unit test API implementation code.
      
      2) Update ast_test_status_update() to include the file, function, and line
      number for the code providing the update.
      
      3) There are some formatting tweaks here and there.  Hopefully they aren't too
      distracting for code review purposes.  Reviewboard's diff viewer seems to do a
      pretty good job of pointing out when something is a whitespace change.
      
      4) I moved the md5_test and sha1_test into the test_utils module.  It seemed
      like a better approach since these tests are so tiny.
      
      5) I changed the number of nodes used in heap_test_2 from 1 million to
      100 thousand.  The only reason for this was to reduce the time it took
      for this test to run.
      
      6) Remove an unused function prototype that was at the bottom of utils.h.
      
      7) Simplify test_insert() using the LIST_INSERT_SORTALPHA() macro.  The one
      minor difference in behavior is that it no longer checks for a test registered
      with the same name.
      
      8) Expand the code in test_alloc() to provide specific error messages for each
      failure case, to clearly inform developers if they forget to set the name,
      summary, description, etc.
      
      9) Tweak the output of the "test show registered" CLI command.  I swapped the
      name and category to have the category first.  It seemed more natural since
      that is the sort key.
      
      10) Don't output the status ast_str in the "test show results" CLI command.
      This is going to tend to be pretty verbose, so just leave that for the
      detailed test logs (test generate results).
      
      Review: https://reviewboard.asterisk.org/r/493/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@245864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      bbed34f7
  3. Feb 02, 2010
  4. Jan 21, 2010
  5. Aug 10, 2009
  6. Jul 30, 2009
  7. Jun 01, 2009
  8. Nov 02, 2008
  9. Nov 01, 2008
  10. Oct 06, 2008
  11. Nov 19, 2007
  12. Nov 16, 2007
    • Luigi Rizzo's avatar
      Start untangling header inclusion in a way that does not affect · fdb7f7ba
      Luigi Rizzo authored
      build times - tested, there is no measureable difference before and
      after this commit.
      
      In this change:
      
      use asterisk/compat.h to include a small set of system headers:
      inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
      stdlib.h, alloca.h, stdio.h
      
      Where available, the inclusion is conditional on HAVE_FOO_H as determined
      by autoconf.
      
      Normally, source files should not include any of the above system headers,
      and instead use either "asterisk.h" or "asterisk/compat.h" which does it
      better. 
      
      For the time being I have left alone second-level directories
      (main/db1-ast, etc.).
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      fdb7f7ba
  13. Jun 28, 2007
  14. Jun 04, 2007
  15. May 24, 2007
  16. Jan 24, 2007
  17. Jan 06, 2007
  18. Jan 02, 2007
  19. Dec 31, 2006
  20. Dec 25, 2006
  21. Aug 21, 2006
  22. Jun 07, 2006
  23. Apr 14, 2006
    • Luigi Rizzo's avatar
      This rather large commit changes the way modules are loaded. · e43bc663
      Luigi Rizzo authored
       
      As partly documented in loader.c and include/asterisk/module.h,
      modules are now expected to return all of their methods and flags
      into a structure 'mod_data', and are normally loaded with RTLD_NOW
      | RTLD_LOCAL, so symbols are resolved immediately and conflicts
      should be less likely.  Only in a small number of cases (res_*,
      typically) modules are loaded RTLD_GLOBAL, so they can export
      symbols.
       
      The core of the change is only the two files loader.c and
      include/asterisk/module.h, all the rest is simply adaptation of the
      existing modules to the new API, a rather mechanical (but believe
      me, time and finger-consuming!) process whose detail you can figure
      out by svn diff'ing any single module.
      
      Expect some minor compilation issue after this change, please
      report it on mantis http://bugs.digium.com/view.php?id=6968
      so we collect all the feedback in one place.
      
      I am just sorry that this change missed SVN version number 20000!
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      e43bc663
  24. Apr 08, 2006
  25. Feb 12, 2006
  26. Feb 11, 2006
  27. Jan 21, 2006
  28. Jan 10, 2006
  29. Dec 30, 2005
  30. Nov 29, 2005
  31. Nov 08, 2005
  32. Nov 03, 2005
  33. Oct 24, 2005
  34. Sep 14, 2005
  35. Jun 09, 2005
Loading