Skip to content
Snippets Groups Projects
  1. Sep 21, 2016
  2. Sep 20, 2016
    • Corey Farrell's avatar
      logger: Simplify ast_callid handling code. · 923edf25
      Corey Farrell authored
      Routines responsible for managing ast_callid's are overly complicated.
      This is left-over code from when ast_callid was an AO2 object.  Now that
      it is an integer the code can be reduced.
      
      ast_callid handler code no longer prints it's own error message upon failure
      to allocate threadstorage as ast_calloc would have already printed a
      message.  Debug messages that were printed when TEST_FRAMEWORK was
      enabled have been also been removed.
      
      Change-Id: I65a768a78dc6cf3cfa071e97f33ce3dce280258e
      923edf25
    • Corey Farrell's avatar
      core: Fix LOW_MEMORY missing symbol ast_pbx_uuid_get. · 5cb905a2
      Corey Farrell authored
      Move the function outside the conditional block that excludes
      LOW_MEMORY.
      
      ASTERISK-26273 #close
      
      Change-Id: Ic290fa128222c410c3531107e30efacabc8493b4
      5cb905a2
    • zuul's avatar
    • Corey Farrell's avatar
      logger: Always enable verbose for console channel. · 00f1d05d
      Corey Farrell authored
      Previous versions of Asterisk did not require verbose to be specified in
      logger.conf for the console channel, if it was requested by command line
      or asterisk.conf it just worked.  This change causes Asterisk to always
      enable verbose in the console channel level mask.  Verbose is displayed
      on consoles if requested by command line, option_verbose or 'core set
      verbose'.
      
      This also delays initialization of the logger until after threadstorage
      is initialized.  Initializing too early can cause messages to be printed
      multiple times to the console (stdout).
      
      ASTERISK-26391 #close
      
      Change-Id: I52187d67c2fcb3efd5561bf04b3e5e23e5ee8a04
      00f1d05d
    • Corey Farrell's avatar
      logger: Fix default console settings. · 74f562a8
      Corey Farrell authored
      When logger.conf is missing or invalid we should be printing notices,
      warnings and errors to the console.  The logmask was incorrectly
      calculated.
      
      Change-Id: Ibaa9465a8682854bc1a5e9ba07079bea1bfb6bb3
      74f562a8
    • zuul's avatar
      ea8105cf
    • zuul's avatar
  3. Sep 19, 2016
  4. Sep 16, 2016
    • Richard Mudgett's avatar
      res_config_odbc.c: Fix buffer size limitation creating invalid SQL. · 2820b133
      Richard Mudgett authored
      Creating ODBC SQL queries resulted in queries too large to fit into the
      supplied buffer.  The resulting truncated buffer contained an invalid SQL
      query.
      
      * Made SQL query generation code use a thread storage buffer that can
      increase in size as needed.
      
      * Fixed bad multi-line warning messages.
      
      ASTERISK-26263 #close
      Reported by: Jeppe Ryskov Larsen
      
      Change-Id: I23f3cdd43c2dac80bed3ded4dd77d18cb17f21ae
      2820b133
  5. Sep 15, 2016
    • Joshua Colp's avatar
      rtp: Only accept the first payload for a format in SDP. · 0376af95
      Joshua Colp authored
      When receiving an SDP offer with multiple payloads for
      the same format we would generate an answer with the first
      payload, but during the payload crossover operation
      (to set the payloads for receiving) we would remove all
      payloads but the last. This would result in incoming
      traffic being matched against the wrong format and outgoing
      traffic being sent using the wrong payload.
      
      This change makes it so that once a format has a payload
      number put into the mapping all subsequent ones are ignored.
      This ensures there is only ever one payload in the mapping
      and that it is the payload placed into the answer SDP.
      
      ASTERISK-26365 #close
      
      Change-Id: I1e8150860a3518cab36d00b1fab50f9352b64e60
      0376af95
    • Joshua Colp's avatar
      res_pjsip_multihomed: Change Contact port to listening port. · 9d894ee0
      Joshua Colp authored
      The res_pjsip_multihomed module determines what interface and transport
      a request is going out on and updates the SIP message accordingly with
      the address information. This currently incorrectly updates the Contact
      header for connectionful protocols to the ephemeral connection port,
      instead of the bound address for the listening socket which can actually
      accept the connection back. If the remote side attempts to connect back on
      the epehemeral port it will fail.
      
      This change makes it so the port is updated to the bound port on
      connectionful protocols and is maintained on UDP (as there can be
      multiple of those).
      
      ASTERISK-26374 #close
      
      Change-Id: I50f8dab65b9f75117d73ba5f6bbcf6c9871854ab
      9d894ee0
    • George Joseph's avatar
      pjproject_bundled: Prevent SERVFAIL from marking name server bad · 47c527df
      George Joseph authored
      A name server that returns "Server Failure" is indicating only that
      the server couldn't process that particular request.  We should NOT
      assume that the name server is incapable of serving other requests.
      
      Here's the scenario we've been encountering...
      
      * 2 local name servers configured in resolv.conf.
      * An OPTIONS request causes a request for A and AAAA records to go out
        to both nameservers.
      * The A responses both come back successfully resolved.
      * Because of an issue at some upstream nameserver, the AAAA responses
        for that particular query come back as "SERVFAIL" from both local
        name servers.
      * Both local servers are marked as bad and no further queries can be
        sent until the 60 second ttl expires.  Only previously cached results
        can be used.
      * In this case, 60 seconds is just enough time for another OPTIONS
        request to go out to the same host so the cycle repeats.
      
      We could set the bad ttl really low but that also affects REFUSED and
      NOTAUTH which probably DO signal a real server issue.  Besides, even
      a really low bad ttl would be an issue on a pbx.
      
      Although we use our own resolver in 14 and master and don't have this
      issue there, Teluu has merged this patch upstream so it's appropriate
      to cherry-pick to 14 and master to keep pjproject consistent.
      
      
      Change-Id: Ie03ba902288e274aff23f9b9bb2786e1e8be09e0
      47c527df
    • Tzafrir Cohen's avatar
      sd_notify (systemd status notifications) support · 07b95f7c
      Tzafrir Cohen authored
      sd_notify() is used to notify systemd of changes to the status of the
      process. This allows the systemd daemon to know when the process
      finished loading (and thus only start another program after Asterisk has
      finished loading).
      
      To use this, use a systemd unit with 'Type=notify' for Asterisk.
      
      This commit also adds the function ast_sd_notify(), a wrapper around
      sd_notify that does nothing if not built with systemd support.
      
      Also adds support for libsystemd detection in the configure script.
      
      Change-Id: Ied6a59dafd5ef331c5c7ae8f3ccd2dfc94be7811
      07b95f7c
    • Timo Teräs's avatar
      Fix showing of swap details when sysinfo() is available · bc81765b
      Timo Teräs authored
      If sysinfo() is available, but not sysctl() or swapctl() the
      printing code for swap buffer sizes is incorrectly omitted.
      The above condition happens with musl c-library.
      
      Fix #if rule to consider defined(HAVE_SYSINFO). And also
      remove the redundant || defined(HAVE_SYSCTL) which was
      incorrectly there to start with. Now swap information is
      displayed only if an actual libc function to get it is
      available.
      
      This also fixes warnings previously seen with musl libc:
      
         [CC] asterisk.c -> asterisk.o
      asterisk.c: In function 'handle_show_sysinfo':
      asterisk.c:773:6: warning: variable 'totalswap' set but not used
       [-Wunused-but-set-variable]
        int totalswap = 0;
            ^~~~~~~~~
      asterisk.c:770:11: warning: variable 'freeswap' set but not used
       [-Wunused-but-set-variable]
        uint64_t freeswap = 0;
                 ^~~~~~~~
      
      Change-Id: I1fb21dad8f27e416c60f138c6f2bff03fb626eca
      bc81765b
    • zuul's avatar
    • zuul's avatar
  6. Sep 14, 2016
  7. Sep 13, 2016
  8. Sep 12, 2016
    • Richard Mudgett's avatar
      app_queue: Fix CLI "queue show" and AMI Queues action output truncation. · 7d7b23f0
      Richard Mudgett authored
      The output of CLI "queue show" and AMI Queues action is truncated and
      "failed to extend from 240 to 327" messages are generated if the queue
      member and interface names are lengthy.
      
      * Increase the string buffer size from 240 to 512 in order to accommodate
      for more information fields added to the output since v1.8.
      
      ASTERISK-26360 #close
      Reported by: Richard Mudgett
      
      Change-Id: Id99c03cf5362453b80491a4b3b0434cb67aa966d
      7d7b23f0
    • zuul's avatar
    • Walter Doekes's avatar
      chan_sip: Allow target refresh (Contact update) on re-INVITE. · 740292e6
      Walter Doekes authored
      Previously, the Contact was stored only on initial INVITE and on any
      18X and 200. That meant that after re-INVITEs from *us* the Contact
      could get updated, but after re-INVITEs from the *peer*, it did not.
      
      This changeset fixes this inconsistency, properly allowing target
      refreshes through re-INVITES (RFC3261, 12.2).
      
      If your strictrtp setting allows it, this change allows you to switch
      the source IP of a connected/calling device mid-call with a simple
      re-INVITE from the new IP.
      
      ASTERISK-26358 #close
      
      Change-Id: Ibb8512054ab27c8c3d2514022568fde943bf2435
      740292e6
  9. Sep 09, 2016
    • Richard Mudgett's avatar
      sip_to_pjsip.py: Map legacy_useroption_parsing. · 82ec58aa
      Richard Mudgett authored
      Map the sip.conf general section legacy_useroption_parsing to the
      new pjsip.conf global ignore_uri_user_options.
      
      ASTERISK-26316
      Reported by: Kevin Harwell
      
      Change-Id: I78108a31995db19d41f4e1a07b3324692c5363fc
      82ec58aa
Loading