Skip to content
Snippets Groups Projects
  1. Sep 03, 2008
  2. Sep 02, 2008
  3. Aug 29, 2008
  4. Aug 27, 2008
  5. Aug 26, 2008
  6. Aug 25, 2008
  7. Aug 24, 2008
  8. Aug 22, 2008
    • Steve Murphy's avatar
      Merged revisions 139635 via svnmerge from · de1af295
      Steve Murphy authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
      r139635 | murf | 2008-08-22 16:24:02 -0600 (Fri, 22 Aug 2008) | 6 lines
      
      I found some problems with the code I committed earlier, when
      I merged them into trunk, so I'm coming back to clean up.
      And, in the process, I found an error in the code I added
      to trunk and 1.6.x, that I'll fix using this patch also.
      
      
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      de1af295
    • Steve Murphy's avatar
      Merged revisions 139347 via svnmerge from · 2488366a
      Steve Murphy authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
      r139347 | murf | 2008-08-21 17:03:50 -0600 (Thu, 21 Aug 2008) | 47 lines
      
      
      (closes issue #13251)
      Reported by: sergee
      Tested by: murf
      
      
      
      THis is a bold move for a static release fix, but I wouldn't have
      made it if I didn't feel confident (at least a *bit* confident)
      that it wouldn't mess everyone up.
      
      The reasoning goes something like this:
      
      1. We simply cannot do anything with CDR's at the current point
      (in pbx.c, after the __ast_pbx_run loop). It's way too late to
      have any affect on the CDRs. The CDR is already posted and gone,
      and the remnants have been cleared.
      
      2. I was very much afraid that moving the running of the 'h'
      extension down into the bridge code (where it would be now
      practical to do it), would result in a lot more calls to the
      'h' exten, so I implemented it as another exten under another
      name, but found, to my pleasant surprise, that there was a 
      1:1 correspondence to the running of the 'h' exten in the
      pbx_run loop, and the new spot at the end of the bridge.
      So, I ifdef'd out the current 'h' loop, and moved it into
      the bridge code. The only difference I can see is the stuff
      about the AST_PBX_KEEPALIVE, and hopefully, if this 
      is still an important decision point, I can replicate it
      if there are complaints. To be perfectly honest,
      the KEEPALIVE situation is not totally clear to me,
      and how it relates to a post-bridge situation is less
      clear. I suspect the users will point out everything
      in total clarity if this steps on anyone's toes!
      
      3. I temporarily swap the bridge_cdr into the channel
      before running the 'h' exten, which makes it possible
      for users to edit the cdr before it goes out the door.
      And, of course, with the endbeforehexten config var set,
      the users can also get at the billsec/duration vals.
      After the h exten finishes, the cdr is swapped back
      and processing continues as normal.
      
      Please, all who deal with CDR's, please test this version
      of Asterisk, and file bug reports as appropriate!
      
      
      ........
      
      I also made a little fix to the app_dial's 'e' option,
      that is related to my updates.
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2488366a
Loading