Skip to content
Snippets Groups Projects
  1. Jul 19, 2015
  2. Aug 25, 2014
  3. Aug 21, 2014
  4. Jun 17, 2014
  5. Jun 15, 2014
  6. Jun 13, 2014
  7. May 14, 2014
  8. May 09, 2014
  9. Mar 06, 2014
    • Russell Bryant's avatar
      moh: fix a refcount error with realtime MOH · fa1d3b09
      Russell Bryant authored
      I observed a crash in res_musiconhold on an Asterisk 11 system using realtime
      MOH.  Investigation of the backtrace showed a corrupt mohclass, implying that
      it got destroyed before the code expected it to.  I went looking for reference
      counting errors that could have caused this crash and this patch this result.
      It contains 2 changes.
      
      1) Remove a usless block of code that was impossible to reach.  There was even
      a comment indicating that it was impossible to reach.  The conditional includes
      "!ast_test_flag(global_flags, MOH_CACHERTCLASSES)" and it's inside of an if
      block with the opposite check "ast_test_flag(global_flags,
      MOH_CACHERTCLASSES)".  There's no good reason to keep it around.
      
      2) A similar block to #1 contained a reference counting error.  It stores
      state->class in the local variable mohclass without increasing its reference
      count.  The reference count on mohclass is decremented at the end of the
      function.  This block of code probably very rarely runs, which would help
      explain why this system was working fine for many months before experiencing a
      crash.
      
      Review: https://reviewboard.asterisk.org/r/3282/
      ........
      
      Merged revisions 410043 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@410044 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      fa1d3b09
  10. Sep 10, 2013
  11. Nov 05, 2012
    • Matthew Jordan's avatar
      Refactor ast_timer_ack to return an error and handle the error in timer users · f0cd27e0
      Matthew Jordan authored
      Currently, if an acknowledgement of a timer fails Asterisk will not realize
      that a serious error occurred and will continue attempting to use the timer's
      file descriptor.  This can lead to situations where errors stream to the
      CLI/log file.  This consumes significant resources, masks the actual problem
      that occurred (whatever caused the timer to fail in the first place), and
      can leave channels in odd states.
      
      This patch propagates the errors in the timing resource modules up through
      the timer core, and makes users of these timers handle acknowledgement
      failures.  It also adds some defensive coding around the use of timers
      to prevent using bad file descriptors in off nominal code paths.
      
      Note that the patch created by the issue reporter was modified slightly for
      this commit and backported to 1.8, as it was originally written for
      Asterisk 10.
      
      Review: https://reviewboard.asterisk.org/r/2178/
      
      (issue ASTERISK-20032)
      Reported by: Jeremiah Gowdy
      patches:
        jgowdy-timerfd-6-22-2012.diff uploaded by Jeremiah Gowdy (license 6358)
      ........
      
      Merged revisions 375893 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 375894 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@375895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f0cd27e0
  12. Oct 02, 2012
  13. Apr 17, 2012
  14. Mar 13, 2012
  15. Feb 28, 2012
  16. Feb 24, 2012
  17. Feb 20, 2012
  18. Jan 24, 2012
  19. Jan 23, 2012
    • Jonathan Rose's avatar
      Add an announcement option to music-on-hold - plays sound when put on hold/between songs · de097494
      Jonathan Rose authored
      This is a feature patch which allows an 'announcement' option to be specified in
      musiconhold.conf which should be set to the name of a sound. If a valid sound is
      specified for this option, then it will be played on that music on hold class whenever
      a channel bound to that class is put on hold as well as when Asterisk is able to detect
      that a song has ended before starting the next song (excludes external players).
      
      (closes ASTERISK-18977)
      Reported by: Timo Teräs
      Patches:
      	asterisk-moh-announcement.diff uploaded by Timo Teräs (license 5409)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@352134 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      de097494
  20. Jan 09, 2012
    • Terry Wilson's avatar
      Replace direct access to channel name with accessor functions · 04da92c3
      Terry Wilson authored
      There are many benefits to making the ast_channel an opaque handle, from
      increasing maintainability to presenting ways to kill masquerades. This patch
      kicks things off by taking things a field at a time, renaming the field to
      '__do_not_use_${fieldname}' and then writing setters/getters and converting the
      existing code to using them. When all fields are done, we can move ast_channel
      to a C file from channel.h and lop off the '__do_not_use_'.
      
      This patch sets up main/channel_interal_api.c to be the only file that actually
      accesses the ast_channel's fields directly. The intent would be for any API
      functions in channel.c to use the accessor functions. No more monkeying around
      with channel internals. We should use our own APIs.
      
      The interesting changes in this patch are the addition of
      channel_internal_api.c, the moving of the AST_DATA stuff from channel.c to
      channel_internal_api.c (note: the AST_DATA stuff will have to be reworked to
      use accessor functions when ast_channel is really opaque), and some re-working
      of the way channel iterators/callbacks are handled so as to avoid creating fake
      ast_channels on the stack to pass in matching data by directly accessing fields
      (since "name" is a stringfield and the fake channel doesn't init the
      stringfields, you can't use the ast_channel_name_set() function). I went with
      ast_channel_name(chan) for a getter, and ast_channel_name_set(chan, name) for a
      setter.
      
      The majority of the grunt-work for this change was done by writing a semantic
      patch using Coccinelle ( http://coccinelle.lip6.fr/ ).
      
      Review: https://reviewboard.asterisk.org/r/1655/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@350223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      04da92c3
  21. Dec 27, 2011
    • Matthew Jordan's avatar
      Fix timing source dependency issues with MOH · d9651f2b
      Matthew Jordan authored
      Prior to this patch, res_musiconhold existed at the same module priority level
      as the timing sources that it depends on.  This would cause a problem when
      music on hold was reloaded, as the timing source could be changed after
      res_musiconhold was processed.  This patch adds a new module priority level,
      AST_MODPRI_TIMING, that the various timing modules are now loaded at.  This
      now occurs before loading other resource modules, such that the timing source
      is guaranteed to be set prior to resolving the timing source dependencies.
      
      (closes issue ASTERISK-17474)
      Reporter: Luke H
      Tested by: Luke H, Vladimir Mikhelson, zzsurf, Wes Van Tlghem, elguero, Thomas Arimont
      Patches:
       asterisk-17474-dahdi_timing-infinite-wait-fix_v3_branch-1.8.diff uploaded by elguero (License #5026)
       asterisk-17474-dahdi_timing-infinite-wait-fix_v3_branch-10.diff uploaded by elguero (License #5026)
       asterisk-17474-dahdi_timing-infinite-wait-fix_v3.diff uploaded by elguero (License #5026)
      
      Review: https://reviewboard.asterisk.org/r/1578/
      ........
      
      Merged revisions 349194 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 349195 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@349196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      d9651f2b
  22. Nov 29, 2011
  23. Nov 23, 2011
  24. Nov 12, 2011
  25. Sep 19, 2011
  26. Sep 02, 2011
    • Richard Mudgett's avatar
      Merged revisions 334357 via svnmerge from · 35e27201
      Richard Mudgett authored
      https://origsvn.digium.com/svn/asterisk/branches/10
      
      ................
        r334357 | rmudgett | 2011-09-02 16:08:16 -0500 (Fri, 02 Sep 2011) | 26 lines
        
        Merged revisions 334355 via svnmerge from 
        https://origsvn.digium.com/svn/asterisk/branches/1.8
        
        ........
          r334355 | rmudgett | 2011-09-02 15:59:49 -0500 (Fri, 02 Sep 2011) | 19 lines
          
          MusicOnHold has extra unref which may lead to memory corruption and crash.
          
          The problem happens when a call is disconnected and you had started a MOH 
          class that does not use the files mode.  If you define REF_DEBUG and 
          recreate the problem, it will announce itself with the following warning: 
          Attempt to unref mohclass 0xb70722e0 (default) when only 1 ref remained, 
          and class is still in a container!  
          
          * Fixed moh_alloc() and moh_release() functions not handling the
          state->class reference consistently.
          
          (closes issue ASTERISK-18346)
          Reported by: Mark Murawski
          Patches:
                jira_asterisk_18346_v1.8.patch (license #5621) patch uploaded by rmudgett
          Tested by: rmudgett, Mark Murawski
          
          Review: https://reviewboard.asterisk.org/r/1404/
        ........
      ................
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@334358 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      35e27201
  27. Aug 08, 2011
  28. Jul 14, 2011
  29. Jun 30, 2011
  30. Jun 28, 2011
  31. May 03, 2011
  32. Apr 21, 2011
  33. Feb 04, 2011
  34. Feb 03, 2011
  35. Feb 01, 2011
  36. Jan 31, 2011
  37. Oct 20, 2010
Loading