Skip to content
Snippets Groups Projects
  1. Mar 12, 2013
  2. Mar 08, 2013
    • Jonathan Rose's avatar
      chan_sip: Update the via header when relaying SMS MESSAGE · 96c231fc
      Jonathan Rose authored
      Prior to this change, certain conditions for sending the message would
      result in an address of '(null)' being used in the via header of the
      SIP message because a NULl value of pvt->ourip was used when initially
      generating the via header. This is fixed by adding a call to build_via
      when the address is set before sending the message.
      
      (closes issue ASTERISK-21148)
      Reported by: Zhi Cheng
      Patches:
      	700-sip_msg_send_via_fix.patch uploaded by Zhi Cheng (license 6475)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@382739 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      96c231fc
  3. Mar 07, 2013
  4. Mar 06, 2013
  5. Mar 05, 2013
  6. Mar 04, 2013
  7. Mar 01, 2013
    • Michael L. Young's avatar
      Fix / Clean Up Some Items To Handle The New auto_* NAT Options · 2109e471
      Michael L. Young authored
      The original report had to do with a realtime peer behind NAT being pruned and
      the peer's private address being used instead of its external address.  Upon
      debugging, it was discovered that this was being caused by the addition of
      the auto_force_rport and auto_comedia settings.
      
      This patch does the following:
      
      * Adds a missing note to the CHANGES file indicating that the default global nat
        setting is auto_force_rport
      
      * Constify the 'req' parameter for check_via()
      
      * Add calls to check_via() in a couple of places in order for the auto_*
        settings to do their job in attempting to determine if NAT is involved
      
      * Set the flags SIP_NAT_FORCE_RPORT and SIP_PAGE2_SYMMETRICRTP if the auto_*
        settings are in use where it was needed
      
      * Moves the copying of peer flags up in build_peer() to before they are used;
        this fixes the realtime prune issue
      
      * Update the contrib/realtime schemas to allow the nat column to handle the
        different nat setting combinations we have
      
      This patch received a review and "Ship It!" on the issue itself.
      
      (closes issue ASTERISK-20904)
      Reported by: JoshE
      Tested by: JoshE, Michael L. Young
      Patches:
        asterisk-20904-nat-auto-and-rt-peersv2.diff Michael L. Young (license 5026)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@382322 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2109e471
  8. Feb 28, 2013
  9. Feb 27, 2013
  10. Feb 26, 2013
  11. Feb 25, 2013
  12. Feb 24, 2013
    • Matthew Jordan's avatar
      Set the sin_family on the bind address socket during initialization · fec08811
      Matthew Jordan authored
      Somehow, chan_jingle has managed to operate for years without setting the
      sin_family on its bindaddr socket. This patch properly sets the field during
      initial module load to AF_INET.
      
      Note that the patch on the issue was modified slightly to change the
      initialization of the socket from allocation of a chan_jingle private to the
      module initialization, as the bindaddr object (which is static) only needs to
      have the address set once.
      
      (closes issue ASTERISK-19341)
      Reported by: andre valentin
      patches:
        0105-chan_jingle.patch uploaded by avalentin (License 6064)
      ........
      
      Merged revisions 381975 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381976 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      fec08811
    • Matthew Jordan's avatar
      Don't display the AMI ALL class authorization for users if they don't have it · e469bc52
      Matthew Jordan authored
      When converting AMI class authorizations to a string representation, the
      method always appends the ALL class authorization. This is especially
      important for events, as they should always communicate that class
      authorization - even if the event itself does not specify ALL as a class
      authorization for itself. (Events have always assumed that the ALL class
      authorization is implied when they are raised)
      
      Unfortunately, this did mean that specifying a user with restricted class
      authorizations would show up in the 'manager show user' CLI command as
      having the ALL class authorization.
      
      Rather then modifying the existing string manipulation function, this patch
      adds a function that will only return a string if the field being compared
      explicitly matches class authorization field it is being compared against.
      This prevents ALL from being returned unless it is actually specified for
      the user.
      
      (closes issue ASTERISK-20397)
      Reported by: Johan Wilfer
      ........
      
      Merged revisions 381939 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381943 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      e469bc52
    • Matthew Jordan's avatar
      Make ParkAndAnnounce return to priority + 1 when return context is not defined · dfe7451e
      Matthew Jordan authored
      The ParkAndAnnounce application documentation for the optional return_context
      parameter states the following:
      
      return_context
          The goto-style label to jump the call back into after timeout. Default
          'priority+1'.
      
      Unfortunately, the application was sending the channel back into the dialplan
      at 'priority', which is the ParkAndAnnounce application call. This causes an
      infinite loop of the channel constantly being parked, announced, timed out,
      parked, announced, timed out... while fun, especially for those callers you
      wish to drive to the end of madness, this was not the intent of the
      application.
      
      (closes issue ASTERISK-20113)
      Reported by: serginuez
      patches:
        app_parkandannounce.diff uploaded by serginuez (License 6405)
      ........
      
      Merged revisions 381916 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381917 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      dfe7451e
  13. Feb 22, 2013
    • Michael L. Young's avatar
      Fix FastAGI To Properly Check For A Connection · 2d451c64
      Michael L. Young authored
      When IPv6 support was added to FastAGI, the intent was to have the ability to
      check all addresses resolved for a host since we might receive an IPv4 address
      and an IPv6 address.  The problem with the current code, is that, since we are
      doing O_NONBLOCK, we get EINPROGRESS when calling ast_connect() but are ignoring
      this instead of handling it.  We break out of the loop and continue on.  When we
      later call ast_poll(), it succeeds but we never check if we have a connection or
      not on the socket level.  We then attempt to send data to the host address that
      we think is setup and it fails.  We then check the errno and see that we have
      "connection refused" and then return with agi failed.
      
      This patch does the following:
      
      * Handles EINPROGRESS by creating the function handle_connection()
        - ast_poll() was moved into this function
        - This function checks the results of the connection on the socket level after
          calling ast_poll()
      * Continues to the next address if the above fails to create a connection
      * Once all addresses resolved are tried and we still are unable to establish a
        connection, then we return that the FastAGI call failed
      
      (closes issue ASTERISK-21065)
      Reported by: Jeremy Kister
      Tested by: Jeremy Kister, Michael L. Young
      Patches:
        asterisk-21065_poll_correctly_v4.diff Michael L. Young (license 5026)
      
      Review: https://reviewboard.asterisk.org/r/2330/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381893 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2d451c64
    • Jonathan Rose's avatar
      app_dial: Honor the 'c' flag when the calling party hangs up · 2ae927b9
      Jonathan Rose authored
      Apparently this feature became broken in 11, probably as a result
      of the Hangup Cause project.
      
      (closes issue ASTERISK-21113)
      Reprted by: Heiko Wundram
      Patches:
      	app_dial.patch uploaded by Heiko Wundram (license 5822)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2ae927b9
  14. Feb 21, 2013
  15. Feb 20, 2013
    • Matthew Jordan's avatar
      Let vm_mailbox_snapshot_create's combine option apply to "Urgent" as well · c157d591
      Matthew Jordan authored
      The vm_mailbox_snapshot_create function has an option that combines the
      contents of INBOX and Old into a single snapshot. The intent of this is that
      both 'new' messages and 'deleted' messages are given in a single snapshot, as
      some applications prefer this view of the voicemail world. Unfortunately, the
      initial implementation ignored the "Urgent" folder. The "Urgent" folder is a
      pseudo-INBOX, in that new messages left with the 'U' flag will be placed in
      that folder as opposed to INBOX. Thus, the option failed the intent with which
      it was added.
      
      This patch makes it so that the "Urgent" folder is included in the snapshot
      when that option is used.
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381835 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      c157d591
  16. Feb 19, 2013
  17. Feb 18, 2013
  18. Feb 16, 2013
    • Matthew Jordan's avatar
      Don't send presencestate information if the state is invalid · cb623e7a
      Matthew Jordan authored
      Previously, presencestate information was sent whenever the state was not
      NOT_SET. When r381594 actually returned INVALID presence state in all the
      places it was supposed to, it caused chan_sip to start adding presence
      state information to NOTIFY requests that it previously would not have
      added. chan_sip shouldn't be adding presence state information when the
      provider is in an invalid state; users can't set the state to invalid and
      an invalid state always implies that the provider is in an error condition.
      
      (issue AST-1084)
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381613 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      cb623e7a
Loading