Skip to content
Snippets Groups Projects
  1. Apr 09, 2015
    • Matthew Jordan's avatar
      clang compiler warnings: Fix autological comparisons · 7c4efc49
      Matthew Jordan authored
      This fixes autological comparison warnings in the following:
       * chan_skinny: letohl may return a signed or unsigned value, depending on the
         macro chosen
       * func_curl: Provide a specific cast to CURLoption to prevent mismatch
       * cel: Fix enum comparisons where the enum can never be negative
       * enum: Fix comparison of return result of dn_expand, which returns a signed
         int value
       * event: Fix enum comparisons where the enum can never be negative
       * indications: tone_data.freq1 and freq2 are unsigned, and hence can never be
         negative
       * presencestate: Use the actual enum value for INVALID state
       * security_events: Fix enum comparisons where the enum can never be negative
       * udptl: Don't bother to check if the return value from encode_length is less
         than 0, as it returns an unsigned int
       * translate: Since the parameters are unsigned int, don't bother checking
         to see if they are negative. The cast to unsigned int would already blow
         past the matrix bounds.
      
      Review: https://reviewboard.asterisk.org/r/4533
      ASTERISK-24917
      Reported by: dkdegroot
      patches:
        rb4533.patch submitted by dkdegroot (License 6600)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@434469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      7c4efc49
  2. Apr 07, 2015
  3. Mar 28, 2015
    • Matthew Jordan's avatar
      clang compiler warnings: Fix a variety of "unused" warnings · 29e6597f
      Matthew Jordan authored
      This patch fixes the -Wunused-value -Wunused-variable -Wunused-const-variable
      errors caught by clang. Specifically:
      
      * apps/app_queue.c: removed unused qpm_cmd_usage[], qum_cmd_usage[],
                          qsmp_cmd_usage[]
      * cel/cel_sqlite3_custom.c: removed unused name[] = "cel_sqlite3_custom"
      * codecs/gsm/src/gsm_create.c: removed unused ident[] = "$Header$"
      * funcs/func_env.c:729: Fixed ast_str_append_substr.
      * main/editline/np/strlcat.c: removed unused rcsid variable
      * main/editline/np/strlcpy.c: removed unused rcsid variable
      * utils/conf2ael.c: removed unused cfextension_states
      * utils/extconf.c: removed unused cfextension_states
      
      Review: https://reviewboard.asterisk.org/r/4526
      
      ASTERISK-24917
      Reported by: dkdegroot
      patches:
        rb4526.patch submitted by dkdegroot (License 6600)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@433693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      29e6597f
  4. Mar 19, 2015
    • Matthew Jordan's avatar
      funcs/func_env: Fix regression caused in FILE read operation · 1e130f92
      Matthew Jordan authored
      When r432935 was merged, it did correctly fix a situation where a FILE read
      operation on the middle of a file buffer would not read the requested length
      in the parameters passed to the FILE function. Unfortunately, it would also
      allow the FILE function to append more bytes than what was available in the
      buffer if the length exceeded the end of the buffer length.
      
      This patch takes the minimum of the remaining bytes in the buffer along with
      the calculated length to append provided by the original patch, and uses
      that as the length to append in the return result. This patch also updates
      the unit tests with the scenarios that were originally pointed out in
      ASTERISK-21765 that the original implementation treated incorrectly.
      
      ASTERISK-21765
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@433173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      1e130f92
  5. Mar 14, 2015
  6. Jan 28, 2015
  7. Jan 23, 2015
  8. Jan 12, 2015
  9. Nov 20, 2014
  10. Nov 02, 2014
  11. Aug 18, 2014
  12. Jul 28, 2014
  13. Jul 15, 2014
  14. Jun 17, 2014
  15. Jun 03, 2014
  16. May 28, 2014
  17. May 21, 2014
  18. May 09, 2014
  19. Mar 27, 2014
  20. Mar 05, 2014
  21. Mar 04, 2014
  22. Jan 14, 2014
    • Richard Mudgett's avatar
      verbosity: Fix performance of console verbose messages. · f90a045a
      Richard Mudgett authored
      The per console verbose level feature as previously implemented caused a
      large performance penalty.  The fix required some minor incompatibilities
      if the new rasterisk is used to connect to an earlier version.  If the new
      rasterisk connects to an older Asterisk version then the root console
      verbose level is always affected by the "core set verbose" command of the
      remote console even though it may appear to only affect the current
      console.  If an older version of rasterisk connects to the new version
      then the "core set verbose" command will have no effect.
      
      * Fixed the verbose performance by not generating a verbose message if
      nothing is going to use it and then filtered any generated verbose
      messages before actually sending them to the remote consoles.
      
      * Split the "core set debug" and "core set verbose" CLI commands to remove
      the per module verbose support that cannot work with the per console
      verbose level.
      
      * Added a silent option to the "core set verbose" command.
      
      * Fixed "core set debug off" tab completion.
      
      * Made "core show settings" list the current console verbosity in addition
      to the root console verbosity.
      
      * Changed the default verbose level of the 'verbose' setting in the
      logger.conf [logfiles] section.  The default is now to once again follow
      the current root console level.  As a result, using the AMI Command action
      with "core set verbose" could again set the root console verbose level and
      affect the verbose level logged.
      
      (closes issue AST-1252)
      Reported by: Guenther Kelleter
      
      Review: https://reviewboard.asterisk.org/r/3114/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@405431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f90a045a
  23. Jan 02, 2014
  24. Dec 18, 2013
  25. Dec 16, 2013
  26. Oct 23, 2013
  27. Oct 08, 2013
  28. Sep 10, 2013
  29. Aug 06, 2013
  30. Jul 21, 2013
  31. Jul 14, 2013
  32. Apr 03, 2013
  33. Mar 20, 2013
  34. Feb 18, 2013
  35. Feb 15, 2013
Loading