Skip to content
Snippets Groups Projects
  1. Apr 29, 2019
    • Rodrigo Ramírez Norambuena's avatar
      app_queue: Set correct value by default for shared_lastcall · ed615afb
      Rodrigo Ramírez Norambuena authored
      There a long history here:
      
      In commit dd1e62c0 has introduce by default shared_lastcall = true by
      default but this now only happen is there not [general] directive in
      queues.conf
      
      After that, the commit 4b50e3f1 fix the
      sample file.
      
      We'll need to keep the same setting if there a general or not section in
      configuration file since the shared_lastcall is by a long time in
      sample files as default value to 'no'.
      
      Change-Id: Id44faec370136df8d57902b453ad4059ed21b94c
      ed615afb
  2. Apr 19, 2019
  3. Apr 18, 2019
  4. Apr 17, 2019
    • Dan Cropp's avatar
      res_pjsip: Added a norefersub configuration setting · cffa2a74
      Dan Cropp authored
      Added a new PJSIP global setting called norefersub.
      Default is true to keep support working as before.
      
      res_pjsip_refer:  Configures PJSIP norefersub capability accordingly.
      
      Checks the PJSIP global setting value.
      If it is true (default) it adds the norefersub capability to PJSIP.
      If it is false (disabled) it does not add the norefersub capability
      to PJSIP.
      
      This is useful for Cisco switches that do not follow RFC4488.
      
      ASTERISK-28375 #close
      Reported-by: Dan Cropp
      
      Change-Id: I0b1c28ebc905d881f4a16e752715487a688b30e9
      cffa2a74
  5. Apr 16, 2019
  6. Apr 15, 2019
    • George Joseph's avatar
      CI: Move test group config files to Jenkins · 8a32b680
      George Joseph authored
      One of the downaides of having things like test configuration
      in the git repo is that it can't be changed at runtime.  You have
      to create a review for the changes and merge it mefore it will
      take effect.
      
      This review moves the data currently held in
      tests/CI/periodic-dailyTestGroups.json and
      tests/CI/gateTestGroups.json into a Jenkins Config File attached
      to the job definitions.  This allows us to alter it from the
      Jenkins UI at runtime.  The original files stay in the repo
      as documentation.
      
      Change-Id: I14b9702f6285ce1fb2420287ba0e7d3b59109763
      8a32b680
  7. Apr 13, 2019
    • Sean Bright's avatar
      app_voicemail: Don't split mailbox options on comma · d58d7d45
      Sean Bright authored
      Because the per-mailbox options are the last thing on a line, don't look
      for or stomp on any subsequent commas.
      
      ASTERISK-27935 #close
      Reported by: Sébastien Duthil
      
      Change-Id: I07b2eb4a33c303d0c7114d5b906f8c067c60a153
      d58d7d45
  8. Apr 12, 2019
  9. Apr 11, 2019
    • Sean Bright's avatar
      res_ael: Create consistent label names across reloads · f8271934
      Sean Bright authored
      Reset the internal counter that the AEL2 compiler uses for unique label
      names before compiling. This keeps dialplan labels consistent across
      reloads assuming the AEL2 has not changed.
      
      ASTERISK-17799 #close
      Reported by: Kirill Katsnelson
      
      Change-Id: I30b3cc887d1ee0644d3f341e2fef16f525d7fae5
      f8271934
    • Sean Bright's avatar
      res_ael: Use Gosub in for loop expressions · f7f1a2cb
      Sean Bright authored
      In AEL2, if a 'for' statement contains macro* calls, like:
      
          for (&iterator(${TRY},A); "${A}" != ""; &iterate(A)) {
      
      The AEL2 parser will translate these into calls to the deprecated Macro
      dialplan application and use the antiquated pipe delimiter.
      
      Instead, convert these into calls to the Gosub dialplan application and
      use commas as argument separators.
      
      ASTERISK-18593 #close
      Reported by: Luke-Jr
      
      * 'macro' in this context means AEL2 macros, not the 'Macro' application
      
      Change-Id: I3d73716033b8e3e42e0209d355bf5f10c97045fc
      f7f1a2cb
    • Sean Bright's avatar
      res_ael: Fix pattern matching against literal '+' · 395c7ed5
      Sean Bright authored
      When generating the regular expression that matches against existing
      extensions, we need to escape literal characters that can also be
      regular expression metacharacters. This was already being done for '*'
      but we need to do the same for '+'.
      
      In passing, remove some unreachable code - strcmp() is already run
      immediately when entering extension_matches().
      
      ASTERISK-14939 #close
      Reported by: klaus3000
      
      Change-Id: I8d2cccb3479168fba1b0a6704c52198b396468f1
      395c7ed5
    • Friendly Automation's avatar
    • Sean Bright's avatar
      pbx.c: Properly parse labels with leading digits · 2cf4e8bf
      Sean Bright authored
      If the target of a Goto is a label that starts with a number, we
      erroneously treat the leading digits as a priority.
      
      ASTERISK-20182 #close
      Reported by: Janu
      
      Change-Id: Ia78408c0805a729103917247ecfc802f6fafc94b
      2cf4e8bf
  10. Apr 10, 2019
  11. Apr 09, 2019
    • Ben Ford's avatar
      build: Revise CHANGES and UPGRADE.txt handling. · a4ab7f5f
      Ben Ford authored
      This changes the way that we handle adding changes to CHANGES and
      UPGRADE.txt. The reason for this is because whenever someone needed to
      make a change to one of these files and someone else had already done
      so, you would run into merge conflicts. With this new setup, there will
      never be merge conflicts since all changes will be documented in the
      doc/<file>-staging directory. The release script is now responsible for
      merging all of these changes into the appropriate files.
      
      There is a special format that these files have to follow in order to be
      parsed. The files do not need to have a meaningful name, but it is
      strongly recommended. For example, if you made a change to pjsip, you
      may have something like this "res_pjsip_relative_title", where
      "relative_title" is something more descriptive than that. Inside each
      file, you will need a subject line for your change, followed by a
      description. There can be multiple subject lines. The file may look
      something like this:
      
         Subject: res_pjsip
         Subject: Core
      
         A description that explains the changes made and why. The release
         script will handle the bulleting and section separators!
      
         You can still separate with new lines within your
         description.
      
      The headers ("Subject" and "Master-Only") are case sensative, but the
      value for "Master-Only" ("true" or "True") is not.
      
      For more information, check out the wiki page:
      https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt
      
      ASTERISK-28111 #close
      
      Change-Id: I19cf4b569321c88155a65e9b0b80f6d58075dd47
      a4ab7f5f
  12. Apr 08, 2019
  13. Apr 05, 2019
  14. Apr 04, 2019
    • Sebastian Kemper's avatar
      loader: support for permanent dlopen() · ccac55b8
      Sebastian Kemper authored
      
      Asterisk assumes that dlopen() will always run the constructor of a
      shared library and every dlclose() will run its destructor. But dlopen()
      may be permanent, meaning the constructor will only be run once, as is
      the case with musl libc.
      
      With a permanent dlopen() the Asterisk module loader does not work
      correctly, because it's expectations regarding when the constructors and
      destructors are run are not met. In fact a segmentation fault will occur
      when the first module is "re-opened" that has AST_MODFLAG_GLOBAL_SYMBOLS
      set (the dlopen() does not call the constructor, resource_being_loaded
      is not set to NULL, then strlen is called with NULL instead of a string,
      see issue ASTERISK-28319).
      
      This commit adds code to the loader that will manually run the
      constructors/destructors of the (non-builtin) modules where needed. To
      achieve this a new ao2 container (linked list) is started and filled
      with objects that contain the names of the modules and the pointers to
      their respective info structs.
      
      This behavior can be activated when configuring Asterisk
      (--enable-permanent-dlopen). By default this is disabled, of course.
      
      ASTERISK-28319 #close
      
      Signed-off-by: default avatarSebastian Kemper <sebastian_ml@gmx.net>
      Change-Id: I86693a0ecf25d5ba81c73773a03df4abc3426875
      ccac55b8
Loading