Skip to content
Snippets Groups Projects
  1. Nov 02, 2008
  2. Nov 01, 2008
  3. Oct 31, 2008
  4. Oct 30, 2008
  5. Oct 29, 2008
    • Mark Michelson's avatar
      If there was no named defined in a voicemail.conf mailbox · 5652a7b8
      Mark Michelson authored
      entry, then app_directory would crash when attempting to
      read that entry from the file. We now check for the NULL
      or empty string properly so that there will be no crash.
      
      (closes issue #13804)
      Reported by: bluecrow76
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      5652a7b8
    • Steve Murphy's avatar
      Merged revisions 152538 via svnmerge from · d736ac2b
      Steve Murphy authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
      r152538 | murf | 2008-10-28 23:19:04 -0600 (Tue, 28 Oct 2008) | 14 lines
      
      A little documentation cross-ref between features and
      dial and queue... I wasted some time (stupidly) trying
      to get the one-touch parking stuff working, because it
      didn't occur to me that I had to also have the corresponding
      options in the dial command! Duh! (In all this time, I never
      set this up before!)
      So, to keep some poor fool from suffering the same fate,
      I made the features.conf.sample file mention the corresponding
      opts in dial/queue; and the docs for dial/app specifically
      mention the corresponding decls in the feature.conf file.
      
      I hope this doesn't spoil some vast, eternal plan...
      
      
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152605 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      d736ac2b
    • Russell Bryant's avatar
      Merged revisions 152539 via svnmerge from · 0dbd8637
      Russell Bryant authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
      r152539 | russell | 2008-10-29 00:23:51 -0500 (Wed, 29 Oct 2008) | 7 lines
      
      Fix an incorrect usage of sizeof()
      
      (closes issue #13795)
      Reported by: andrew53
      Patches:
      	chan_sip_sizeof.patch uploaded by andrew53 (license 519)
      
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152569 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      0dbd8637
    • Steve Murphy's avatar
      Merged revisions 152535 via svnmerge from · 6fad66df
      Steve Murphy authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
      r152535 | murf | 2008-10-28 22:36:32 -0600 (Tue, 28 Oct 2008) | 46 lines
      
      The magic trick to avoid this crash is not to
      try to find the channel by name in the list,
      which is slow and resource consuming, but rather
      to pay attention to the result codes from the
      ast_bridge_call, to which I added the 
      AST_PBX_NO_HANGUP_PEER_PARKED value, which
      now are returned when a channel is parked.
      Why? because CDR's aren't generated via parking,
      so nothing is needed, but if a transfer occurred,
      there are critical things I need.
      
      If you get AST_PBX_KEEPALIVE,
      then don't touch the channel pointer.
      
      If you get AST_PBX_NO_HANGUP_PEER, or
      AST_PBX_NO_HANGUP_PEER_PARKED, then don't
      touch the peer pointer.
      
      Updated the several places where the results
      from a bridge were not being properly obeyed,
      and fixed some code I had introduced so that
      the results of the bridge were not overridden 
      (in trunk).
      
      All the places that previously tested for 
      AST_PBX_NO_HANGUP_PEER now have to check for
      both AST_PBX_NO_HANGUP_PEER and AST_PBX_NO_HANGUP_PEER_PARKED.
      
      I tested this against the 4 common parking
      scenarios:
      
      
      1. A calls B; B answers; A parks B; B hangs up while A is getting the parking
      slot announcement, immediately after being put on hold.
      
      2. A calls B; B answers; A parks B; B hangs up after A has been hung up, but
      before the park times out.
      
      3. A calls B; B answers; B parks A; A hangs up while B is getting the parking slot announcement, immediately after being put on hold.
      
      4. A calls B; B answers; B parks A; A hangs up after B has been hung up, but before the park times out.
      
      
      No crash.
      
      I also ran the scenarios above against valgrind, and accesses looked good.
      
      
      
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      6fad66df
  6. Oct 28, 2008
Loading