Skip to content
Snippets Groups Projects
  1. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  2. Aug 07, 2014
    • Richard Mudgett's avatar
      chan_iax2: Several media format fixes. · ea7d4ab0
      Richard Mudgett authored
      * Fixed the iax.conf bandwidth option.  This is the root cause of
      ASTERISK-24150.
      
      * Added checks in iax2_request() to ensure that there are actual formats
      requested for the new channel to prevent any more fracks from issues like
      ASTERISK-24150.  This is a consequence of the iax.conf bandwidth option
      not working.
      
      * Fixed struct iax2_codec_pref.order member size mismatch issue when
      converting to and from the codec preference order list passed over the
      wire.  In addition the values sent over the wire are now compatible with
      previous Asterisk versions.
      
      * Fixed several issues dealing with the struct iax2_codec_pref members.
      Off-by-one, array limit errors, and the order/framing members always need
      to be updated together.
      
      * Made iax2_request() setup the channel's native format preference order
      according to the user's wishes.  The new media format strategy needs the
      order specified earler.
      
      * Fixed usage of ast_format_compatibility_bitfield2format().  The function
      can return NULL if the bitfield was not associated with a function.
      
      * Deleted dead code iax2_codec_pref_getsize() and
      iax2_codec_pref_setsize().
      
      * Made iax2_parse_allow_disallow() and iax2_codec_pref_string() call
      iax2_codec_pref_to_cap() instead of inlining it.
      
      * Made IAX_CAPABILITY_MEDBANDWIDTH, IAX_CAPABILITY_LOWBANDWIDTH, and
      IAX_CAPABILITY_LOWFREE constants again as they were in Asterisk v1.8.
      
      * Renamed prefs to prefs_global so it won't get confused with the local
      pref versions.
      
      * Fixed too small buffer in handle_cli_iax2_show_peer().
      
      * Fixed ast_cli() calls in handle_cli_iax2_show_peer() to output complete
      lines.
      
      * Changed struct create_addr_info.prefs to be struct iax2_codec_pref as an
      optimization so iax2_request() and iax2_call() do less work.
      
      * Fixed a potential deadlock in ast_iax2_new() on an off-nominal path when
      the pbx could not get started.
      
      * Made set_config() setup a local prefs list along side the local
      capability format bitfield.  Once the config is loaded, then the local
      copies are put into the global versions.
      
      * Fix unininialized codec_buf in function_iaxpeer().
      
      ASTERISK-24150 #close
      Reported by: Scott Griepentrog
      
      Review: https://reviewboard.asterisk.org/r/3890/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@420364 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      ea7d4ab0
  3. Jul 20, 2014
Loading