Skip to content
Snippets Groups Projects
  1. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  2. Dec 20, 2014
  3. Aug 06, 2014
  4. Aug 30, 2013
    • Kevin Harwell's avatar
      Fix various memory leaks · 16b8d0cb
      Kevin Harwell authored
      main/config.c - cleanup cache fie includes
      res/res_security_log.c - unregister logger level
      channesl/chan_sip.c - cleanup io context and notify_types
      main/translator.c - cleanup at shutdown
      main/named_acl.c - cleanup cli commands
      main/indications.c - ast_get_indication_tone() unref default_tone_zone if used
      
      (closes issues ASTERISK-22378)
      Reported by: Corey Farrell
      Patches:
           config_shutdown.patch uploaded by coreyfarrell (license 5909)
           res_security_log.patch uploaded by coreyfarrell (license 5909)
           chan_sip-11.patch uploaded by coreyfarrell (license 5909)
           indications_refleak.patch uploaded by coreyfarrell (license 5909)
           named_acl-cli_unreg-trunk.patch uploaded by coreyfarrell (license 5909)
           translate_shutdown.patch uploaded by coreyfarrell (license 5909)
      
      ........
      
      Merged revisions 398102 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 398103 from http://svn.asterisk.org/svn/asterisk/branches/11
      ........
      
      Merged revisions 398116 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@398124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      16b8d0cb
  5. Jun 25, 2013
    • Matthew Jordan's avatar
      Fix memory/ref counting leaks in a variety of locations · 13b470d7
      Matthew Jordan authored
      This patch fixes the following memory leaks:
       * http.c: The structure containing the addresses to bind to was not being
         deallocated when no longer used
       * named_acl.c: The global configuration information was not disposed of
       * config_options.c: An invalid read was occurring for certain option types.
       * res_calendar.c: The loaded calendars on module unload were not being
         properly disposed of.
       * chan_motif.c: The format capabilities needed to be disposed of on module
         unload. In addition, this now specifies the default options for the
         maxpayloads and maxicecandidates in such a way that it doesn't cause the
         invalid read in config_options.c to occur.
      
      (issue ASTERISK-21906)
      Reported by: John Hardin
      patches:
        http.patch uploaded by jhardin (license 6512)
        named_acl.patch uploaded by jhardin (license 6512)
        config_options.patch uploaded by jhardin (license 6512)
        res_calendar.patch uploaded by jhardin (license 6512)
        chan_motif.patch uploaded by jhardin (license 6512)
      ........
      
      Merged revisions 392810 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@392812 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      13b470d7
  6. May 30, 2013
    • David M. Lee's avatar
      Avoid unnecessary cleanups during immediate shutdown · d81c8467
      David M. Lee authored
      This patch addresses issues during immediate shutdowns, where modules
      are not unloaded, but Asterisk atexit handlers are run.
      
      In the typical case, this usually isn't a big deal. But the
      introduction of the Stasis message bus makes it much more likely for
      asynchronous activity to be happening off in some thread during
      shutdown.
      
      During an immediate shutdown, Asterisk skips unloading modules. But
      while it is processing the atexit handlers, there is a window of time
      where some of the core message types have been cleaned up, but the
      message bus is still running. Specifically, it's still running
      module subscriptions that might be using the core message types. If a
      message is received by that subscription in that window, it will
      attempt to use a message type that has been cleaned up.
      
      To solve this problem, this patch introduces ast_register_cleanup().
      This function operates identically to ast_register_atexit(), except
      that cleanup calls are not invoked on an immediate shutdown. All of
      the core message type and topic cleanup was moved from atexit handlers
      to cleanup handlers.
      
      This ensures that core type and topic cleanup only happens if the
      modules that used them are first unloaded.
      
      This patch also changes the ast_assert() when accessing a cleaned up
      or uninitialized message type to an error log message. Message type
      functions are actually NULL safe across the board, so the assert was a
      bit heavy handed. Especially for anyone with DO_CRASH enabled.
      
      Review: https://reviewboard.asterisk.org/r/2562/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@390122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      d81c8467
  7. May 17, 2013
  8. May 15, 2013
  9. Apr 30, 2013
  10. Feb 15, 2013
    • Matthew Jordan's avatar
      Add CLI configuration documentation · d04ab3c6
      Matthew Jordan authored
      This patch allows a module to define its configuration in XML in source, such
      that it can be parsed by the XML documentation engine. Documentation is
      generated in a two-pass approach:
      
      1. The documentation is first generated from the XML pulled from the source
      2. The documentation is then enhanced by the registration of configuration
         options that use the configuration framework
      
      This patch include configuration documentation for the following modules:
       * chan_motif
       * res_xmpp
       * app_confbridge
       * app_skel
       * udptl
      
      Two new CLI commands have been added:
       * config show help - show configuration help by module, category, and item
       * xmldoc dump - dump the in-memory representation of the XML documentation to
         a new XML file.
      
      Review: https://reviewboard.asterisk.org/r/2278
      Review: https://reviewboard.asterisk.org/r/2058
      
      patches:
        on review 2058 uploaded by twilson
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@381527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      d04ab3c6
  11. Dec 06, 2012
  12. Oct 18, 2012
  13. Oct 02, 2012
  14. Aug 30, 2012
    • Matthew Jordan's avatar
      Clean up doxygen warnings · 8018b879
      Matthew Jordan authored
      This patch fixes numerous doxygen warnings across Asterisk.  It also updates
      the makefile to regenerate the doxygen configuration on the local system
      before running doxygen to help prevent warnings/errors on the local system.
      
      Much thanks to Andrew for tackling one of the Asterisk janitor projects!
      
      (issue ASTERISK-20259)
      Reported by: Andrew Latham
      Patches:
        doxygen_partial.diff uploaded by Andrew Latham (license 5985)
        make_progdocs.diff uploaded by Andrew Latham (license 5985)
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@371989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      8018b879
  15. Jul 19, 2012
  16. Jul 11, 2012
Loading