Skip to content
Snippets Groups Projects
  1. Jul 20, 2015
  2. May 06, 2015
  3. Apr 30, 2015
    • Richard Mudgett's avatar
      chan_dahdi: Add the chan_dahdi.conf force_restart_unavailable_chans option. · b54f5fda
      Richard Mudgett authored
      Some telco switches occasionally ignore ISDN RESTART requests.  The fix
      for ASTERISK-19608 added an escape clause for B channels in the restarting
      state if the telco ignores a RESTART request.  If the telco fails to
      acknowledge the RESTART then Asterisk will assume the telco acknowledged
      the RESTART on the second call attempt requesting the B channel by the
      telco.  The escape clause is good for dealing with RESTART requests in
      general but it does cause the next call for the restarting B channel to be
      rejected if the telco insists the call must go on that B channel.
      
      chan_dahdi doesn't really need to issue a RESTART request in response to
      receiving a cause 44 (Requested channel not available) code.  Sending the
      RESTART in such a situation is not required (nor prohibited) by the
      standards.  I think chan_dahdi does this for historical reasons to deal
      with buggy peers to get channels unstuck in a similar fashion as the
      chan_dahdi.conf resetinterval option.
      
      * Add the chan_dahdi.conf force_restart_unavailable_chans compatability
      option that when disabled will prevent chan_dahdi from trying to RESTART
      the channel in response to a cause 44 code.
      
      ASTERISK-25034 #close
      Reported by: Richard Mudgett
      
      Change-Id: Ib8b17a438799920f4a2038826ff99a1884042f65
      b54f5fda
    • Rodrigo Ramírez Norambuena's avatar
      cdr/cdr_csv.c: Add a new option to enable columns added in Asterisk 1.8 · a7877432
      Rodrigo Ramírez Norambuena authored
      This patch adds a new option to cdr.conf, 'newcdrcolumns', that will handle CDR
      columns added in Asterisk 1.8. The columns are:
       * peeraccount
       * linkedid
       * sequence
      When enabled, the columns in the database entry will be populated with the data
      from the CDR.
      
      ASTERISK-24976 #close
      
      Change-Id: I51a57063f4ae5e194a9d933a8df45dc8a4534f0b
      a7877432
  4. Apr 27, 2015
  5. Mar 14, 2015
  6. Jan 09, 2015
  7. Dec 24, 2014
  8. Nov 09, 2014
  9. Oct 28, 2014
  10. Sep 14, 2014
  11. Jul 03, 2014
    • Richard Mudgett's avatar
      chan_dahdi: Add inband_on_setup_ack compatibility option. · 2f1d2a9e
      Richard Mudgett authored
      The new inband_on_setup_ack option causes Asterisk to assume inband audio
      may be present when a SETUP_ACKNOWLEDGE message is received.
      
      Q.931 Section 5.1.3 says that in scenarios with overlap dialing, when a
      dialtone is sent from the network side, progress indicator 8 "Inband info
      now available" MAY be sent to the CPE if no digits were received with the
      SETUP.  It is thus implied that the ie is mandatory if digits came with
      the SETUP and dialtone is needed.  This option should be enabled, when the
      network sends dialtone and you want to hear it, but the network doesn't
      send the progress indicator when needed.
      
      NOTE: For Q.SIG setups this option should be enabled when outgoing overlap
      dialing is also enabled because Q.SIG does not send the progress indicator
      with the SETUP ACK.
      
      The commit -r413714 (AST-1338) which causes this issue was dealing with a
      SIP-to-ISDN interoperability issue.
      
      This commit is a merge of the two patches indicated below.
      
      ASTERISK-23897 #close
      Reported by: Pavel Troller
      Patches:
            pri-4.diff (license #6302) patch uploaded by Pavel Troller
            jira_asterisk_23897_v11.patch (license #5621) patch uploaded by rmudgett
      
      Review: https://reviewboard.asterisk.org/r/3633/
      ........
      
      Merged revisions 417956 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@417957 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2f1d2a9e
  12. Jun 30, 2014
  13. Jun 26, 2014
    • Matthew Jordan's avatar
      res_http_websocket: Close websocket correctly and use careful fwrite · 32d684ee
      Matthew Jordan authored
      When a client takes a long time to process information received from Asterisk,
      a write operation using fwrite may fail to write all information. This causes
      the underlying file stream to be in an unknown state, such that the socket
      must be disconnected. Unfortunately, there are two problems with this in
      Asterisk's existing websocket code:
      1. Periodically, during the read loop, Asterisk must write to the connected
         websocket to respond to pings. As such, Asterisk maintains a reference to
         the session during the loop. When ast_http_websocket_write fails, it may
         cause the session to decrement its ref count, but this in and of itself
         does not break the read loop. The read loop's write, on the other hand,
         does not break the loop if it fails. This causes the socket to get in a
         'stuck' state, preventing the client from reconnecting to the server.
      2. More importantly, however, is that the fwrite in ast_http_websocket_write
         fails with a large volume of data when the client takes awhile to process
         the information. When it does fail, it fails writing only a portion of
         the bytes. With some debugging, it was shown that this was failing in a
         similar fashion to ASTERISK-12767. Switching this over to ast_careful_fwrite
         with a long enough timeout solved the problem.
      
      ASTERISK-23917 #close
      Reported by: Matt Jordan
      
      Review: https://reviewboard.asterisk.org/r/3624/
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@417310 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      32d684ee
  14. Jun 23, 2014
    • Rusty Newton's avatar
      main/features - documentation - reformat examples and options in... · cd6a931b
      Rusty Newton authored
      main/features - documentation - reformat examples and options in features.conf.sample to show clearly which options apply in which section
      
      The features.conf sample can be a bit confusing about what parking options can be set only in the general context, or both in the general context (for the default parking lot) and in other parking lot contexts. A bug was filed due to confusion and a little googling will show lots of other confused users.
      
      Despite some comments on the individual options, it still reads in a confusing way. In this patch I separate out those options with some headings in to attempt a better layout. I went ahead and modified other headings in the file, or added them to facilitate better visual scanning.
      
      ASTERISK-23667
      Review: https://reviewboard.asterisk.org/r/3622/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@417077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      cd6a931b
  15. Jun 18, 2014
  16. Jun 12, 2014
    • Richard Mudgett's avatar
      AST-2014-007: Fix DOS by consuming the number of allowed HTTP connections. · df686c50
      Richard Mudgett authored
      Simply establishing a TCP connection and never sending anything to the
      configured HTTP port in http.conf will tie up a HTTP connection.  Since
      there is a maximum number of open HTTP sessions allowed at a time you can
      block legitimate connections.
      
      A similar problem exists if a HTTP request is started but never finished.
      
      * Added http.conf session_inactivity timer option to close HTTP
      connections that aren't doing anything.  Defaults to 30000 ms.
      
      * Removed the undocumented manager.conf block-sockets option.  It
      interferes with TCP/TLS inactivity timeouts.
      
      * AMI and SIP TLS connections now have better authentication timeout
      protection.  Though I didn't remove the bizzare TLS timeout polling code
      from chan_sip.
      
      * chan_sip can now handle SSL certificate renegotiations in the middle of
      a session.  It couldn't do that before because the socket was non-blocking
      and the SSL calls were not restarted as documented by the OpenSSL
      documentation.
      
      * Fixed an off nominal leak of the ssl struct in
      handle_tcptls_connection() if the FILE stream failed to open and the SSL
      certificate negotiations failed.
      
      The patch creates a custom FILE stream handler to give the created FILE
      streams inactivity timeout and timeout after a specific moment in time
      capability.  This approach eliminates the need for code using the FILE
      stream to be redesigned to deal with the timeouts.
      
      This patch indirectly fixes most of ASTERISK-18345 by fixing the usage of
      the SSL_read/SSL_write operations.
      
      ASTERISK-23673 #close
      Reported by: Richard Mudgett
      ........
      
      Merged revisions 415841 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@415854 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      df686c50
  17. Apr 21, 2014
    • Jonathan Rose's avatar
      chan_sip: Add sendrpid trust options · 43f21b85
      Jonathan Rose authored
      In r411189, some behavior was changed which made sendrpid behavior
      act in a more trusting manner by sending full user data for peers
      set with private caller presence in P-Asserted-Identity headers.
      Since this changed long time expected behaviors, we decided to pull
      that patch when that was pointed out by the community. Instead, this
      patch provides a trust_id_outbound setting which will expose the data
      per RFC-3325 if set to 'yes' and simply not send the PAI/RPID headers
      at all if set to 'no'. By default trust_id_outbound will be set to
      'legacy' which will preserve the behavior prior to these patches.
      Extra special thanks to Walter Doekes for providing advice and
      feedback.
      
      (closes issue AST-1301)
      
      (closes issue ASTERISK-19465)
      Reported by: Krzysztof Chmielewski
      
      Review: https://reviewboard.asterisk.org/r/3447/
      ........
      
      Merged revisions 412744 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@412746 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      43f21b85
  18. Apr 15, 2014
  19. Apr 07, 2014
  20. Apr 04, 2014
    • Richard Mudgett's avatar
      internal_timing: Remove the option and always make it enabled if a timing module is loaded. · 45ebd29e
      Richard Mudgett authored
      The masquerade supertest frequently fails because either the local channel
      chain doesn't completely optimize out or the DTMF handshake doesn't
      completely get accross.  Local channel optimization requires frames
      flowing to trigger when optimization can happen.  When optimization
      happens the media frame that triggered the optimization is dropped.
      Sending DTMF requires frames to flow in the other direction for timing
      purposes while sending nothing.  If internal timing is not enabled when
      MOH is playing, Asterisk switches to received timing when an audio frame
      is received.  With optimization dropping media frames and MOH not sending
      frames unless it receives frames, occasionaly there are no more frames
      being passed and the test fails.
      
      * The asterisk command line -I option and the asterisk.conf
      internal_timing option are removed.  Asterisk now always uses internal
      timing when needed if any timing module is loaded.  The issue
      ASTERISK-14861 did this quite awhile ago in v1.4 but effectively is broken
      if other internal timing modules besides DAHDI are used.  The
      ast_read_generator_actions() now only does received timing if it has no
      choice for frame generators like MOH, silence, and playback streaming.
      
      * Cleaned up some code dealing with frame generators in
      ast_deactivate_generator(), generator_write_format_change(),
      ast_activate_generator(), and ast_channel_stop_silence_generator().
      
      ASTERISK-22846 #close
      Reported by: Matt Jordan
      
      Review: https://reviewboard.asterisk.org/r/3414/
      ........
      
      Merged revisions 411715 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@411716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      45ebd29e
  21. Mar 28, 2014
  22. Mar 26, 2014
  23. Feb 27, 2014
  24. Feb 25, 2014
  25. Feb 14, 2014
  26. Feb 10, 2014
    • Kinsey Moore's avatar
      ConfBridge: Correct prompt playback target · 2254a053
      Kinsey Moore authored
      Currently, when the first marked user enters the conference that
      contains waitmarked users, a prompt is played indicating that the user
      is being placed into the conference. Unfortunately, this prompt is
      played to the marked user and not the waitmarked users which is not
      very helpful.
      
      This patch changes that behavior to play a prompt stating
      "The conference will now begin" to the entire conference after adding
      and unmuting the waitmarked users since the design of confbridge is not
      conducive to playing a prompt to a subset of users in a conference in
      an asynchronous manner.
      
      (closes issue PQ-1396)
      Review: https://reviewboard.asterisk.org/r/3155/
      Reported by: Steve Pitts
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@407857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2254a053
  27. Feb 07, 2014
    • Richard Mudgett's avatar
      chan_iax2: Block unnecessary control frames to/from the wire. · 08d90eed
      Richard Mudgett authored
      Establishing an IAX2 call between Asterisk v1.4 and v1.8 (or later)
      results in an unexpected call disconnect.  The problem happens because
      newer values in the enum ast_control_frame_type are not consistent between
      the branch versions of Asterisk.
      
      For example:
      1) v1.4 calls v1.8 (or later) using IAX2
      
      2) v1.8 answers and sends a connected line update control frame.  (on v1.8
      AST_CONTROL_CONNECTED_LINE = 22)
      
      3) v1.4 receives the control frame as an end-of-q (on v1.4
      AST_CONTROL_END_OF_Q = 22)
      
      4) v1.4 disconnects the call once the receive queue becomes empty.
      
      Several things are done by this patch to fix the problem and attempt to
      prevent it from happening again in the future:
      
      * Added a warning at the definition of enum ast_control_frame_type about
      how to add new control frame values.
      
      * Made block sending and receiving control frames that have no reason to
      go over the wire.
      
      * Extended the connectedline iax.conf parameter to also include the
      redirecting information updates.
      
      * Updated the connectedline iax.conf parameter documentation to include a
      notice that the parameter must be "no" when the peer is an Asterisk v1.4
      instance.
      
      (closes issue AST-1302)
      
      Review: https://reviewboard.asterisk.org/r/3174/
      ........
      
      Merged revisions 407678 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@407727 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      08d90eed
    • Tzafrir Cohen's avatar
      indications.conf: add stutter tone; end properly · 47048654
      Tzafrir Cohen authored
      * If the "stutter" (voicemail indication) tone is indeed a stutter tone,
        and it ends with a constant tone, make sure that it is the dial tone.
        This was done for India (in), Mexico (mx) and the Philippines (ph).
      * If no "stutter" tone exists for a country, provide one. This was done for
        Spain (es), Malaysia (my) and Venezuela (ve).
      
      Review: https://reviewboard.asterisk.org/r/3158/
      ........
      
      Merged revisions 407622 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@407623 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      47048654
  28. Feb 04, 2014
  29. Jan 29, 2014
  30. Jan 21, 2014
  31. Jan 17, 2014
    • Rusty Newton's avatar
      Documentation: doc fixes across various parts of the code for ASTERISK issues... · 9e640759
      Rusty Newton authored
      Documentation: doc fixes across various parts of the code for ASTERISK issues 23061,23028,23046,23027
      
      Fixes typos of "transfered" instead of "transferred" in various code. Fixes incorrect gosub param help text for app_queue.
      Fixes Asterisk man pages containing unquoted minus signs. Adds note about the "textsupport" option in sip.conf.sample.
      
      (issue ASTERISK-23061)
      (issue ASTERISK-23028)
      (issue ASTERISK-23046)
      (issue ASTERISK-23027)
      (closes issue ASTERISK-23061)
      (closes issue ASTERISK-23028)
      (closes issue ASTERISK-23046)
      (closes issue ASTERISK-23027)
      Reported by: Eugene, Jeremy Laine, Denis Pantsyrev
      Patches:
       transferred.patch uploaded by Jeremy Laine (license 6561)
       hyphen.patch uploaded by Jeremy Laine (license 6561)
       sip.conf.sample.patch uploaded by Eugene (license 6360)
      ........
      
      Merged revisions 405791 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@405792 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      9e640759
  32. Jan 16, 2014
  33. Jan 14, 2014
    • Richard Mudgett's avatar
      verbosity: Fix performance of console verbose messages. · f90a045a
      Richard Mudgett authored
      The per console verbose level feature as previously implemented caused a
      large performance penalty.  The fix required some minor incompatibilities
      if the new rasterisk is used to connect to an earlier version.  If the new
      rasterisk connects to an older Asterisk version then the root console
      verbose level is always affected by the "core set verbose" command of the
      remote console even though it may appear to only affect the current
      console.  If an older version of rasterisk connects to the new version
      then the "core set verbose" command will have no effect.
      
      * Fixed the verbose performance by not generating a verbose message if
      nothing is going to use it and then filtered any generated verbose
      messages before actually sending them to the remote consoles.
      
      * Split the "core set debug" and "core set verbose" CLI commands to remove
      the per module verbose support that cannot work with the per console
      verbose level.
      
      * Added a silent option to the "core set verbose" command.
      
      * Fixed "core set debug off" tab completion.
      
      * Made "core show settings" list the current console verbosity in addition
      to the root console verbosity.
      
      * Changed the default verbose level of the 'verbose' setting in the
      logger.conf [logfiles] section.  The default is now to once again follow
      the current root console level.  As a result, using the AMI Command action
      with "core set verbose" could again set the root console verbose level and
      affect the verbose level logged.
      
      (closes issue AST-1252)
      Reported by: Guenther Kelleter
      
      Review: https://reviewboard.asterisk.org/r/3114/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@405431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f90a045a
  34. Dec 16, 2013
  35. Nov 01, 2013
    • Richard Mudgett's avatar
      config: Allow ConfBridge DTMF menus to have '#' as the first digit. · 1f051c7e
      Richard Mudgett authored
      ConfBridge allows custom DTMF menus to be created in the confbridge.conf
      file by assigning a DTMF key sequence to a sequence of actions as follows:
      
      DTMF-sequence = action,action...
      
      Unfortunately, the normal config file processing code interprets an
      initial '#' character as starting a directive such as #include.
      
      * Add the ability to escape the first non-blank character in a config line
      so the '#' character can be used without triggering the directive
      processing code.
      
      (closes issue AFS-2)
      (closes issue ASTERISK-22478)
      Reported by: Nicolas Tanski
      Patches:
            jira_asterisk_22478_v11.patch (license #5621) patch uploaded by rmudgett (modified)
      
      Review: https://reviewboard.asterisk.org/r/2969/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@402407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      1f051c7e
  36. Oct 08, 2013
  37. Sep 30, 2013
Loading