Skip to content
Snippets Groups Projects
  1. Jul 04, 2014
    • Matthew Jordan's avatar
      Remove many deprecated modules · 97834718
      Matthew Jordan authored
      Billing records are fair,
      To get paid is quite bright,
      You should really use ODBC;
      Good-bye cdr_sqlite.
      
      Microsoft did once push H.323,
      Hell, we all remember NetMeeting.
      But try to compile chan_h323 now
      And you will take quite a beating.
      
      The XMPP and SIP war was fierce,
      And in the distant fray
      Was birthed res_jabber/chan_jingle;
      But neither to stay.
      
      For everyone did care and chase what Google professed.
      "Free Internet Calling" was what devotees cried,
      But Google did change the specs so often
      That the developers were happy the day chan_gtalk died.
      
      And then there was that odd application
      Dedicated to the Polish tongue.
      app_saycountpl was subsumed by Say;
      One could say its bell was rung.
      
      To read and parse a file from the dialplan
      You could (I guess) use an application.
      app_readfile did fill that purpose, but I think
      A function is perhaps better in its creation.
      
      Barging is rude, I'm not sure why we do it.
      Inwardly, the caller will probably sigh.
      But if you really must do it,
      Don't use app_dahdibarge, use ChanSpy.
      
      We all despise the sound of tinny robots
      It makes our queues so cold.
      To control such an abomination
      It's better to not use Wait/SetMusicOnHold.
      
      It's often nice to know properties of a channel
      It makes our calls right
      We have a nice function called CHANNEL
      And so SIPCHANINFO is sent off into the night.
      
      And now things get odd;
      Apparently one could delimit with a colon
      Properties from the SIPPEER function!
      Commas are in; all others are done.
      
      Finally, a word on pipes and commas.
      We're sorry. We can't say it enough.
      But those compatibility options in asterisk.conf;
      To maintain them forever was just too tough.
      
      This patch removes:
      
      * cdr_sqlite
      * chan_gtalk
      * chan_jingle
      * chan_h323
      * res_jabber
      * app_saycountpl
      * app_readfile
      * app_dahdibarge
      
      It removes the following applications/functions:
      
      * WaitMusicOnHold
      * SetMusicOnHold
      * SIPCHANINFO
      
      It removes the colon delimiter from the SIPPEER function.
      
      Finally, it also removes all compatibility options that were configurable from
      asterisk.conf, as these all applied to compatibility with Asterisk 1.4 systems.
      
      Review: https://reviewboard.asterisk.org/r/3698/
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@418019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      97834718
  2. Apr 11, 2014
  3. Apr 04, 2014
    • Richard Mudgett's avatar
      internal_timing: Remove the option and always make it enabled if a timing module is loaded. · 03beadb6
      Richard Mudgett authored
      The masquerade supertest frequently fails because either the local channel
      chain doesn't completely optimize out or the DTMF handshake doesn't
      completely get accross.  Local channel optimization requires frames
      flowing to trigger when optimization can happen.  When optimization
      happens the media frame that triggered the optimization is dropped.
      Sending DTMF requires frames to flow in the other direction for timing
      purposes while sending nothing.  If internal timing is not enabled when
      MOH is playing, Asterisk switches to received timing when an audio frame
      is received.  With optimization dropping media frames and MOH not sending
      frames unless it receives frames, occasionaly there are no more frames
      being passed and the test fails.
      
      * The asterisk command line -I option and the asterisk.conf
      internal_timing option are removed.  Asterisk now always uses internal
      timing when needed if any timing module is loaded.  The issue
      ASTERISK-14861 did this quite awhile ago in v1.4 but effectively is broken
      if other internal timing modules besides DAHDI are used.  The
      ast_read_generator_actions() now only does received timing if it has no
      choice for frame generators like MOH, silence, and playback streaming.
      
      * Cleaned up some code dealing with frame generators in
      ast_deactivate_generator(), generator_write_format_change(),
      ast_activate_generator(), and ast_channel_stop_silence_generator().
      
      * Removed ast_internal_timing_enabled(), AST_OPT_FLAG_INTERNAL_TIMING, and
      ast_opt_internal_timing.
      
      ASTERISK-22846 #close
      Reported by: Matt Jordan
      
      Review: https://reviewboard.asterisk.org/r/3414/
      ........
      
      Merged revisions 411715 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 411716 from http://svn.asterisk.org/svn/asterisk/branches/11
      ........
      
      Merged revisions 411717 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@411724 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      03beadb6
  4. Mar 25, 2014
  5. Mar 24, 2014
  6. Mar 21, 2014
  7. Feb 27, 2014
  8. Feb 22, 2014
  9. Jan 22, 2014
  10. Nov 08, 2013
    • Kevin Harwell's avatar
      app_dahdiras: Use waitpid instead of wait4. · 2564ed26
      Kevin Harwell authored
      Several places in the code were using wait4 while other places were using
      waitpid.  This change makes all places use waitpid in order to make things
      more consistent and since the 'rusage' object passed in/out of wait4 was
      never used.
      
      (closes issue ASTERISK-22557)
      Reported by: YvesGael
      Patches:
           asterisk-11.5.1-wait4.patch uploaded by hurdman (license 6537)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@402546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2564ed26
  11. Oct 25, 2013
  12. Oct 24, 2013
  13. Sep 10, 2013
  14. Aug 06, 2013
  15. Aug 05, 2013
  16. Aug 02, 2013
  17. Aug 01, 2013
  18. Jun 13, 2013
  19. Jun 08, 2013
    • Matthew Jordan's avatar
      Add backtrace generation to MALLOC_DEBUG memory corruption reports · c43f380d
      Matthew Jordan authored
      This patch allows astmm to access the backtrace generation code in Asterisk.
      When memory is allocated, a backtrace is created and stored with the memory
      region that tracks the allocation. If a memory corruption is detected, the
      backtrace is printed to the astmm log. The backtrace will make use of the
      BETTER_BACKTRACES build option if available.
      
      As a result, this patch moves the backtrace generation code into its own file
      and uses the non-wrapped versions of the C library memory allocation routines.
      This allows the memory allocation code to safely use the backtrace generation
      routines without infinitely recursing.
      
      Review: https://reviewboard.asterisk.org/r/2567
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@391012 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      c43f380d
  20. May 02, 2013
  21. Nov 16, 2012
  22. Oct 14, 2012
  23. Oct 02, 2012
  24. Sep 22, 2012
    • Andrew Latham's avatar
      Doxygen Updates Janitor Work · fd98835f
      Andrew Latham authored
      * Whitespace, doc-blocks, spelling, case, missing and incorrect tags.
      * Add cleanup to Makefile for the Doxygen configuration update
      * Start updating Doxygen configuration for cleaner output
      * Enable inclusion of configuration files into documentation
      * remove mantisworkflow...
      * update documentation README
      * Add markup to Tilghman's email and talk with him about updating his email, he knows...
      * no code changes on this commit other than the mentioned Makefile change
      
      (issue ASTERISK-20259)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@373384 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      fd98835f
  25. Aug 18, 2012
  26. Aug 01, 2012
  27. Jul 31, 2012
  28. Jun 15, 2012
    • Kevin P. Fleming's avatar
      Multiple revisions 369001-369002 · 166b4e2b
      Kevin P. Fleming authored
      ........
        r369001 | kpfleming | 2012-06-15 10:56:08 -0500 (Fri, 15 Jun 2012) | 11 lines
        
        Add support-level indications to many more source files.
        
        Since we now have tools that scan through the source tree looking for files
        with specific support levels, we need to ensure that every file that is
        a component of a 'core' or 'extended' module (or the main Asterisk binary)
        is explicitly marked with its support level. This patch adds support-level
        indications to many more source files in tree, but avoids adding them to
        third-party libraries that are included in the tree and to source files
        that don't end up involved in Asterisk itself.
      ........
        r369002 | kpfleming | 2012-06-15 10:57:14 -0500 (Fri, 15 Jun 2012) | 3 lines
        
        Add a script to enable finding source files without support-levels defined.
      ........
      
      Merged revisions 369001-369002 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 369005 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@369013 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      166b4e2b
  29. Apr 19, 2012
    • Matthew Jordan's avatar
      Fix a variety of potential buffer overflows · f7829006
      Matthew Jordan authored
      * chan_mobile: Fixed an overrun where the cind_state buffer (an integer array
        of size 16) would be overrun due to improper bounds checking. At worst, the
        buffer can be overrun by a total of 48 bytes (assuming 4-byte integers),
        which would still leave it within the allocated memory of struct hfp.  This
        would corrupt other elements in that struct but not necessarily cause any
        further issues.
      
      * app_sms: The array imsg is of size 250, while the array (ud) that the data
        is copied into is of size 160.  If the size of the inbound message is 
        greater then 160, up to 90 bytes could be overrun in ud.  This would corrupt
        the user data header (array udh) adjacent to ud.
      
      * chan_unistim: A number of invalid memmoves are corrected.  These would move
        data (which may or may not be valid) into the ends of these buffers.
      
      * asterisk: ast_console_toggle_loglevel does not check that the console log
        level being set is less then or equal to the allowed log levels of 32.
      
      * format_pref: In ast_codec_pref_prepend, if any occurrence of the specified
        codec is not found, the value used to index into the array pref->order
        would be one greater then the maximum size of the array.
      
      * jitterbuf: If the element being placed into the jitter buffer lands in the
        last available slot in the jitter history buffer, the insertion sort attempts
        to move the last entry in the buffer into one slot past the maximum length
        of the buffer.  Note that this occurred for both the min and max jitter
        history buffers.
      
      * tdd: If a read from fsk_serial returns a character that is greater then 32,
        an attempt to read past one of the statically defined arrays containing the
        values that character maps to would occur.
      
      * localtime: struct ast_time and tm are not the same size - ast_time is larger,
        although it contains the elements of tm within it in the same layout.  Hence,
        when using memcpy to copy the contents of tm into ast_time, the size of tm
        should be used, as opposed to the size of ast_time.
      
      * extconf: this treats ast_timing's minmask array as if it had a length of 48,
        when it has defined the size of the array as 24.  pbx.h defines minmask as
        having a size of 48.
      
      (issue ASTERISK-19668)
      Reported by: Matt Jordan
      ........
      
      Merged revisions 362485 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 362496 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@362497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f7829006
  30. Mar 14, 2012
  31. Mar 13, 2012
    • Tilghman Lesher's avatar
      Enable macros in 1.8 to find the next highest "h" extension in a context, like in 1.4. · 9af5c769
      Tilghman Lesher authored
      This change restores functionality that was present in 1.4, when AEL macros
      were implemented with the Macro dialplan application.  Macros are fraught with
      functionality issues, because they consume a large portion of the underlying
      application stack.  This limits the ability of AEL users to call many layers
      of subroutines, an issue which Gosub does not have (originally tested to
      100,000 levels deep).  Therefore, starting in 1.6.0, AEL macros were
      implemented with Gosub.
      
      However, there were some implicit behaviors of Macro, which were not replicated
      at the same time as with the transition to Gosub, one of which is documented in
      the related issue.  In particular, the "h" extension is designed to execute not
      in the Macro context, but in the topmost calling context.  Due to legacy issues
      with a misapplied bugfix many years ago, when a macro exited in 1.4, it looks
      in all calling contexts, bubbling up from the deepest level until it finds an
      "h" extension.
      
      Since AEL hides the complexity of the underlying dialplan logic from the AEL
      programmer, it's reasonable to assume that this behavior should not change in
      the transition from Asterisk 1.4 LTS to Asterisk 1.8 LTS, lest we break
      working AEL configurations in the transition to Asterisk 1.8 LTS.  This fix
      is the result, which implements a search for the "h" extension in all calling
      Gosub contexts.
      
      Fixes ASTERISK-19336
      
      Patch: 20120308__ael_bugfix_for_trunk__2.diff (License #5003) by Tilghman Lesher
      	(with slight modifications for 1.8)
      
      Tested by: Johan Wilfer
      
      Review: https://reviewboard.asterisk.org/r/1776/
      ........
      
      Merged revisions 358810 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 358811 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@358812 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      9af5c769
  32. Feb 14, 2012
  33. Feb 08, 2012
  34. Jan 15, 2012
Loading