Skip to content
Snippets Groups Projects
  1. Sep 18, 2012
  2. Sep 15, 2012
  3. Sep 14, 2012
    • Matthew Jordan's avatar
      Resolve memory leaks in TLS initialization and TLS client connections · f92bb626
      Matthew Jordan authored
      This patch resolves two sources of memory leaks when using TLS in Asterisk:
      1) It removes improper initialization (and multiple re-initializations) of
         portions of the SSL library.  Asterisk calls SSL_library_init and
         SSL_load_error_strings during SSL initialization; collectively this
         obviates the need for calling any of the following during initialization
         or client connection handling:
         * ERR_load_crypto_strings (handled by SSL_load_error_strings)
         * OpenSSL_add_all_algorithms (synonym for SSL_library_init)
         * SSLeay_add_ssl_algorithms (synonym for SSL_library_init)
      2) Failure to completely clean up all memory allocated by Asterisk and by
         the SSL library for TLS clients.  This included not freeing the SSL_CTX
         object in the SIP channel driver, as well as not clearing the error
         stack when the TLS client exited.
      
      Note that these memory leaks were found by Thomas Arimont, and this patch
      was essentially written by him with some minor tweaks.
      
      (closes issue AST-889)
      Reported by: Thomas Arimont
      Tested by: Thomas Arimont
      patches:
        (bugAST-889.patch) by Thomas Arimont (license 5525)
      
      Review: https://reviewboard.asterisk.org/r/2105
      ........
      
      Merged revisions 373061 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 373062 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 373079 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@373080 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f92bb626
  4. Sep 13, 2012
  5. Sep 12, 2012
  6. Sep 11, 2012
  7. Sep 10, 2012
  8. Sep 09, 2012
  9. Sep 08, 2012
  10. Sep 07, 2012
  11. Sep 06, 2012
  12. Sep 05, 2012
Loading